I deemed them a bit redundant (assuming that developers are the only
ones that look at them anyway). But Paulo requested that I readd them
for the education of QA.
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
If the test enviroment isn't properly set up we should fail the
testcase, since otherwise there's no way to make sure a feature
actually works.
To cut down on bug triaging time extract the basic test (which was
previously used to skip all subtests) into a "basic" subtest.
Also fail the test hard if the msr interface isn't available. And
switch all other check in setup_enviroment to igt_require.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=69838
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
On the current Kernels, i2c operations on disabled eDP panels don't
work because we don't enable the panel before doing the i2c
transactions. Whenever we try these transactions we print an error
message on dmesg and fail. The current test suite was trying to work
around this problem: we count how many eDP outputs we have and add
them to the final result.
Daniel asked me to not work around the bug, so now the i2c test will
fail until we actually fix the Kernel bug (or stop using eDP panels).
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Looks like I forgot to push this chunk... The test was passing in
cases where you only have eDP monitors due to the fact that we
consider i2c won't work on eDP monitors.
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
- Use igt_require for magic SKIP results while still printing results
for all subtests.
- Wrap setup/teardown code outside of subtests with igt_fixture. This
will ensure that the so wrapped code isn't run when an
igt_require/igt_assert failed (and we're essentially just printing
the SKIP/FAIL result for all subtests) or when just enumerating
subtests.
- Use igt_exit. Otherwise SKIP/FAIL results of subtests won't be propagated
correctly.
- igt_subtest checks should be run unconditionally to make sure we
always enumerate the same set of subtests. A bit on the line here
since this is a subtest hidden behind a runtime flag.
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This test chekcs our code that enables Package C8+. The environment
requirements for this test are quite complicated:
- The machine needs to be properly configured to reach PC8+ when
possible, which means all the power management policies and device
drivers must be properly configured.
- You need at least one output connected.
- You need the /dev/cpu/0/msr file available.
- You need the /dev/i2c-* files available.
v2: - Many many changes due to the latest review comments and rebase.
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
