flywithu/ntel-gpu-tools
1
0
Fork 0
mirror of https://github.com/tiagovignatti/intel-gpu-tools.git synced 2025-06-10 01:16:18 +00:00
Code Issues Releases Wiki Activity

tests/pc8: don't work around the eDP I2C bug

Browse Source 
On the current Kernels, i2c operations on disabled eDP panels don't
work because we don't enable the panel before doing the i2c
transactions. Whenever we try these transactions we print an error
message on dmesg and fail. The current test suite was trying to work
around this problem: we count how many eDP outputs we have and add
them to the final result.

Daniel asked me to not work around the bug, so now the i2c test will
fail until we actually fix the Kernel bug (or stop using eDP panels).

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
This commit is contained in:
Paulo Zanoni 2013-08-22 11:53:09 -03:00
parent 9d29670dee
commit c62cf67a6f
1 changed files with 1 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tests/pc8.c
View File

@ -517,17 +517,6 @@ static int count_drm_valid_edids(struct mode_set_data *data)
return ret;
}
static int count_drm_edp_outputs(struct mode_set_data *data)
{
int i, ret = 0;
for (i = 0; i < data->res->count_connectors; i++)
if (data->connectors[i]->connector_type ==
DRM_MODE_CONNECTOR_eDP)
ret++;
return ret;
}
static bool i2c_edid_is_valid(int fd)
{
int rc;
@ -581,16 +570,12 @@ static int count_i2c_valid_edids(void)
return ret;
}
/* We run this test when all outputs are turned off. When eDP panels are turned
* off, I2C doesn't work on them and we get a nice dmesg backtrace. So count how
* many eDP panels we have and subtract them. */
static bool test_i2c(struct mode_set_data *data)
{
int i2c_edids = count_i2c_valid_edids();
int drm_edids = count_drm_valid_edids(data);
int edps = count_drm_edp_outputs(data);
return i2c_edids + edps == drm_edids;
return i2c_edids == drm_edids;
}
static bool setup_environment(void)