mirror of
				https://github.com/tiagovignatti/intel-gpu-tools.git
				synced 2025-11-04 03:58:27 +00:00 
			
		
		
		
	kms_panel_fitting: Remove un-read variable pipe_crc.
pipe_crc in data_t is assigned an allocated memory space and then later free'd. But it is never used for any comparisons. It should therefore be safe to remove pipe_crc and the crc requirement. Signed-off-by: Robert Foss <robert.foss@collabora.com> Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
This commit is contained in:
		
							parent
							
								
									761ac544e7
								
							
						
					
					
						commit
						e2e56a9039
					
				@ -32,7 +32,6 @@ typedef struct {
 | 
			
		||||
	int drm_fd;
 | 
			
		||||
	igt_display_t display;
 | 
			
		||||
	igt_crc_t ref_crc;
 | 
			
		||||
	igt_pipe_crc_t *pipe_crc;
 | 
			
		||||
 | 
			
		||||
	int image_w;
 | 
			
		||||
	int image_h;
 | 
			
		||||
@ -59,10 +58,6 @@ static void prepare_crtc(data_t *data, igt_output_t *output, enum pipe pipe,
 | 
			
		||||
 | 
			
		||||
	igt_output_set_pipe(output, pipe);
 | 
			
		||||
 | 
			
		||||
	/* create the pipe_crc object for this pipe */
 | 
			
		||||
	igt_pipe_crc_free(data->pipe_crc);
 | 
			
		||||
	data->pipe_crc = igt_pipe_crc_new(pipe, INTEL_PIPE_CRC_SOURCE_AUTO);
 | 
			
		||||
 | 
			
		||||
	/* before allocating, free if any older fb */
 | 
			
		||||
	if (data->fb_id1) {
 | 
			
		||||
		igt_remove_fb(data->drm_fd, &data->fb1);
 | 
			
		||||
@ -109,9 +104,6 @@ static void cleanup_crtc(data_t *data, igt_output_t *output, igt_plane_t *plane)
 | 
			
		||||
{
 | 
			
		||||
	igt_display_t *display = &data->display;
 | 
			
		||||
 | 
			
		||||
	igt_pipe_crc_free(data->pipe_crc);
 | 
			
		||||
	data->pipe_crc = NULL;
 | 
			
		||||
 | 
			
		||||
	if (data->fb_id1) {
 | 
			
		||||
		igt_remove_fb(data->drm_fd, &data->fb1);
 | 
			
		||||
		data->fb_id1 = 0;
 | 
			
		||||
@ -222,7 +214,6 @@ igt_simple_main
 | 
			
		||||
	igt_skip_on_simulation();
 | 
			
		||||
 | 
			
		||||
	data.drm_fd = drm_open_driver(DRIVER_INTEL);
 | 
			
		||||
	igt_require_pipe_crc();
 | 
			
		||||
	igt_display_init(&data.display, data.drm_fd);
 | 
			
		||||
 | 
			
		||||
	test_panel_fitting(&data);
 | 
			
		||||
 | 
			
		||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user