flywithu/ntel-gpu-tools
1
0
Fork 0
mirror of https://github.com/tiagovignatti/intel-gpu-tools.git synced 2025-11-03 11:37:14 +00:00
Code Issues Releases Wiki Activity

tests/kms_fbc_crc: fix debugfs read

Browse Source 
Commit 47f6b1305cc3752f318a555b932e194e1500c1d8 completely broke this
test due to the fread() assertion. When we're reading the debugfs file
we really don't care about how many bytes we read because the number
is not constant and we just use strstr() later. Change the assertion
to make it check for at least 1 byte read, just to make sure no one
changes that again.

Regression introduced by:
commit 47f6b1305cc3752f318a555b932e194e1500c1d8
Author: Thomas Wood <thomas.wood@intel.com>
Date:   Wed Mar 25 16:42:57 2015 +0000
    igt.cocci: check the return values of various functions

Cc: Thomas Wood <thomas.wood@intel.com>
Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
This commit is contained in:
Paulo Zanoni 2015-05-05 16:20:05 -03:00
parent 159562c825
commit 8d3023c15b
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tests/kms_fbc_crc.c
View File

@ -197,7 +197,7 @@ static bool fbc_enabled(data_t *data)
status = igt_debugfs_fopen("i915_fbc_status", "r");
igt_assert(status);
igt_assert_eq(fread(str, sizeof(str) - 1, 1, status), 1);
igt_assert(fread(str, 1, sizeof(str) - 1, status) > 0);
fclose(status);
return strstr(str, "FBC enabled") != NULL;
}