From 8d3023c15bcc9890ab7b89fa8ae4564a295078c2 Mon Sep 17 00:00:00 2001 From: Paulo Zanoni Date: Tue, 5 May 2015 16:20:05 -0300 Subject: [PATCH] tests/kms_fbc_crc: fix debugfs read Commit 47f6b1305cc3752f318a555b932e194e1500c1d8 completely broke this test due to the fread() assertion. When we're reading the debugfs file we really don't care about how many bytes we read because the number is not constant and we just use strstr() later. Change the assertion to make it check for at least 1 byte read, just to make sure no one changes that again. Regression introduced by: commit 47f6b1305cc3752f318a555b932e194e1500c1d8 Author: Thomas Wood Date: Wed Mar 25 16:42:57 2015 +0000 igt.cocci: check the return values of various functions Cc: Thomas Wood Signed-off-by: Paulo Zanoni --- tests/kms_fbc_crc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_fbc_crc.c b/tests/kms_fbc_crc.c index 16f2464f..37527d8a 100644 --- a/tests/kms_fbc_crc.c +++ b/tests/kms_fbc_crc.c @@ -197,7 +197,7 @@ static bool fbc_enabled(data_t *data) status = igt_debugfs_fopen("i915_fbc_status", "r"); igt_assert(status); - igt_assert_eq(fread(str, sizeof(str) - 1, 1, status), 1); + igt_assert(fread(str, 1, sizeof(str) - 1, status) > 0); fclose(status); return strstr(str, "FBC enabled") != NULL; }