flywithu/android-library
1
0
Fork 0
mirror of https://github.com/owncloud/android-library.git synced 2025-06-07 16:06:08 +00:00
Code Issues Releases Wiki Activity

Added unit test for OwnCloudClientManagerFactory

Browse Source
This commit is contained in:
David A. Velasco 2014-06-17 14:12:30 +02:00
parent 2e4fc047af
commit c01001b5a1
2 changed files with 164 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/com/owncloud/android/lib/common/OwnCloudClientManagerFactory.java
View File

@ -7,7 +7,7 @@ public class OwnCloudClientManagerFactory {
SINGLE_SESSION_PER_ACCOUNT
}
public static Policy sDefaultPolicy = Policy.ALWAYS_NEW_CLIENT;
private static Policy sDefaultPolicy = Policy.ALWAYS_NEW_CLIENT;
private static OwnCloudClientManager sDefaultSingleton;
@ -35,13 +35,20 @@ public class OwnCloudClientManagerFactory {
return sDefaultSingleton;
}
public static Policy getDefaultPolicy() {
return sDefaultPolicy;
}
public static void setDefaultPolicy(Policy policy) {
if (policy == null) {
throw new IllegalArgumentException("Default policy cannot be NULL");
}
if (defaultSingletonMustBeUpdated(policy)) {
sDefaultSingleton = null;
}
sDefaultPolicy = policy;
}
private static boolean defaultSingletonMustBeUpdated(Policy policy) {
if (sDefaultSingleton == null) {
return false;

155
test_client/tests/src/com/owncloud/android/lib/test_project/test/OwnCloudClientManagerFactoryTest.java Normal file
View File

@ -0,0 +1,155 @@
/* ownCloud Android Library is available under MIT license
* Copyright (C) 2014 ownCloud Inc.
*
* Permission is hereby granted, free of charge, to any person obtaining a copy
* of this software and associated documentation files (the "Software"), to deal
* in the Software without restriction, including without limitation the rights
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
* copies of the Software, and to permit persons to whom the Software is
* furnished to do so, subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in
* all copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
* EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
* MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
* NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS
* BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN
* ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
* CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
* THE SOFTWARE.
*
*/
package com.owncloud.android.lib.test_project.test;
import com.owncloud.android.lib.common.OwnCloudClientManager;
import com.owncloud.android.lib.common.OwnCloudClientManagerFactory;
import com.owncloud.android.lib.common.SingleSessionManager;
import com.owncloud.android.lib.common.OwnCloudClientManagerFactory.Policy;
import com.owncloud.android.lib.common.SimpleFactoryManager;
import junit.framework.AssertionFailedError;
import junit.framework.TestCase;
/**
* Unit test for OwnCloudClientManagerFactory
*
* @author David A. Velasco
*/
public class OwnCloudClientManagerFactoryTest extends TestCase {
@Override
protected void setUp() {
OwnCloudClientManagerFactory.setDefaultPolicy(Policy.ALWAYS_NEW_CLIENT);
}
public void testGetDefaultPolicy() {
Policy defaultPolicy = OwnCloudClientManagerFactory.getDefaultPolicy();
assertNotNull("Returned null value", defaultPolicy);
assertTrue("Returned unknown value",
(Policy.ALWAYS_NEW_CLIENT.equals(defaultPolicy) ||
(Policy.SINGLE_SESSION_PER_ACCOUNT.equals(defaultPolicy))));
}
public void testSetDefaultPolicy() {
OwnCloudClientManagerFactory.setDefaultPolicy(Policy.SINGLE_SESSION_PER_ACCOUNT);
Policy defaultPolicy = OwnCloudClientManagerFactory.getDefaultPolicy();
assertEquals("SINGLE_SESSION_PER_ACCOUNT not set",
Policy.SINGLE_SESSION_PER_ACCOUNT, defaultPolicy);
OwnCloudClientManagerFactory.setDefaultPolicy(Policy.ALWAYS_NEW_CLIENT);
defaultPolicy = OwnCloudClientManagerFactory.getDefaultPolicy();
assertEquals("ALWAYS_NEW_CLIENT not set", Policy.ALWAYS_NEW_CLIENT, defaultPolicy);
try {
OwnCloudClientManagerFactory.setDefaultPolicy(null);
throw new AssertionFailedError("Accepted NULL parameter");
} catch(Exception e) {
assertTrue("Unexpected exception when setting default policy null",
(e instanceof IllegalArgumentException));
}
defaultPolicy = OwnCloudClientManagerFactory.getDefaultPolicy();
assertEquals("ALWAYS_NEW_CLIENT changed after setting null",
Policy.ALWAYS_NEW_CLIENT, defaultPolicy);
}
public void testGetDefaultSingleton() {
OwnCloudClientManager mgr = OwnCloudClientManagerFactory.getDefaultSingleton();
assertNotNull("Returned NULL default singleton", mgr);
assertTrue("Default singleton does not implement default policy",
mgr instanceof SimpleFactoryManager);
OwnCloudClientManager mgr2 = OwnCloudClientManagerFactory.getDefaultSingleton();
assertSame("Not singleton", mgr, mgr2);
OwnCloudClientManagerFactory.setDefaultPolicy(Policy.SINGLE_SESSION_PER_ACCOUNT);
mgr = OwnCloudClientManagerFactory.getDefaultSingleton();
assertNotNull("Returned NULL default singleton", mgr);
assertTrue("Default singleton does not implement default policy",
mgr instanceof SingleSessionManager);
mgr2 = OwnCloudClientManagerFactory.getDefaultSingleton();
assertSame("Not singleton", mgr, mgr2);
}
public void testNewDefaultOwnCloudClientManager() {
OwnCloudClientManager mgr = OwnCloudClientManagerFactory.newDefaultOwnCloudClientManager();
assertNotNull("Returned NULL default manager", mgr);
assertTrue("New manager does not implement default policy",
mgr instanceof SimpleFactoryManager);
assertNotSame("Not new instance",
mgr, OwnCloudClientManagerFactory.getDefaultSingleton());
assertNotSame("Not new instance",
mgr, OwnCloudClientManagerFactory.newDefaultOwnCloudClientManager());
OwnCloudClientManagerFactory.setDefaultPolicy(Policy.SINGLE_SESSION_PER_ACCOUNT);
mgr = OwnCloudClientManagerFactory.newDefaultOwnCloudClientManager();
assertNotNull("Returned NULL default manager", mgr);
assertTrue("New manager does not implement default policy",
mgr instanceof SingleSessionManager);
assertNotSame("Not new instance",
mgr, OwnCloudClientManagerFactory.getDefaultSingleton());
assertNotSame("Not new instance",
mgr, OwnCloudClientManagerFactory.newDefaultOwnCloudClientManager());
}
public void testNewOwnCloudClientManager() {
OwnCloudClientManager mgr = OwnCloudClientManagerFactory.
newOwnCloudClientManager(Policy.ALWAYS_NEW_CLIENT);
assertNotNull("Returned NULL manager", mgr);
assertTrue("New manager does not implement policy ALWAYS_NEW_CLIENT",
mgr instanceof SimpleFactoryManager);
assertNotSame("Not new instance",
mgr, OwnCloudClientManagerFactory.getDefaultSingleton());
assertNotSame("Not new instance",
mgr, OwnCloudClientManagerFactory.newDefaultOwnCloudClientManager());
assertNotSame("Not new instance",
mgr, OwnCloudClientManagerFactory.newOwnCloudClientManager(
Policy.ALWAYS_NEW_CLIENT));
OwnCloudClientManager mgr2 = OwnCloudClientManagerFactory.
newOwnCloudClientManager(Policy.SINGLE_SESSION_PER_ACCOUNT);
assertNotNull("Returned NULL manager", mgr2);
assertTrue("New manager does not implement policy SINGLE_SESSION_PER_ACCOUNT",
mgr2 instanceof SingleSessionManager);
assertNotSame("Not new instance",
mgr2, OwnCloudClientManagerFactory.getDefaultSingleton());
assertNotSame("Not new instance",
mgr2, OwnCloudClientManagerFactory.newDefaultOwnCloudClientManager());
assertNotSame("Not new instance",
mgr2, OwnCloudClientManagerFactory.newOwnCloudClientManager(
Policy.SINGLE_SESSION_PER_ACCOUNT));
}
}