mirror of
https://github.com/mik3y/usb-serial-for-android.git
synced 2026-08-11 16:32:53 +00:00
fixed some warnings
This commit is contained in:
+11
-14
@@ -142,7 +142,7 @@ public class DeviceTest {
|
||||
}
|
||||
|
||||
private static class TestBuffer {
|
||||
private byte[] buf;
|
||||
private final byte[] buf;
|
||||
private int len;
|
||||
|
||||
private TestBuffer(int length) {
|
||||
@@ -937,7 +937,7 @@ public class DeviceTest {
|
||||
int purgeTimeout = 250;
|
||||
TestBuffer tbuf;
|
||||
long begin;
|
||||
int duration1, duration2, retries, i, timeout;
|
||||
int duration1, duration2, retries, i;
|
||||
retries = purge ? 10 : 1;
|
||||
tbuf = new TestBuffer(writeBufferSize);
|
||||
|
||||
@@ -1260,7 +1260,7 @@ public class DeviceTest {
|
||||
usb.setParameters(2400, 8, 1, UsbSerialPort.PARITY_NONE);
|
||||
telnet.setParameters(2400, 8, 1, UsbSerialPort.PARITY_NONE);
|
||||
byte[] buf = new byte[64];
|
||||
for(int i=0; i<buf.length; i++) buf[i]='a';
|
||||
Arrays.fill(buf, (byte) 'a');
|
||||
StringBuilder data = new StringBuilder();
|
||||
|
||||
usb.write(buf);
|
||||
@@ -1449,17 +1449,14 @@ public class DeviceTest {
|
||||
public void readTimeout() throws Exception {
|
||||
final Boolean[] closed = {Boolean.FALSE};
|
||||
|
||||
Runnable closeThread = new Runnable() {
|
||||
@Override
|
||||
public void run() {
|
||||
try {
|
||||
Thread.sleep(100);
|
||||
} catch (InterruptedException e) {
|
||||
e.printStackTrace();
|
||||
}
|
||||
usb.close();
|
||||
closed[0] = true;
|
||||
}
|
||||
Runnable closeThread = () -> {
|
||||
try {
|
||||
Thread.sleep(100);
|
||||
} catch (InterruptedException e) {
|
||||
e.printStackTrace();
|
||||
}
|
||||
usb.close();
|
||||
closed[0] = true;
|
||||
};
|
||||
|
||||
usb.open(EnumSet.of(UsbWrapper.OpenCloseFlags.NO_IOMANAGER_THREAD));
|
||||
|
||||
+1
-1
@@ -287,7 +287,7 @@ public class CdcAcmSerialDriver implements UsbSerialDriver {
|
||||
}
|
||||
|
||||
public static Map<Integer, int[]> getSupportedDevices() {
|
||||
final Map<Integer, int[]> supportedDevices = new LinkedHashMap<Integer, int[]>();
|
||||
final Map<Integer, int[]> supportedDevices = new LinkedHashMap<>();
|
||||
supportedDevices.put(UsbId.VENDOR_ARDUINO,
|
||||
new int[] {
|
||||
UsbId.ARDUINO_UNO,
|
||||
|
||||
+1
-1
@@ -363,7 +363,7 @@ public class Ch34xSerialDriver implements UsbSerialDriver {
|
||||
}
|
||||
|
||||
public static Map<Integer, int[]> getSupportedDevices() {
|
||||
final Map<Integer, int[]> supportedDevices = new LinkedHashMap<Integer, int[]>();
|
||||
final Map<Integer, int[]> supportedDevices = new LinkedHashMap<>();
|
||||
supportedDevices.put(UsbId.VENDOR_QINHENG, new int[]{
|
||||
UsbId.QINHENG_CH340,
|
||||
UsbId.QINHENG_CH341A,
|
||||
|
||||
+1
-1
@@ -322,7 +322,7 @@ public class Cp21xxSerialDriver implements UsbSerialDriver {
|
||||
}
|
||||
|
||||
public static Map<Integer, int[]> getSupportedDevices() {
|
||||
final Map<Integer, int[]> supportedDevices = new LinkedHashMap<Integer, int[]>();
|
||||
final Map<Integer, int[]> supportedDevices = new LinkedHashMap<>();
|
||||
supportedDevices.put(UsbId.VENDOR_SILABS,
|
||||
new int[] {
|
||||
UsbId.SILABS_CP2102, // same ID for CP2101, CP2103, CP2104, CP2109
|
||||
|
||||
+1
-1
@@ -415,7 +415,7 @@ public class FtdiSerialDriver implements UsbSerialDriver {
|
||||
}
|
||||
|
||||
public static Map<Integer, int[]> getSupportedDevices() {
|
||||
final Map<Integer, int[]> supportedDevices = new LinkedHashMap<Integer, int[]>();
|
||||
final Map<Integer, int[]> supportedDevices = new LinkedHashMap<>();
|
||||
supportedDevices.put(UsbId.VENDOR_FTDI,
|
||||
new int[] {
|
||||
UsbId.FTDI_FT232R,
|
||||
|
||||
@@ -21,7 +21,7 @@ import java.util.Map;
|
||||
public class ProbeTable {
|
||||
|
||||
private final Map<Pair<Integer, Integer>, Class<? extends UsbSerialDriver>> mProbeTable =
|
||||
new LinkedHashMap<Pair<Integer,Integer>, Class<? extends UsbSerialDriver>>();
|
||||
new LinkedHashMap<>();
|
||||
|
||||
/**
|
||||
* Adds or updates a (vendor, product) pair in the table.
|
||||
|
||||
+2
-2
@@ -35,7 +35,7 @@ public class ProlificSerialDriver implements UsbSerialDriver {
|
||||
28800, 38400, 57600, 115200, 128000, 134400, 161280, 201600, 230400, 268800,
|
||||
403200, 460800, 614400, 806400, 921600, 1228800, 2457600, 3000000, 6000000
|
||||
};
|
||||
private enum DeviceType { DEVICE_TYPE_01, DEVICE_TYPE_HX};
|
||||
private enum DeviceType { DEVICE_TYPE_01, DEVICE_TYPE_HX}
|
||||
|
||||
private final UsbDevice mDevice;
|
||||
private final UsbSerialPort mPort;
|
||||
@@ -502,7 +502,7 @@ public class ProlificSerialDriver implements UsbSerialDriver {
|
||||
}
|
||||
|
||||
public static Map<Integer, int[]> getSupportedDevices() {
|
||||
final Map<Integer, int[]> supportedDevices = new LinkedHashMap<Integer, int[]>();
|
||||
final Map<Integer, int[]> supportedDevices = new LinkedHashMap<>();
|
||||
supportedDevices.put(UsbId.VENDOR_PROLIFIC,
|
||||
new int[] { UsbId.PROLIFIC_PL2303, });
|
||||
return supportedDevices;
|
||||
|
||||
+2
-2
@@ -46,11 +46,11 @@ public class UsbSerialProber {
|
||||
* not require permission from the Android USB system, since it does not
|
||||
* open any of the devices.
|
||||
*
|
||||
* @param usbManager
|
||||
* @param usbManager usb manager
|
||||
* @return a list, possibly empty, of all compatible drivers
|
||||
*/
|
||||
public List<UsbSerialDriver> findAllDrivers(final UsbManager usbManager) {
|
||||
final List<UsbSerialDriver> result = new ArrayList<UsbSerialDriver>();
|
||||
final List<UsbSerialDriver> result = new ArrayList<>();
|
||||
|
||||
for (final UsbDevice usbDevice : usbManager.getDeviceList().values()) {
|
||||
final UsbSerialDriver driver = probeDevice(usbDevice);
|
||||
|
||||
+3
-3
@@ -52,12 +52,12 @@ public class SerialInputOutputManager implements Runnable {
|
||||
/**
|
||||
* Called when new incoming data is available.
|
||||
*/
|
||||
public void onNewData(byte[] data);
|
||||
void onNewData(byte[] data);
|
||||
|
||||
/**
|
||||
* Called when {@link SerialInputOutputManager#run()} aborts due to an error.
|
||||
*/
|
||||
public void onRunError(Exception e);
|
||||
void onRunError(Exception e);
|
||||
}
|
||||
|
||||
public SerialInputOutputManager(UsbSerialPort serialPort) {
|
||||
@@ -200,7 +200,7 @@ public class SerialInputOutputManager implements Runnable {
|
||||
|
||||
private void step() throws IOException {
|
||||
// Handle incoming data.
|
||||
byte[] buffer = null;
|
||||
byte[] buffer;
|
||||
synchronized (mReadBufferLock) {
|
||||
buffer = mReadBuffer.array();
|
||||
}
|
||||
|
||||
+2
-2
@@ -48,7 +48,7 @@ public class FtdiSerialDriverTest {
|
||||
len = port.readFilter(buf, 0);
|
||||
assertEquals(len, 0);
|
||||
|
||||
assertThrows(IOException.class, () -> {port.readFilter(buf, 1);});
|
||||
assertThrows(IOException.class, () -> port.readFilter(buf, 1));
|
||||
|
||||
initBuf(buf);
|
||||
len = port.readFilter(buf, 2);
|
||||
@@ -69,7 +69,7 @@ public class FtdiSerialDriverTest {
|
||||
assertEquals(len, 62);
|
||||
assertTrue(testBuf(buf, len));
|
||||
|
||||
assertThrows(IOException.class, () -> {port.readFilter(buf, 65);});
|
||||
assertThrows(IOException.class, () -> port.readFilter(buf, 65));
|
||||
|
||||
initBuf(buf);
|
||||
len = port.readFilter(buf, 66);
|
||||
|
||||
Reference in New Issue
Block a user