flywithu/usb-serial-for-android
1
0
Fork 0
mirror of https://github.com/mik3y/usb-serial-for-android synced 2025-10-31 02:17:23 +00:00
Code Issues Releases Wiki Activity

replace catch+throw with finally !ok, to get rid of UnhandledException shown as error

Browse Source 
method declared as throwing only IOException, but unchecked exceptions can always happen
This commit is contained in:
Kai Morich 2024-06-23 19:17:43 +02:00
parent 275590027b
commit 843792001f
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
usbSerialForAndroid/src/main/java/com/hoho/android/usbserial/driver/CommonUsbSerialPort.java
View File

@ -117,6 +117,7 @@ public abstract class CommonUsbSerialPort implements UsbSerialPort {
throw new IllegalArgumentException("Connection is null"); throw new IllegalArgumentException("Connection is null");
} }
mConnection = connection; mConnection = connection;
boolean ok = false;
try { try {
openInt(); openInt();
if (mReadEndpoint == null || mWriteEndpoint == null) { if (mReadEndpoint == null || mWriteEndpoint == null) {
@ -124,11 +125,13 @@ public abstract class CommonUsbSerialPort implements UsbSerialPort {
} }
mUsbRequest = new UsbRequest(); mUsbRequest = new UsbRequest();
mUsbRequest.initialize(mConnection, mReadEndpoint); mUsbRequest.initialize(mConnection, mReadEndpoint);
} catch(Exception e) { ok = true;
} finally {
if (!ok) {
try { try {
close(); close();
} catch(Exception ignored) {} } catch (Exception ignored) {}
throw e; }
} }
} }