From 76f9198c02b102412e3f0e7a7100438db89db40b Mon Sep 17 00:00:00 2001 From: kai-morich Date: Sun, 26 Sep 2021 07:52:49 +0200 Subject: [PATCH] more configurable debug log, disabled by default (#389) --- .../java/com/hoho/android/usbserial/util/UsbWrapper.java | 2 ++ .../hoho/android/usbserial/driver/CommonUsbSerialPort.java | 5 ++++- .../android/usbserial/util/SerialInputOutputManager.java | 4 +++- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/usbSerialForAndroid/src/androidTest/java/com/hoho/android/usbserial/util/UsbWrapper.java b/usbSerialForAndroid/src/androidTest/java/com/hoho/android/usbserial/util/UsbWrapper.java index 932bdb1..5bf114d 100644 --- a/usbSerialForAndroid/src/androidTest/java/com/hoho/android/usbserial/util/UsbWrapper.java +++ b/usbSerialForAndroid/src/androidTest/java/com/hoho/android/usbserial/util/UsbWrapper.java @@ -12,6 +12,7 @@ import android.net.Uri; import android.util.Log; import com.hoho.android.usbserial.driver.CdcAcmSerialDriver; +import com.hoho.android.usbserial.driver.CommonUsbSerialPort; import com.hoho.android.usbserial.driver.UsbSerialDriver; import com.hoho.android.usbserial.driver.UsbSerialPort; @@ -53,6 +54,7 @@ public class UsbWrapper implements SerialInputOutputManager.Listener { this.serialDriver = serialDriver; this.devicePort = devicePort; serialPort = serialDriver.getPorts().get(devicePort); + CommonUsbSerialPort.DEBUG = true; } public void setUp() throws Exception { diff --git a/usbSerialForAndroid/src/main/java/com/hoho/android/usbserial/driver/CommonUsbSerialPort.java b/usbSerialForAndroid/src/main/java/com/hoho/android/usbserial/driver/CommonUsbSerialPort.java index 278cc4d..fb601b0 100644 --- a/usbSerialForAndroid/src/main/java/com/hoho/android/usbserial/driver/CommonUsbSerialPort.java +++ b/usbSerialForAndroid/src/main/java/com/hoho/android/usbserial/driver/CommonUsbSerialPort.java @@ -26,6 +26,7 @@ import java.util.EnumSet; public abstract class CommonUsbSerialPort implements UsbSerialPort { private static final String TAG = CommonUsbSerialPort.class.getSimpleName(); + public static boolean DEBUG = false; private static final int DEFAULT_WRITE_BUFFER_SIZE = 16 * 1024; private static final int MAX_READ_SIZE = 16 * 1024; // = old bulkTransfer limit @@ -238,7 +239,9 @@ public abstract class CommonUsbSerialPort implements UsbSerialPort { actualLength = mConnection.bulkTransfer(mWriteEndpoint, writeBuffer, requestLength, requestTimeout); } } - Log.d(TAG, "Wrote " + actualLength + "/" + requestLength + " offset " + offset + "/" + src.length + " timeout " + requestTimeout); + if (DEBUG) { + Log.d(TAG, "Wrote " + actualLength + "/" + requestLength + " offset " + offset + "/" + src.length + " timeout " + requestTimeout); + } if (actualLength <= 0) { if (timeout != 0 && MonotonicClock.millis() >= endTime) { SerialTimeoutException ex = new SerialTimeoutException("Error writing " + requestLength + " bytes at offset " + offset + " of total " + src.length + ", rc=" + actualLength); diff --git a/usbSerialForAndroid/src/main/java/com/hoho/android/usbserial/util/SerialInputOutputManager.java b/usbSerialForAndroid/src/main/java/com/hoho/android/usbserial/util/SerialInputOutputManager.java index 439b3de..8e11e92 100644 --- a/usbSerialForAndroid/src/main/java/com/hoho/android/usbserial/util/SerialInputOutputManager.java +++ b/usbSerialForAndroid/src/main/java/com/hoho/android/usbserial/util/SerialInputOutputManager.java @@ -223,7 +223,9 @@ public class SerialInputOutputManager implements Runnable { } int len = mSerialPort.read(buffer, mReadTimeout); if (len > 0) { - if (DEBUG) Log.d(TAG, "Read data len=" + len); + if (DEBUG) { + Log.d(TAG, "Read data len=" + len); + } final Listener listener = getListener(); if (listener != null) { final byte[] data = new byte[len];