1
0
mirror of https://github.com/mik3y/usb-serial-for-android.git synced 2026-08-19 20:33:05 +00:00

new SerialInputOutputManager.start() method

Previously recommended start action `Executors.newSingleThreadExecutor().submit(ioManager)` did not shutdown the Executor, which caused a thread leak. It's still possible to use old style start, as SerialInputOutputManager continues to implement Runnable interface.
This commit is contained in:
kai-morich
2021-04-16 17:33:41 +02:00
parent 848d4e7713
commit 128d1a00b1
5 changed files with 56 additions and 14 deletions
@@ -80,7 +80,7 @@ public class SerialInputOutputManager implements Runnable {
}
/**
* setThreadPriority. By default use higher priority than UI thread to prevent data loss
* setThreadPriority. By default a higher priority than UI thread is used to prevent data loss
*
* @param threadPriority see {@link Process#setThreadPriority(int)}
* */
@@ -142,8 +142,8 @@ public class SerialInputOutputManager implements Runnable {
return mWriteBuffer.capacity();
}
/*
* when writeAsync is used, it is recommended to use readTimeout != 0,
/**
* when using writeAsync, it is recommended to use readTimeout != 0,
* else the write will be delayed until read data is available
*/
public void writeAsync(byte[] data) {
@@ -152,6 +152,21 @@ public class SerialInputOutputManager implements Runnable {
}
}
/**
* start SerialInputOutputManager in separate thread
*/
public void start() {
if(mState != State.STOPPED)
throw new IllegalStateException("already started");
new Thread(this, this.getClass().getSimpleName()).start();
}
/**
* stop SerialInputOutputManager thread
*
* when using readTimeout == 0 (default), additionally use usbSerialPort.close() to
* interrupt blocking read
*/
public synchronized void stop() {
if (getState() == State.RUNNING) {
Log.i(TAG, "Stop requested");