From ac239f1f710bf809176bd383b2435b8d296813b0 Mon Sep 17 00:00:00 2001 From: Loic Blot Date: Tue, 17 Nov 2015 20:33:44 +0100 Subject: [PATCH] Use foreach loops to improve a little bit performance. This also permit to fix a bug on periodic sync fetches --- .../activities/GeneralSettingsActivity.java | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/main/java/fr/unix_experience/owncloud_sms/activities/GeneralSettingsActivity.java b/src/main/java/fr/unix_experience/owncloud_sms/activities/GeneralSettingsActivity.java index d880025..c3b02ff 100644 --- a/src/main/java/fr/unix_experience/owncloud_sms/activities/GeneralSettingsActivity.java +++ b/src/main/java/fr/unix_experience/owncloud_sms/activities/GeneralSettingsActivity.java @@ -97,14 +97,12 @@ public class GeneralSettingsActivity extends NrzSettingsActivity { long syncFreq = Long.parseLong(value); // Get ownCloud SMS account list - for (int i = 0; i < myAccountList.length; i++) { + for (Account acct: myAccountList) { // And get all authorities for this account - List syncList = ContentResolver.getPeriodicSyncs(myAccountList[i], GeneralSettingsActivity._accountAuthority); + List syncList = ContentResolver.getPeriodicSyncs(acct, GeneralSettingsActivity._accountAuthority); boolean foundSameSyncCycle = false; - for (int j = 0; j < syncList.size(); j++) { - PeriodicSync ps = syncList.get(i); - + for (PeriodicSync ps: syncList) { if ((ps.period == syncFreq) && (ps.extras.getInt("synctype") == 1)) { foundSameSyncCycle = true; } @@ -114,11 +112,9 @@ public class GeneralSettingsActivity extends NrzSettingsActivity { Bundle b = new Bundle(); b.putInt("synctype", 1); - ContentResolver.removePeriodicSync(myAccountList[i], - GeneralSettingsActivity._accountAuthority, b); + ContentResolver.removePeriodicSync(acct, GeneralSettingsActivity._accountAuthority, b); if (syncFreq > 0) { - ContentResolver.addPeriodicSync(myAccountList[i], - GeneralSettingsActivity._accountAuthority, b, syncFreq * 60); + ContentResolver.addPeriodicSync(acct, GeneralSettingsActivity._accountAuthority, b, syncFreq * 60); } }