From 651cde0441b3a88c2fc2a904ee8db3e2a79d1937 Mon Sep 17 00:00:00 2001 From: Ner'zhul Date: Tue, 1 Dec 2015 15:10:05 +0100 Subject: [PATCH] Crashfix This fixes issue #73 existingMessages could be null because _existingInboxMessages and other variables could be null when no messages are found in the upcoming JSON file. --- .../unix_experience/owncloud_sms/engine/SmsFetcher.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/main/java/fr/unix_experience/owncloud_sms/engine/SmsFetcher.java b/src/main/java/fr/unix_experience/owncloud_sms/engine/SmsFetcher.java index 01770ba..54d0665 100644 --- a/src/main/java/fr/unix_experience/owncloud_sms/engine/SmsFetcher.java +++ b/src/main/java/fr/unix_experience/owncloud_sms/engine/SmsFetcher.java @@ -272,9 +272,11 @@ public class SmsFetcher { existingMessages = _existingDraftsMessages; } else if (_mbID == MailboxID.SENT) { existingMessages = _existingSentMessages; - } else { - return ""; - } + } + + if (existingMessages == null) { + return ""; + } // Note: The default case isn't possible, we check the mailbox before StringBuilder sb = new StringBuilder();