flywithu/ownCloud-SMS-App
1
0
Fork 0
mirror of https://github.com/nerzhul/ownCloud-SMS-App.git synced 2025-06-10 01:16:15 +00:00
Code Issues Releases Wiki Activity

Fix wrong Thread created Toast

Browse Source 
This fixes #153
This commit is contained in:
Loic Blot 2017-09-12 08:03:06 +02:00
parent b47a36dd99
commit 47abfac7c3
No known key found for this signature in database
GPG Key ID: EFAA458E8C153987
3 changed files with 16 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
build.gradle
View File

@ -20,8 +20,8 @@ android {
defaultConfig { defaultConfig {
applicationId "fr.unix_experience.owncloud_sms" applicationId "fr.unix_experience.owncloud_sms"
versionCode 56 versionCode 57
versionName "1.2.3" versionName "1.2.4"
minSdkVersion 16 minSdkVersion 16
targetSdkVersion 26 targetSdkVersion 26
maxSdkVersion 26 maxSdkVersion 26

2
src/main/java/fr/unix_experience/owncloud_sms/activities/MainActivity.java
View File

@ -205,7 +205,7 @@ public class MainActivity extends AppCompatActivity
return; return;
} }
new SyncTask(getApplicationContext()).execute(); new SyncTask(this).execute();
Log.v(MainActivity.TAG, "Finish syncAllMessages()"); Log.v(MainActivity.TAG, "Finish syncAllMessages()");
} }

15
src/main/java/fr/unix_experience/owncloud_sms/engine/ASyncSMSSync.java
View File

@ -19,6 +19,7 @@ package fr.unix_experience.owncloud_sms.engine;
import android.accounts.Account; import android.accounts.Account;
import android.accounts.AccountManager; import android.accounts.AccountManager;
import android.app.Activity;
import android.content.Context; import android.content.Context;
import android.os.AsyncTask; import android.os.AsyncTask;
import android.util.Log; import android.util.Log;
@ -33,12 +34,14 @@ import fr.unix_experience.owncloud_sms.prefs.OCSMSSharedPrefs;
public interface ASyncSMSSync { public interface ASyncSMSSync {
class SyncTask extends AsyncTask<Void, Void, Void> { class SyncTask extends AsyncTask<Void, Void, Void> {
public SyncTask(Context context) { public SyncTask(Activity context) {
_activity = context;
_context = context; _context = context;
_smsBuffer = null; _smsBuffer = null;
} }
public SyncTask(Context context, SmsBuffer buffer) { public SyncTask(Context context, SmsBuffer buffer) {
_activity = null;
_context = context; _context = context;
_smsBuffer = buffer; _smsBuffer = buffer;
} }
@ -70,7 +73,14 @@ public interface ASyncSMSSync {
SmsBuffer smsBuffer = new SmsBuffer(); SmsBuffer smsBuffer = new SmsBuffer();
fetcher.bufferMessagesSinceDate(smsBuffer, syncStartupDate); fetcher.bufferMessagesSinceDate(smsBuffer, syncStartupDate);
if (smsBuffer.empty()) { if (smsBuffer.empty()) {
Toast.makeText(_context, _context.getString(R.string.nothing_to_sync), Toast.LENGTH_SHORT).show(); if (_activity != null) {
_activity.runOnUiThread(new Runnable() {
public void run() {
Toast.makeText(_context, _context.getString(R.string.nothing_to_sync), Toast.LENGTH_SHORT).show();
}
});
}
Log.i(ASyncSMSSync.TAG, "Finish syncAllMessages(): no more sms"); Log.i(ASyncSMSSync.TAG, "Finish syncAllMessages(): no more sms");
smsBuffer.clear(); smsBuffer.clear();
shouldSync = false; shouldSync = false;
@ -113,6 +123,7 @@ public interface ASyncSMSSync {
private final SmsBuffer _smsBuffer; private final SmsBuffer _smsBuffer;
private final Context _context; private final Context _context;
private final Activity _activity;
} }
String TAG = ASyncSMSSync.class.getSimpleName(); String TAG = ASyncSMSSync.class.getSimpleName();