flywithu/ocsms
1
0
Fork 0
mirror of https://github.com/nextcloud/ocsms.git synced 2026-08-18 11:53:05 +00:00
Code Issues Releases Wiki Activity

Code cleanup + some PHPDoc

Browse Source
This commit is contained in:
Loic Blot
2016-05-19 08:03:27 +02:00
parent 339f76cf01
commit f05d5562b8
3 changed files with 36 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
controller/apicontroller.php
+20 -2
View File
@@ -74,9 +74,12 @@ class ApiController extends Controller {
/**
* @NoAdminRequired
* @NoCSRFRequired
* @param $smsCount
* @param $smsDatas
* @return JSONResponse
*/
public function push ($smsCount, $smsDatas) {
if ($this->checkPushStructure($smsCount, $smsDatas, true) === false) {
if ($this->checkPushStructure($smsCount, $smsDatas) === false) {
return new JSONResponse(array("status" => false, "msg" => $this->errorMsg));
}
@@ -86,9 +89,12 @@ class ApiController extends Controller {
/**
* @NoAdminRequired
* @param $smsCount
* @param $smsDatas
* @return JSONResponse
*/
public function replace($smsCount, $smsDatas) {
if ($this->checkPushStructure($smsCount, $smsDatas, true) === false) {
if ($this->checkPushStructure($smsCount, $smsDatas) === false) {
return new JSONResponse(array("status" => false, "msg" => $this->errorMsg));
}
@@ -96,6 +102,11 @@ class ApiController extends Controller {
return new JSONResponse(array("status" => true, "msg" => "OK"));
}
/**
* @param $smsCount
* @param $smsDatas
* @return bool
*/
private function checkPushStructure ($smsCount, $smsDatas) {
if ($smsCount != count($smsDatas)) {
$this->errorMsg = "Error: sms count invalid";
@@ -163,6 +174,9 @@ class ApiController extends Controller {
* @NoCSRFRequired
*
* APIv2
* @param $start
* @param $limit
* @return JSONResponse
*/
public function fetchMessages($start, $limit) {
if (!is_numeric($start) || !is_numeric($limit) || $start < 0 || $limit <= 0) {
@@ -183,6 +197,10 @@ class ApiController extends Controller {
* @NoCSRFRequired
*
* APIv2
* @param $phoneNumber
* @param $start
* @param $limit
* @return JSONResponse
*/
public function fetchMessagesForNumber($phoneNumber, $start, $limit) {
if (!is_numeric($start) || !is_numeric($limit) || $start < 0 || $limit <= 0) {