From 9a6d6907cff51235b14ca4294059cbd8d45d0989 Mon Sep 17 00:00:00 2001
From: Loic Blot <loic.blot@unix-experience.fr>
Date: Thu, 28 Dec 2017 16:56:31 +0100
Subject: [PATCH] apicontroller.php: Return error 400 when messages are not
 accepted on push

---
 controller/apicontroller.php | 14 ++++++++++----
 1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/controller/apicontroller.php b/controller/apicontroller.php
index 1749ebb..9170773 100644
--- a/controller/apicontroller.php
+++ b/controller/apicontroller.php
@@ -76,7 +76,10 @@ class ApiController extends Controller {
 	 */
 	public function push ($smsCount, $smsDatas) {
 		if ($this->checkPushStructure($smsCount, $smsDatas) === false) {
-			return new JSONResponse(array("status" => false, "msg" => $this->errorMsg));
+			return new JSONResponse(
+				array("status" => false, "msg" => $this->errorMsg),
+				Http::STATUS_BAD_REQUEST
+			);
 		}
 
 		$this->smsMapper->writeToDB($this->userId, $smsDatas);
@@ -90,8 +93,11 @@ class ApiController extends Controller {
 	 * @return JSONResponse
 	 */
 	 public function replace($smsCount, $smsDatas) {
-		 if ($this->checkPushStructure($smsCount, $smsDatas) === false) {
-			return new JSONResponse(array("status" => false, "msg" => $this->errorMsg));
+		if ($this->checkPushStructure($smsCount, $smsDatas) === false) {
+			return new JSONResponse(
+				array("status" => false, "msg" => $this->errorMsg),
+				Http::STATUS_BAD_REQUEST
+			);
 		}
 
 		$this->smsMapper->writeToDB($this->userId, $smsDatas, true);
@@ -103,7 +109,7 @@ class ApiController extends Controller {
 	 * @param $smsDatas
 	 * @return bool
      */
-	private function checkPushStructure ($smsCount, $smsDatas) {
+	private function checkPushStructure (&$smsCount, &$smsDatas) {
 		if ($smsCount === NULL) {
 			$this->errorMsg = "Error: smsCount field is NULL";
 			return false;