1
0
mirror of https://github.com/nerzhul/ocsms.git synced 2025-06-08 16:36:25 +00:00

Code design

This commit is contained in:
Loic Blot 2014-09-15 13:41:18 +02:00
parent cd8c0e57f1
commit 0d14019e9f
3 changed files with 7 additions and 7 deletions

View File

@ -24,7 +24,7 @@ class SmsController extends Controller {
private $smsMapper; private $smsMapper;
private $errorMsg; private $errorMsg;
public function __construct($appName, IRequest $request, $userId, SmsMapper $mapper){ public function __construct ($appName, IRequest $request, $userId, SmsMapper $mapper){
parent::__construct($appName, $request); parent::__construct($appName, $request);
$this->userId = $userId; $this->userId = $userId;
$this->smsMapper = $mapper; $this->smsMapper = $mapper;
@ -34,7 +34,7 @@ class SmsController extends Controller {
* @NoAdminRequired * @NoAdminRequired
* @NoCSRFRequired * @NoCSRFRequired
*/ */
public function index() { public function index () {
$params = array('user' => $this->userId); $params = array('user' => $this->userId);
return new TemplateResponse($this->appName, 'main', $params); return new TemplateResponse($this->appName, 'main', $params);
} }
@ -55,7 +55,7 @@ class SmsController extends Controller {
* @NoAdminRequired * @NoAdminRequired
*/ */
private function checkPushStructure($smsCount, $smsDatas) { private function checkPushStructure ($smsCount, $smsDatas) {
if ($smsCount != count($smsDatas)) { if ($smsCount != count($smsDatas)) {
$this->errorMsg = "Error: sms count invalid"; $this->errorMsg = "Error: sms count invalid";
return false; return false;

View File

@ -17,7 +17,7 @@ class Sms extends Entity {
protected $smsAddress; protected $smsAddress;
protected $smsMsg; protected $smsMsg;
public function __construct() { public function __construct () {
$this->addType('smsId', 'integer'); $this->addType('smsId', 'integer');
$this->addType('smsDraft', 'boolean'); $this->addType('smsDraft', 'boolean');
$this->addType('smsRead', 'boolean'); $this->addType('smsRead', 'boolean');

View File

@ -16,11 +16,11 @@ use \OCP\IDb;
use \OCP\AppFramework\Db\Mapper; use \OCP\AppFramework\Db\Mapper;
class SmsMapper extends Mapper { class SmsMapper extends Mapper {
public function __construct(IDb $db) { public function __construct (IDb $db) {
parent::__construct($db, 'ocsms_smsdatas'); parent::__construct($db, 'ocsms_smsdatas');
} }
public function writeToDB($userId, $smsList, $purgeBeforeInsert = false) { public function writeToDB ($userId, $smsList, $purgeBeforeInsert = false) {
\OCP\DB::beginTransaction(); \OCP\DB::beginTransaction();
if ($purgeBeforeInsert === true) { if ($purgeBeforeInsert === true) {
@ -52,7 +52,7 @@ class SmsMapper extends Mapper {
\OCP\DB::commit(); \OCP\DB::commit();
} }
public function find($id) { public function find ($id) {
$sql = 'SELECT * FROM `*PREFIX*ocsms_smsdatas` ' . $sql = 'SELECT * FROM `*PREFIX*ocsms_smsdatas` ' .
'WHERE `id` = ?'; 'WHERE `id` = ?';
$query = $db->prepareQuery($sql); $query = $db->prepareQuery($sql);