mirror of
https://github.com/tiagovignatti/intel-gpu-tools.git
synced 2025-06-08 00:16:18 +00:00
Commit fb66cd5 (tests/gem_storedw_loop: Fix use after free for bufmgr) introduced a segmentation fault when listing subtests because drm_intel_bufmgr_destroy is called with NULL. Move this and the call to the close function inside an igt_fixture block to prevent them being called when listing subtests. Cc: Robert Beckett <robert.beckett@intel.com> Cc: Jesse Barnes <jbarnes@virtuousgeek.org> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> Signed-off-by: Thomas Wood <thomas.wood@intel.com>
188 lines
4.6 KiB
C
188 lines
4.6 KiB
C
/*
|
|
* Copyright © 2009 Intel Corporation
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a
|
|
* copy of this software and associated documentation files (the "Software"),
|
|
* to deal in the Software without restriction, including without limitation
|
|
* the rights to use, copy, modify, merge, publish, distribute, sublicense,
|
|
* and/or sell copies of the Software, and to permit persons to whom the
|
|
* Software is furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice (including the next
|
|
* paragraph) shall be included in all copies or substantial portions of the
|
|
* Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
|
|
* FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
|
|
* IN THE SOFTWARE.
|
|
*
|
|
* Authors:
|
|
* Eric Anholt <eric@anholt.net>
|
|
* Jesse Barnes <jbarnes@virtuousgeek.org> (based on gem_bad_blit.c)
|
|
*
|
|
*/
|
|
|
|
#include "igt.h"
|
|
#include <stdlib.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <fcntl.h>
|
|
#include <inttypes.h>
|
|
#include <errno.h>
|
|
#include <sys/stat.h>
|
|
#include <sys/time.h>
|
|
#include "drm.h"
|
|
#include "intel_bufmgr.h"
|
|
|
|
IGT_TEST_DESCRIPTION("Basic CS check using MI_STORE_DATA_IMM.");
|
|
|
|
#define LOCAL_I915_EXEC_VEBOX (4<<0)
|
|
|
|
static drm_intel_bufmgr *bufmgr;
|
|
struct intel_batchbuffer *batch;
|
|
static drm_intel_bo *target_buffer;
|
|
static int devid;
|
|
|
|
/*
|
|
* Testcase: Basic bsd MI check using MI_STORE_DATA_IMM
|
|
*/
|
|
|
|
static void
|
|
emit_store_dword_imm(drm_intel_bo *dest, uint32_t val)
|
|
{
|
|
int cmd;
|
|
cmd = MI_STORE_DWORD_IMM;
|
|
|
|
BEGIN_BATCH(4, 0);
|
|
OUT_BATCH(cmd);
|
|
if (batch->gen >= 8) {
|
|
OUT_RELOC(dest, I915_GEM_DOMAIN_INSTRUCTION,
|
|
I915_GEM_DOMAIN_INSTRUCTION, 0);
|
|
OUT_BATCH(val);
|
|
} else {
|
|
OUT_BATCH(0); /* reserved */
|
|
OUT_RELOC(dest, I915_GEM_DOMAIN_INSTRUCTION,
|
|
I915_GEM_DOMAIN_INSTRUCTION, 0);
|
|
OUT_BATCH(val);
|
|
}
|
|
ADVANCE_BATCH();
|
|
}
|
|
|
|
static void
|
|
store_dword_loop(int ring, int count, int divider)
|
|
{
|
|
int i, val = 0;
|
|
uint32_t *buf;
|
|
|
|
igt_info("running storedw loop on render with stall every %i batch\n", divider);
|
|
|
|
for (i = 0; i < SLOW_QUICK(0x2000, 0x10); i++) {
|
|
emit_store_dword_imm(target_buffer, val);
|
|
intel_batchbuffer_flush_on_ring(batch, ring);
|
|
|
|
if (i % divider != 0)
|
|
goto cont;
|
|
|
|
drm_intel_bo_map(target_buffer, 0);
|
|
|
|
buf = target_buffer->virtual;
|
|
igt_assert_f(buf[0] == val,
|
|
"value mismatch: cur 0x%08x, stored 0x%08x\n",
|
|
buf[0], val);
|
|
|
|
drm_intel_bo_unmap(target_buffer);
|
|
|
|
cont:
|
|
val++;
|
|
}
|
|
|
|
drm_intel_bo_map(target_buffer, 0);
|
|
buf = target_buffer->virtual;
|
|
|
|
igt_info("completed %d writes successfully, current value: 0x%08x\n", i,
|
|
buf[0]);
|
|
drm_intel_bo_unmap(target_buffer);
|
|
}
|
|
|
|
static void
|
|
store_test(int ring, int count)
|
|
{
|
|
drm_intel_bufmgr_gem_enable_reuse(bufmgr);
|
|
|
|
batch = intel_batchbuffer_alloc(bufmgr, devid);
|
|
igt_assert(batch);
|
|
|
|
target_buffer = drm_intel_bo_alloc(bufmgr, "target bo", 4096, 4096);
|
|
igt_assert(target_buffer);
|
|
|
|
store_dword_loop(ring, count, 1);
|
|
store_dword_loop(ring, count, 2);
|
|
if (!igt_run_in_simulation()) {
|
|
store_dword_loop(ring, count, 3);
|
|
store_dword_loop(ring, count, 5);
|
|
}
|
|
|
|
drm_intel_bo_unreference(target_buffer);
|
|
intel_batchbuffer_free(batch);
|
|
}
|
|
|
|
struct ring {
|
|
const char *name;
|
|
int id;
|
|
} rings[] = {
|
|
{ "bsd", I915_EXEC_BSD },
|
|
{ "render", I915_EXEC_RENDER },
|
|
{ "blt", I915_EXEC_BLT },
|
|
{ "vebox", I915_EXEC_VEBOX },
|
|
};
|
|
|
|
static void
|
|
check_test_requirements(int fd, int ringid)
|
|
{
|
|
gem_require_ring(fd, ringid);
|
|
igt_skip_on_f(intel_gen(devid) == 6 && ringid == I915_EXEC_BSD,
|
|
"MI_STORE_DATA broken on gen6 bsd\n");
|
|
}
|
|
|
|
igt_main
|
|
{
|
|
int fd, i;
|
|
|
|
igt_fixture {
|
|
fd = drm_open_driver(DRIVER_INTEL);
|
|
devid = intel_get_drm_devid(fd);
|
|
|
|
bufmgr = drm_intel_bufmgr_gem_init(fd, 4096);
|
|
igt_assert(bufmgr);
|
|
|
|
igt_skip_on_f(intel_gen(devid) < 6,
|
|
"MI_STORE_DATA can only use GTT address on gen4+/g33 and "
|
|
"needs snoopable mem on pre-gen6\n");
|
|
|
|
/* This only works with ppgtt */
|
|
igt_require(gem_uses_aliasing_ppgtt(fd));
|
|
}
|
|
|
|
for (i = 0; i < ARRAY_SIZE(rings); i++) {
|
|
|
|
igt_subtest_f("basic-%s", rings[i].name) {
|
|
check_test_requirements(fd, rings[i].id);
|
|
store_test(rings[i].id, 16*1024);
|
|
}
|
|
|
|
igt_subtest_f("long-%s", rings[i].name) {
|
|
check_test_requirements(fd, rings[i].id);
|
|
store_test(rings[i].id, 1024*1024);
|
|
}
|
|
}
|
|
|
|
igt_fixture {
|
|
drm_intel_bufmgr_destroy(bufmgr);
|
|
close(fd);
|
|
}
|
|
}
|