mirror of
				https://github.com/tiagovignatti/intel-gpu-tools.git
				synced 2025-11-04 12:07:12 +00:00 
			
		
		
		
	This should hit the bug fixed in:
    commit 8731b269f01e16193390c7276e70530366b8d626
    Author: Maneet Singh <mmaneetsingh@nvidia.com>
    Date:   Thu Oct 8 10:10:24 2015 -0400
        drm: Correct arguments to list_tail_add in create blob ioctl
        Arguments passed to list_add_tail were reversed resulting in deletion
        of old blob property everytime the new one is added.
        Fixes
        commit e2f5d2ea479b9b2619965d43db70939589afe43a
        Author: Daniel Stone <daniels@collabora.com>
        Date:   Fri May 22 13:34:51 2015 +0100
            drm/mode: Add user blob-creation ioctl
        Signed-off-by: Maneet Singh <mmaneetsingh@nvidia.com>
        [seanpaul tweaked commit subject a little]
        Signed-off-by: Sean Paul <seanpaul@chromium.org>
        Cc: stable@kernel.org # v4.2
        Reviewed-by: Daniel Stone <daniels@collabora.com>
        Reviewed-by: Jani Nikula <jani.nikula@intel.com>
        Signed-off-by: Dave Airlie <airlied@gmail.com>
which was introduced with the initial blob support in:
    commit e2f5d2ea479b9b2619965d43db70939589afe43a
    Author: Daniel Stone <daniels@collabora.com>
    Date:   Fri May 22 13:34:51 2015 +0100
        drm/mode: Add user blob-creation ioctl
        Add an ioctl which allows users to create blob properties from supplied
        data. Currently this only supports modes, creating a drm_display_mode from
        the userspace drm_mode_modeinfo.
        v2: Removed size/type checks.
            Rebased on new patches to allow error propagation from create_blob,
            as well as avoiding double-allocation.
        Signed-off-by: Daniel Stone <daniels@collabora.com>
        Reviewed-by: Maarten Lankhorst <maarten.lankhorst@intel.com>
        Tested-by: Sean Paul <seanpaul@chromium.org>
        Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Signed-off-by: Daniel Stone <daniels@collabora.com>
		
	
			
		
			
				
	
	
		
			302 lines
		
	
	
		
			7.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
			
		
		
	
	
			302 lines
		
	
	
		
			7.8 KiB
		
	
	
	
		
			C
		
	
	
	
	
	
/*
 | 
						|
 * Copyright © 2014-2015 Intel Corporation
 | 
						|
 *
 | 
						|
 * Permission is hereby granted, free of charge, to any person obtaining a
 | 
						|
 * copy of this software and associated documentation files (the "Software"),
 | 
						|
 * to deal in the Software without restriction, including without limitation
 | 
						|
 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
 | 
						|
 * and/or sell copies of the Software, and to permit persons to whom the
 | 
						|
 * Software is furnished to do so, subject to the following conditions:
 | 
						|
 *
 | 
						|
 * The above copyright notice and this permission notice (including the next
 | 
						|
 * paragraph) shall be included in all copies or substantial portions of the
 | 
						|
 * Software.
 | 
						|
 *
 | 
						|
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 | 
						|
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 | 
						|
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
 | 
						|
 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 | 
						|
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
 | 
						|
 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
 | 
						|
 * IN THE SOFTWARE.
 | 
						|
 *
 | 
						|
 * Authors:
 | 
						|
 *   Damien Lespiau <damien.lespiau@intel.com>
 | 
						|
 *   Daniel Stone <daniels@collabora.com>
 | 
						|
 */
 | 
						|
 | 
						|
#include "igt.h"
 | 
						|
#include <errno.h>
 | 
						|
#include <stdbool.h>
 | 
						|
#include <stdio.h>
 | 
						|
#include <string.h>
 | 
						|
 | 
						|
IGT_TEST_DESCRIPTION("Tests behaviour of mass-data 'blob' properties.");
 | 
						|
 | 
						|
struct local_drm_mode_get_blob {
 | 
						|
	uint32_t blob_id;
 | 
						|
	uint32_t length;
 | 
						|
	uint64_t data;
 | 
						|
};
 | 
						|
struct local_drm_mode_create_blob {
 | 
						|
	uint64_t data;
 | 
						|
	uint32_t length;
 | 
						|
	uint32_t blob_id;
 | 
						|
};
 | 
						|
struct local_drm_mode_destroy_blob {
 | 
						|
	uint32_t blob_id;
 | 
						|
};
 | 
						|
 | 
						|
#define LOCAL_DRM_IOCTL_MODE_GETPROPBLOB	DRM_IOWR(0xAC, \
 | 
						|
						struct local_drm_mode_get_blob)
 | 
						|
#define LOCAL_DRM_IOCTL_MODE_CREATEPROPBLOB	DRM_IOWR(0xBD, \
 | 
						|
						struct local_drm_mode_create_blob)
 | 
						|
#define LOCAL_DRM_IOCTL_MODE_DESTROYPROPBLOB	DRM_IOWR(0xBE, \
 | 
						|
						struct local_drm_mode_destroy_blob)
 | 
						|
 | 
						|
static const struct drm_mode_modeinfo test_mode_valid = {
 | 
						|
	.clock = 1234,
 | 
						|
	.hdisplay = 640,
 | 
						|
	.hsync_start = 641,
 | 
						|
	.hsync_end = 642,
 | 
						|
	.htotal = 643,
 | 
						|
	.hskew = 0,
 | 
						|
	.vdisplay = 480,
 | 
						|
	.vsync_start = 481,
 | 
						|
	.vsync_end = 482,
 | 
						|
	.vtotal = 483,
 | 
						|
	.vscan = 0,
 | 
						|
	.vrefresh = 60000,
 | 
						|
	.flags = 0,
 | 
						|
	.type = 0,
 | 
						|
	.name = "FROMUSER",
 | 
						|
};
 | 
						|
 | 
						|
 | 
						|
#define ioctl_or_ret_errno(fd, ioc, ioc_data) { \
 | 
						|
	if (drmIoctl(fd, ioc, ioc_data) != 0) \
 | 
						|
		return errno; \
 | 
						|
}
 | 
						|
 | 
						|
static void igt_require_propblob(int fd)
 | 
						|
{
 | 
						|
	struct local_drm_mode_create_blob c;
 | 
						|
	struct local_drm_mode_destroy_blob d;
 | 
						|
	uint32_t blob_data;
 | 
						|
	c.data = (uintptr_t) &blob_data;
 | 
						|
	c.length = sizeof(blob_data);
 | 
						|
 | 
						|
	igt_require(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_CREATEPROPBLOB, &c) == 0);
 | 
						|
	d.blob_id = c.blob_id;
 | 
						|
	igt_require(drmIoctl(fd, LOCAL_DRM_IOCTL_MODE_DESTROYPROPBLOB, &d) == 0);
 | 
						|
}
 | 
						|
 | 
						|
static int
 | 
						|
validate_prop(int fd, uint32_t prop_id)
 | 
						|
{
 | 
						|
	struct local_drm_mode_get_blob get;
 | 
						|
	struct drm_mode_modeinfo ret_mode;
 | 
						|
 | 
						|
	get.blob_id = prop_id;
 | 
						|
	get.length = 0;
 | 
						|
	get.data = (uintptr_t) 0;
 | 
						|
	ioctl_or_ret_errno(fd, LOCAL_DRM_IOCTL_MODE_GETPROPBLOB, &get);
 | 
						|
 | 
						|
	if (get.length != sizeof(test_mode_valid))
 | 
						|
		return ENOMEM;
 | 
						|
 | 
						|
	get.data = (uintptr_t) &ret_mode;
 | 
						|
	ioctl_or_ret_errno(fd, LOCAL_DRM_IOCTL_MODE_GETPROPBLOB, &get);
 | 
						|
 | 
						|
	if (memcmp(&ret_mode, &test_mode_valid, sizeof(test_mode_valid)) != 0)
 | 
						|
		return EINVAL;
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static uint32_t
 | 
						|
create_prop(int fd)
 | 
						|
{
 | 
						|
	struct local_drm_mode_create_blob create;
 | 
						|
 | 
						|
	create.length = sizeof(test_mode_valid);
 | 
						|
	create.data = (uintptr_t) &test_mode_valid;
 | 
						|
 | 
						|
	do_ioctl(fd, LOCAL_DRM_IOCTL_MODE_CREATEPROPBLOB, &create);
 | 
						|
	igt_assert_neq_u32(create.blob_id, 0);
 | 
						|
 | 
						|
	return create.blob_id;
 | 
						|
}
 | 
						|
 | 
						|
static int
 | 
						|
destroy_prop(int fd, uint32_t prop_id)
 | 
						|
{
 | 
						|
	struct local_drm_mode_destroy_blob destroy;
 | 
						|
 | 
						|
	destroy.blob_id = prop_id;
 | 
						|
	ioctl_or_ret_errno(fd, LOCAL_DRM_IOCTL_MODE_DESTROYPROPBLOB, &destroy);
 | 
						|
 | 
						|
	return 0;
 | 
						|
}
 | 
						|
 | 
						|
static void
 | 
						|
test_validate(int fd)
 | 
						|
{
 | 
						|
	struct local_drm_mode_create_blob create;
 | 
						|
	struct local_drm_mode_get_blob get;
 | 
						|
	char too_small[32];
 | 
						|
	uint32_t prop_id;
 | 
						|
 | 
						|
	memset(too_small, 0, sizeof(too_small));
 | 
						|
 | 
						|
	/* Outlandish size. */
 | 
						|
	create.length = 0x10000;
 | 
						|
	create.data = (uintptr_t) &too_small;
 | 
						|
	do_ioctl_err(fd, LOCAL_DRM_IOCTL_MODE_CREATEPROPBLOB, &create, EFAULT);
 | 
						|
 | 
						|
	/* Outlandish address. */
 | 
						|
	create.length = sizeof(test_mode_valid);
 | 
						|
	create.data = (uintptr_t) 0xdeadbeee;
 | 
						|
	do_ioctl_err(fd, LOCAL_DRM_IOCTL_MODE_CREATEPROPBLOB, &create, EFAULT);
 | 
						|
 | 
						|
	/* When we pass an incorrect size, the kernel should correct us. */
 | 
						|
	prop_id = create_prop(fd);
 | 
						|
	get.blob_id = prop_id;
 | 
						|
	get.length = sizeof(too_small);
 | 
						|
	get.data = (uintptr_t) too_small;
 | 
						|
	do_ioctl(fd, LOCAL_DRM_IOCTL_MODE_GETPROPBLOB, &get);
 | 
						|
	igt_assert_eq_u32(get.length, sizeof(test_mode_valid));
 | 
						|
 | 
						|
	get.blob_id = prop_id;
 | 
						|
	get.data = (uintptr_t) 0xdeadbeee;
 | 
						|
	do_ioctl_err(fd, LOCAL_DRM_IOCTL_MODE_CREATEPROPBLOB, &create, EFAULT);
 | 
						|
}
 | 
						|
 | 
						|
static void
 | 
						|
test_lifetime(int fd)
 | 
						|
{
 | 
						|
	int fd2;
 | 
						|
	uint32_t prop_id, prop_id2;
 | 
						|
 | 
						|
	fd2 = drm_open_driver(DRIVER_ANY);
 | 
						|
	igt_assert_fd(fd2);
 | 
						|
 | 
						|
	/* Ensure clients can see properties created by other clients. */
 | 
						|
	prop_id = create_prop(fd);
 | 
						|
	igt_assert_eq(validate_prop(fd, prop_id), 0);
 | 
						|
	igt_assert_eq(validate_prop(fd2, prop_id), 0);
 | 
						|
 | 
						|
	/* ... but can't destroy them. */
 | 
						|
	igt_assert_eq(destroy_prop(fd2, prop_id), EPERM);
 | 
						|
 | 
						|
	/* Make sure properties can't be accessed once explicitly destroyed. */
 | 
						|
	prop_id2 = create_prop(fd2);
 | 
						|
	igt_assert_eq(validate_prop(fd2, prop_id2), 0);
 | 
						|
	igt_assert_eq(destroy_prop(fd2, prop_id2), 0);
 | 
						|
	igt_assert_eq(validate_prop(fd2, prop_id2), ENOENT);
 | 
						|
	igt_assert_eq(validate_prop(fd, prop_id2), ENOENT);
 | 
						|
 | 
						|
	/* Make sure properties are cleaned up on client exit. */
 | 
						|
	prop_id2 = create_prop(fd2);
 | 
						|
	igt_assert_eq(validate_prop(fd, prop_id2), 0);
 | 
						|
	igt_assert_eq(close(fd2), 0);
 | 
						|
	igt_assert_eq(validate_prop(fd, prop_id2), ENOENT);
 | 
						|
 | 
						|
	igt_assert_eq(validate_prop(fd, prop_id), 0);
 | 
						|
	igt_assert_eq(destroy_prop(fd, prop_id), 0);
 | 
						|
	igt_assert_eq(validate_prop(fd, prop_id), ENOENT);
 | 
						|
}
 | 
						|
 | 
						|
static void
 | 
						|
test_multiple(int fd)
 | 
						|
{
 | 
						|
	uint32_t prop_ids[5];
 | 
						|
	int fd2;
 | 
						|
	int i;
 | 
						|
 | 
						|
	fd2 = drm_open_driver(DRIVER_ANY);
 | 
						|
	igt_assert_fd(fd2);
 | 
						|
 | 
						|
	/* Ensure destroying multiple properties explicitly works as needed. */
 | 
						|
	for (i = 0; i < ARRAY_SIZE(prop_ids); i++) {
 | 
						|
		prop_ids[i] = create_prop(fd2);
 | 
						|
		igt_assert_eq(validate_prop(fd, prop_ids[i]), 0);
 | 
						|
		igt_assert_eq(validate_prop(fd2, prop_ids[i]), 0);
 | 
						|
	}
 | 
						|
	for (i = 0; i < ARRAY_SIZE(prop_ids); i++) {
 | 
						|
		igt_assert_eq(destroy_prop(fd2, prop_ids[i]), 0);
 | 
						|
		igt_assert_eq(validate_prop(fd2, prop_ids[i]), ENOENT);
 | 
						|
	}
 | 
						|
	igt_assert_eq(close(fd2), 0);
 | 
						|
 | 
						|
	fd2 = drm_open_driver(DRIVER_ANY);
 | 
						|
	igt_assert_fd(fd2);
 | 
						|
 | 
						|
	/* Ensure that multiple properties get cleaned up on fd close. */
 | 
						|
	for (i = 0; i < ARRAY_SIZE(prop_ids); i++) {
 | 
						|
		prop_ids[i] = create_prop(fd2);
 | 
						|
		igt_assert_eq(validate_prop(fd, prop_ids[i]), 0);
 | 
						|
		igt_assert_eq(validate_prop(fd2, prop_ids[i]), 0);
 | 
						|
	}
 | 
						|
	igt_assert_eq(close(fd2), 0);
 | 
						|
 | 
						|
	for (i = 0; i < ARRAY_SIZE(prop_ids); i++)
 | 
						|
		igt_assert_eq(validate_prop(fd, prop_ids[i]), ENOENT);
 | 
						|
}
 | 
						|
 | 
						|
static void
 | 
						|
test_core(int fd)
 | 
						|
{
 | 
						|
	uint32_t prop_id;
 | 
						|
 | 
						|
	/* The first hurdle. */
 | 
						|
	prop_id = create_prop(fd);
 | 
						|
	igt_assert_eq(validate_prop(fd, prop_id), 0);
 | 
						|
	igt_assert_eq(destroy_prop(fd, prop_id), 0);
 | 
						|
 | 
						|
	/* Look up some invalid property IDs. They should fail. */
 | 
						|
	igt_assert_eq(validate_prop(fd, 0xffffffff), ENOENT);
 | 
						|
	igt_assert_eq(validate_prop(fd, 0), ENOENT);
 | 
						|
}
 | 
						|
 | 
						|
static void
 | 
						|
test_basic(int fd)
 | 
						|
{
 | 
						|
	uint32_t prop_id;
 | 
						|
 | 
						|
	/* A very simple gating test to ensure property support exists. */
 | 
						|
	prop_id = create_prop(fd);
 | 
						|
	igt_assert_eq(destroy_prop(fd, prop_id), 0);
 | 
						|
}
 | 
						|
 | 
						|
igt_main
 | 
						|
{
 | 
						|
	int fd;
 | 
						|
 | 
						|
	igt_skip_on_simulation();
 | 
						|
 | 
						|
	igt_fixture {
 | 
						|
		fd = drm_open_driver(DRIVER_ANY);
 | 
						|
		igt_require(fd >= 0);
 | 
						|
		igt_require_propblob(fd);
 | 
						|
	}
 | 
						|
 | 
						|
	igt_subtest("basic")
 | 
						|
		test_basic(fd);
 | 
						|
 | 
						|
	igt_subtest("blob-prop-core")
 | 
						|
		test_core(fd);
 | 
						|
 | 
						|
	igt_subtest("blob-prop-validate")
 | 
						|
		test_validate(fd);
 | 
						|
 | 
						|
	igt_subtest("blob-prop-lifetime")
 | 
						|
		test_lifetime(fd);
 | 
						|
 | 
						|
	igt_subtest("blob-multiple")
 | 
						|
		test_multiple(fd);
 | 
						|
 | 
						|
	igt_fixture
 | 
						|
		close(fd);
 | 
						|
}
 |