From f49723872bf02788872f02e37df3e48682b5ef9b Mon Sep 17 00:00:00 2001 From: Derek Morton Date: Mon, 18 May 2015 14:37:31 +0100 Subject: [PATCH] lib/igt_core.c: Flag the test as failing after a segfault fatal_signal_handler() was trapping fatal errors but not flagging the test as failing or setting an exit code. The result was that the test would return Ok or Skipped depending on what the other subtests did even though one of the subtests had segfaulted. Signed-off-by: Derek Morton Signed-off-by: Daniel Vetter --- lib/igt_core.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 6dd7af39..2cf23934 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -1438,8 +1438,15 @@ static void fatal_sig_handler(int sig) igt_assert_eq(write(STDERR_FILENO, ".\n", 2), 2); } - if (in_subtest && crash_signal(sig)) + if (in_subtest && crash_signal(sig)) { + /* Linux standard to return exit code as 128 + signal */ + if (!failed_one) + igt_exitcode = 128 + sig; + + failed_one = true; + exit_subtest("CRASH"); + } break; }