From f381a8b9f08a6d0c843e7b9f7997020d6b0d1e1a Mon Sep 17 00:00:00 2001 From: Chris Wilson Date: Wed, 14 Dec 2011 17:41:34 +0000 Subject: [PATCH] tests/gem_exec_blt: silence the compiler by failing on error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit gem_exec_blt.c: In function ‘gem_exec’: gem_exec_blt.c:174:6: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] Propagate the failure and exit(1). --- tests/gem_exec_blt.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/tests/gem_exec_blt.c b/tests/gem_exec_blt.c index 19eb7167..b2ca2d67 100644 --- a/tests/gem_exec_blt.c +++ b/tests/gem_exec_blt.c @@ -169,15 +169,17 @@ static void gem_sync(int fd, uint32_t handle) drmIoctl(fd, DRM_IOCTL_I915_GEM_SET_DOMAIN, &set_domain); } -static void gem_exec(int fd, struct drm_i915_gem_execbuffer2 *execbuf, int loops) +static int gem_exec(int fd, struct drm_i915_gem_execbuffer2 *execbuf, int loops) { - int ret; + int ret = 0; - while (loops--) { + while (loops-- && ret == 0) { ret = drmIoctl(fd, DRM_IOCTL_I915_GEM_EXECBUFFER2, execbuf); } + + return ret; } static double elapsed(const struct timeval *start, @@ -272,7 +274,8 @@ static void run(int object_size) struct timeval start, end; gettimeofday(&start, NULL); - gem_exec(fd, &execbuf, count); + if (gem_exec(fd, &execbuf, count)) + exit(1); gem_sync(fd, handle); gettimeofday(&end, NULL); printf("Time to blt %d bytes x %6d: %7.3fµs, %s\n",