flywithu/ntel-gpu-tools
1
0
Fork 0
mirror of https://github.com/tiagovignatti/intel-gpu-tools.git synced 2025-07-27 03:36:44 +00:00
Code Issues Releases Wiki Activity

tests/kms_mmap_write_crc: Use the right fork helpers

Browse Source 
For a background task the fork helpers are more appropriate, since we
can explicitly cancel children. Also, anything that does real work is
supposed to be in fixtures.

Cc: Tiago Vignatti <tiago.vignatti@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>

--
Tiago, can you pls check that I haven't broken anythig?

Thanks, Daniel
This commit is contained in:
Daniel Vetter 2016-02-18 00:17:11 +01:00
parent 771dbb06b5
commit c644c55177
1 changed files with 9 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
tests/kms_mmap_write_crc.c
View File

@ -243,6 +243,8 @@ static void run_test(data_t *data)
igt_skip("no valid crtc/connector combinations found\n"); igt_skip("no valid crtc/connector combinations found\n");
} }
struct igt_helper_process hog;
/** /**
* fork_cpuhog_helper: * fork_cpuhog_helper:
* *
@ -250,15 +252,9 @@ static void run_test(data_t *data)
* fill the CPU caches with random information so they can get stalled, * fill the CPU caches with random information so they can get stalled,
* provoking incoherency with the GPU most likely. * provoking incoherency with the GPU most likely.
*/ */
static void fork_cpuhog_helper(void) { static void fork_cpuhog_helper(void)
{
/* TODO: if the parent is about to die before its child, e.g. igt_fork_helper(&hog) {
* igt_assert_crc_equal() fails, there will be a boring exit handler
* waiting the child to exit also. A workaround is to simply disable that
* handler, buy this needs to be fixed properly in an elegant way. */
igt_disable_exit_handler();
igt_fork(hog, 1) {
while (1) { while (1) {
usleep(10); /* quite ramdom really. */ usleep(10); /* quite ramdom really. */
@ -297,16 +293,19 @@ int main(int argc, char **argv)
igt_require_pipe_crc(); igt_require_pipe_crc();
igt_display_init(&data.display, data.drm_fd); igt_display_init(&data.display, data.drm_fd);
fork_cpuhog_helper();
} }
igt_info("Using %d rounds for the test\n", ROUNDS); igt_info("Using %d rounds for the test\n", ROUNDS);
fork_cpuhog_helper();
for (i = 0; i < ROUNDS; i++) for (i = 0; i < ROUNDS; i++)
run_test(&data); run_test(&data);
igt_fixture { igt_fixture {
igt_display_fini(&data.display); igt_display_fini(&data.display);
igt_stop_helper(&hog);
} }
igt_exit(); igt_exit();