flywithu/ntel-gpu-tools
1
0
Fork 0
mirror of https://github.com/tiagovignatti/intel-gpu-tools.git synced 2025-07-23 09:56:02 +00:00
Code Issues Releases Wiki Activity

lib/igt_kms: Simplify return value of kmstest_get_connector_default_mode

Browse Source 
A plain bool is good enough, no need for fancy negative error values.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
Daniel Vetter 2014-08-12 11:56:41 +02:00
parent 3b39bfff60
commit 81dfcaba88
3 changed files with 10 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
lib/igt_kms.c
View File

@ -391,15 +391,15 @@ void kmstest_force_edid(int drm_fd, drmModeConnector *connector,
igt_assert(ret != -1);
}
int kmstest_get_connector_default_mode(int drm_fd, drmModeConnector *connector,
drmModeModeInfo *mode)
bool kmstest_get_connector_default_mode(int drm_fd, drmModeConnector *connector,
drmModeModeInfo *mode)
{
int i;
if (!connector->count_modes) {
fprintf(stderr, "no modes for connector %d\n",
connector->connector_id);
return -1;
return false;
}
for (i = 0; i < connector->count_modes; i++) {
@ -411,7 +411,7 @@ int kmstest_get_connector_default_mode(int drm_fd, drmModeConnector *connector,
}
}
return 0;
return true;
}
int kmstest_get_connector_config(int drm_fd, uint32_t connector_id,
@ -480,8 +480,8 @@ int kmstest_get_connector_config(int drm_fd, uint32_t connector_id,
goto err3;
found:
if (kmstest_get_connector_default_mode(drm_fd, connector,
&config->default_mode) < 0)
if (!kmstest_get_connector_default_mode(drm_fd, connector,
&config->default_mode))
goto err4;
config->connector = connector;

4
lib/igt_kms.h
View File

@ -152,8 +152,8 @@ bool kmstest_force_connector(int fd, drmModeConnector *connector,
void kmstest_force_edid(int drm_fd, drmModeConnector *connector,
const unsigned char *edid, size_t length);
int kmstest_get_connector_default_mode(int drm_fd, drmModeConnector *connector,
drmModeModeInfo *mode);
bool kmstest_get_connector_default_mode(int drm_fd, drmModeConnector *connector,
drmModeModeInfo *mode);
int kmstest_get_connector_config(int drm_fd, uint32_t connector_id,
unsigned long crtc_idx_mask,
struct kmstest_connector_config *config);

4
tests/kms_setmode.c
View File

@ -517,8 +517,8 @@ static int get_one_connector(drmModeRes *resources, int connector_id,
}
if (cconf->connected) {
if (kmstest_get_connector_default_mode(drm_fd, connector,
&mode) < 0)
if (!kmstest_get_connector_default_mode(drm_fd, connector,
&mode))
mode = mode_640_480;
} else {
mode = mode_640_480;