From 6526d8c6fcc10f1b100c570f1d924154cd43b2e9 Mon Sep 17 00:00:00 2001 From: Damien Lespiau Date: Tue, 12 Feb 2013 14:24:40 +0000 Subject: [PATCH] tests: Forbid to run the blit tests with count of 1 Invoking say, sudo ./tests/gem_render_linear_blits 1 does not make a lot of sense as we're creating a single bo. The test does not yell at you and passes, even if the rendercopy function does not do anything. This makes it quite harmful when trying to debug rendercopy without realizing that count is the number of allocated bos and must be >= 2. Signed-off-by: Damien Lespiau Signed-off-by: Daniel Vetter --- tests/gem_linear_blits.c | 4 ++++ tests/gem_render_linear_blits.c | 5 +++++ tests/gem_render_tiled_blits.c | 5 +++++ tests/gem_tiled_blits.c | 3 +++ 4 files changed, 17 insertions(+) diff --git a/tests/gem_linear_blits.c b/tests/gem_linear_blits.c index fe15f1d1..ec2dc56d 100644 --- a/tests/gem_linear_blits.c +++ b/tests/gem_linear_blits.c @@ -189,6 +189,10 @@ int main(int argc, char **argv) count = atoi(argv[1]); if (count == 0) count = 3 * gem_aperture_size(fd) / (1024*1024) / 2; + else if (count < 2) { + fprintf(stderr, "count must be >= 2\n"); + return 1; + } if (count > intel_get_total_ram_mb() * 9 / 10) { count = intel_get_total_ram_mb() * 9 / 10; diff --git a/tests/gem_render_linear_blits.c b/tests/gem_render_linear_blits.c index 8ba24a3d..a7e01893 100644 --- a/tests/gem_render_linear_blits.c +++ b/tests/gem_render_linear_blits.c @@ -85,6 +85,11 @@ int main(int argc, char **argv) count = atoi(argv[1]); if (count == 0) count = 3 * gem_aperture_size(fd) / SIZE / 2; + else if (count < 2) { + fprintf(stderr, "count must be >= 2\n"); + return 1; + } + printf("Using %d 1MiB buffers\n", count); bo = malloc(sizeof(*bo)*count); diff --git a/tests/gem_render_tiled_blits.c b/tests/gem_render_tiled_blits.c index 31b2ee18..626e652e 100644 --- a/tests/gem_render_tiled_blits.c +++ b/tests/gem_render_tiled_blits.c @@ -88,6 +88,11 @@ int main(int argc, char **argv) count = atoi(argv[1]); if (count == 0) count = 3 * gem_aperture_size(fd) / SIZE / 2; + else if (count < 2) { + fprintf(stderr, "count must be >= 2\n"); + return 1; + } + printf("Using %d 1MiB buffers\n", count); buf = malloc(sizeof(*buf)*count); diff --git a/tests/gem_tiled_blits.c b/tests/gem_tiled_blits.c index a6d5555f..bb439760 100644 --- a/tests/gem_tiled_blits.c +++ b/tests/gem_tiled_blits.c @@ -132,6 +132,9 @@ int main(int argc, char **argv) if (count == 0) { count = 3 * gem_aperture_size(fd) / (1024*1024) / 2; count += (count & 1) == 0; + } else if (count < 2) { + fprintf(stderr, "count must be >= 2\n"); + return 1; } if (count > intel_get_total_ram_mb() * 9 / 10) {