flywithu/ntel-gpu-tools
1
0
Fork 0
mirror of https://github.com/tiagovignatti/intel-gpu-tools.git synced 2025-06-10 09:26:10 +00:00
Code Issues Releases Wiki Activity

lib/debugfs: wait_for_keypress("crc") when collecting CRC

Browse Source 
Let's just steal the "crc" namespace and add this by default to
igt_pipe_crc_collect_crc() instead of adding more calls to other
tests. If tests want special waits on just some of their collect_crc()
calls, they can use another name instead of "crc".

This is very useful when developing, especially when the CRC we get is
wrong: we want to look at the screen to see what's going on before we
can think about how to fix the problem. So let's add this to the lib
instead of adding this to every single test I need to debug.

v2: Add some documentation (Daniel).

Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
This commit is contained in:
Paulo Zanoni 2015-05-06 15:23:51 -03:00
parent 3db5762384
commit 641d535a03
3 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/igt_debugfs.c
View File

@ -35,6 +35,7 @@
#include <i915_drm.h>
#include "drmtest.h"
#include "igt_aux.h"
#include "igt_kms.h"
#include "igt_debugfs.h"
@ -509,9 +510,14 @@ static void crc_sanity_checks(igt_crc_t *crc)
*
* This function takes care of the pipe_crc book-keeping, it will start/stop
* the collection of the CRC.
*
* This function also calls the interactive debug with the "crc" domain, so you
* can make use of this feature to actually see the screen that is being CRC'd.
*/
void igt_pipe_crc_collect_crc(igt_pipe_crc_t *pipe_crc, igt_crc_t *out_crc)
{
igt_debug_wait_for_keypress("crc");
igt_pipe_crc_start(pipe_crc);
read_one_crc(pipe_crc, out_crc);
igt_pipe_crc_stop(pipe_crc);

3
tests/kms_draw_crc.c
View File

@ -102,7 +102,6 @@ static void get_method_crc(enum igt_draw_method method, uint64_t tiling,
&ms.connector_id, 1, ms.mode);
igt_assert(rc == 0);
igt_debug_wait_for_keypress("crc");
igt_pipe_crc_collect_crc(pipe_crc, crc);
kmstest_unset_all_crtcs(drm_fd, drm_res);
@ -144,7 +143,6 @@ static void get_fill_crc(uint64_t tiling, igt_crc_t *crc)
&ms.connector_id, 1, ms.mode);
igt_assert(rc == 0);
igt_debug_wait_for_keypress("crc");
igt_pipe_crc_collect_crc(pipe_crc, crc);
kmstest_unset_all_crtcs(drm_fd, drm_res);
@ -171,7 +169,6 @@ static void fill_fb_subtest(void)
&ms.connector_id, 1, ms.mode);
igt_assert(rc == 0);
igt_debug_wait_for_keypress("crc");
igt_pipe_crc_collect_crc(pipe_crc, &base_crc);
get_fill_crc(LOCAL_DRM_FORMAT_MOD_NONE, &crc);

2
tests/kms_plane.c
View File

@ -330,8 +330,6 @@ test_plane_panning_with_output(data_t *data,
igt_pipe_crc_collect_crc(data->pipe_crc, &crc);
igt_debug_wait_for_keypress("crc");
if (flags & TEST_PANNING_TOP_LEFT)
igt_assert_crc_equal(&test.red_crc, &crc);
else