lib: Introduce igt_fail_on/_f

I've yet again totally screwed things up (this time automated with
cocci even, but not yet pushed luckily). So finally add a new version
for easier conversion and adjust the cocci script.

Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
This commit is contained in:
Daniel Vetter 2014-06-13 18:01:33 +02:00
parent 46811c849a
commit 2347e6d21e
2 changed files with 34 additions and 3 deletions

View File

@ -13,7 +13,14 @@ expression list[n] Ep;
)
- igt_fail(...);
- }
+ igt_assert_f(Ec, Ep);
+ igt_fail_on_f(Ec, Ep);
@@
expression Ec;
@@
- if (Ec) {
- igt_fail(...);
- }
+ igt_fail_on(Ec);
@@
expression Ec;
expression list[n] Ep;

View File

@ -204,7 +204,7 @@ void igt_exit(void) __attribute__((noreturn));
* igt_assert:
* @expr: condition to test
*
* Fails (sub-)test if the condition is not met
* Fails (sub-)test if the condition is not met.
*
* Should be used everywhere where a test checks results.
*/
@ -218,7 +218,7 @@ void igt_exit(void) __attribute__((noreturn));
* @expr: condition to test
* @...: format string and optional arguments
*
* Fails (sub-)test if the condition is not met
* Fails (sub-)test if the condition is not met.
*
* Should be used everywhere where a test checks results.
*
@ -230,6 +230,30 @@ void igt_exit(void) __attribute__((noreturn));
__igt_fail_assert(99, __FILE__, __LINE__, __func__, #expr , f); \
} while (0)
/**
* igt_fail_on:
* @expr: condition to test
*
* Fails (sub-)test if the condition is met.
*
* Should be used everywhere where a test checks results.
*/
#define igt_fail_on(expr) igt_assert(!(expr))
/**
* igt_assert_f:
* @expr: condition to test
* @...: format string and optional arguments
*
* Fails (sub-)test if the condition is met.
*
* Should be used everywhere where a test checks results.
*
* In addition to the plain igt_assert() helper this allows to print additional
* information to help debugging test failures.
*/
#define igt_fail_on_f(expr, f...) igt_assert_f(!(expr), f)
/**
* igt_assert_cmpint:
* @n1: first value