flywithu/ntel-gpu-tools
1
0
Fork 0
mirror of https://github.com/tiagovignatti/intel-gpu-tools.git synced 2025-06-10 01:16:18 +00:00
Code Issues Releases Wiki Activity

stats: Zero the whole structure at init() time

Browse Source 
Because the structure started small, I initialized every member
directly, but that means that the new fields added weren't properly
initialized (sigh!). Zero the whole thing first then.

Also, the punishment for introducing a bug should be to write the
corresponding unit test. It's not a perfect one, but I'll take it.

Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
This commit is contained in:
Damien Lespiau 2015-06-26 13:55:01 +01:00
parent 76ea7b9133
commit 203c3841fc
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/igt_stats.c
View File

@ -23,16 +23,18 @@
*/ */
#include <math.h> #include <math.h>
#include <string.h>
#include "igt_core.h" #include "igt_core.h"
#include "igt_stats.h" #include "igt_stats.h"
void igt_stats_init(igt_stats_t *stats, unsigned int capacity) void igt_stats_init(igt_stats_t *stats, unsigned int capacity)
{ {
memset(stats, 0, sizeof(*stats));
stats->values = calloc(capacity, sizeof(*stats->values)); stats->values = calloc(capacity, sizeof(*stats->values));
igt_assert(stats->values); igt_assert(stats->values);
stats->capacity = capacity; stats->capacity = capacity;
stats->n_values = 0;
} }
void igt_stats_fini(igt_stats_t *stats) void igt_stats_fini(igt_stats_t *stats)

11
lib/tests/igt_stats.c
View File

@ -25,6 +25,16 @@
#include "igt_core.h" #include "igt_core.h"
#include "igt_stats.h" #include "igt_stats.h"
/* Make sure we zero igt_stats_t fields at init() time */
static void test_init_zero(void)
{
igt_stats_t stats;
stats.mean = 1.;
igt_stats_init(&stats, 2);
igt_assert(stats.mean == 0.);
}
static void test_mean(void) static void test_mean(void)
{ {
igt_stats_t stats; igt_stats_t stats;
@ -103,6 +113,7 @@ static void test_std_deviation(void)
igt_simple_main igt_simple_main
{ {
test_init_zero();
test_mean(); test_mean();
test_invalidate_mean(); test_invalidate_mean();
test_std_deviation(); test_std_deviation();