mirror of
https://github.com/tiagovignatti/intel-gpu-tools.git
synced 2026-08-12 00:43:04 +00:00
stats: Zero the whole structure at init() time
Because the structure started small, I initialized every member directly, but that means that the new fields added weren't properly initialized (sigh!). Zero the whole thing first then. Also, the punishment for introducing a bug should be to write the corresponding unit test. It's not a perfect one, but I'll take it. Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
This commit is contained in:
@@ -25,6 +25,16 @@
|
||||
#include "igt_core.h"
|
||||
#include "igt_stats.h"
|
||||
|
||||
/* Make sure we zero igt_stats_t fields at init() time */
|
||||
static void test_init_zero(void)
|
||||
{
|
||||
igt_stats_t stats;
|
||||
|
||||
stats.mean = 1.;
|
||||
igt_stats_init(&stats, 2);
|
||||
igt_assert(stats.mean == 0.);
|
||||
}
|
||||
|
||||
static void test_mean(void)
|
||||
{
|
||||
igt_stats_t stats;
|
||||
@@ -103,6 +113,7 @@ static void test_std_deviation(void)
|
||||
|
||||
igt_simple_main
|
||||
{
|
||||
test_init_zero();
|
||||
test_mean();
|
||||
test_invalidate_mean();
|
||||
test_std_deviation();
|
||||
|
||||
Reference in New Issue
Block a user