mirror of
				https://github.com/zokradonh/kopano-docker
				synced 2025-10-30 18:07:46 +00:00 
			
		
		
		
	cut quotes from additional package var earlier on (#224)
* cut quotes from additional package var earlier on * add easy debugging switch to script and predefine env var in base image
This commit is contained in:
		
							parent
							
								
									4878fc9917
								
							
						
					
					
						commit
						26c45ce1db
					
				| @ -9,7 +9,8 @@ ARG KOPANO_REPOSITORY_FLAGS="trusted=yes" | |||||||
| ARG RELEASE_KEY_DOWNLOAD=0 | ARG RELEASE_KEY_DOWNLOAD=0 | ||||||
| ARG DEBIAN_FRONTEND=noninteractive | ARG DEBIAN_FRONTEND=noninteractive | ||||||
| 
 | 
 | ||||||
| ENV BASE_VERSION=1.2.0 | ENV BASE_VERSION=1.2.1 \ | ||||||
|  |     DEBUG="" | ||||||
| 
 | 
 | ||||||
| LABEL maintainer=az@zok.xyz \ | LABEL maintainer=az@zok.xyz \ | ||||||
|     org.label-schema.name="Kopano base container" \ |     org.label-schema.name="Kopano base container" \ | ||||||
|  | |||||||
| @ -4,15 +4,16 @@ ADDITIONAL_KOPANO_PACKAGES=${ADDITIONAL_KOPANO_PACKAGES:-""} | |||||||
| KCCONF_SERVER_MYSQL_SOCKET=${KCCONF_SERVER_MYSQL_SOCKET:-""} | KCCONF_SERVER_MYSQL_SOCKET=${KCCONF_SERVER_MYSQL_SOCKET:-""} | ||||||
| 
 | 
 | ||||||
| set -eu # unset variables are errors & non-zero return values exit the whole script | set -eu # unset variables are errors & non-zero return values exit the whole script | ||||||
|  | [ "$DEBUG" ] && set -x | ||||||
| 
 | 
 | ||||||
| if [ ! -e /kopano/"$SERVICE_TO_START".py ]; then | if [ ! -e /kopano/"$SERVICE_TO_START".py ]; then | ||||||
| 	echo "Invalid service specified: $SERVICE_TO_START" | ts | 	echo "Invalid service specified: $SERVICE_TO_START" | ts | ||||||
| 	exit 1 | 	exit 1 | ||||||
| fi | fi | ||||||
| 
 | 
 | ||||||
| # TODO this needs fixing as now apt update is always salled (since the value is at least "") | ADDITIONAL_KOPANO_PACKAGES=$(echo "$ADDITIONAL_KOPANO_PACKAGES" | tr -d '"') | ||||||
| [ -n "${ADDITIONAL_KOPANO_PACKAGES// }" ] && apt update | [ -n "${ADDITIONAL_KOPANO_PACKAGES// }" ] && apt update | ||||||
| [ -n "${ADDITIONAL_KOPANO_PACKAGES// }" ] && for installpkg in $(echo "$ADDITIONAL_KOPANO_PACKAGES" | tr -d '"'); do | [ -n "${ADDITIONAL_KOPANO_PACKAGES// }" ] && for installpkg in $ADDITIONAL_KOPANO_PACKAGES; do | ||||||
| 	# shellcheck disable=SC2016 disable=SC2086 | 	# shellcheck disable=SC2016 disable=SC2086 | ||||||
| 	if [ "$(dpkg-query -W -f='${Status}' $installpkg 2>/dev/null | grep -c 'ok installed')" -eq 0 ]; then | 	if [ "$(dpkg-query -W -f='${Status}' $installpkg 2>/dev/null | grep -c 'ok installed')" -eq 0 ]; then | ||||||
| 		apt --assume-yes --no-upgrade install "$installpkg" | 		apt --assume-yes --no-upgrade install "$installpkg" | ||||||
|  | |||||||
| @ -6,12 +6,14 @@ KCCONF_SERVERPORT=${KCCONF_SERVERPORT:-236} | |||||||
| ADDITIONAL_KOPANO_PACKAGES=${ADDITIONAL_KOPANO_PACKAGES:-""} | ADDITIONAL_KOPANO_PACKAGES=${ADDITIONAL_KOPANO_PACKAGES:-""} | ||||||
| 
 | 
 | ||||||
| set -eu # unset variables are errors & non-zero return values exit the whole script | set -eu # unset variables are errors & non-zero return values exit the whole script | ||||||
|  | [ "$DEBUG" ] && set -x | ||||||
| 
 | 
 | ||||||
|  | ADDITIONAL_KOPANO_PACKAGES=$(echo "$ADDITIONAL_KOPANO_PACKAGES" | tr -d '"') | ||||||
| [ -n "${ADDITIONAL_KOPANO_PACKAGES// }" ] && apt update | [ -n "${ADDITIONAL_KOPANO_PACKAGES// }" ] && apt update | ||||||
| [ -n "${ADDITIONAL_KOPANO_PACKAGES// }" ] && for installpkg in $ADDITIONAL_KOPANO_PACKAGES; do | [ -n "${ADDITIONAL_KOPANO_PACKAGES// }" ] && for installpkg in $ADDITIONAL_KOPANO_PACKAGES; do | ||||||
| 	# shellcheck disable=SC2016 disable=SC2086 | 	# shellcheck disable=SC2016 disable=SC2086 | ||||||
| 	if [ "$(dpkg-query -W -f='${Status}' $installpkg 2>/dev/null | grep -c 'ok installed')" -eq 0 ]; then | 	if [ "$(dpkg-query -W -f='${Status}' $installpkg 2>/dev/null | grep -c 'ok installed')" -eq 0 ]; then | ||||||
| 		apt --assume-yes install "$installpkg" | 		apt --assume-yes --no-upgrade install "$installpkg" | ||||||
| 	fi | 	fi | ||||||
| done | done | ||||||
| 
 | 
 | ||||||
|  | |||||||
| @ -7,14 +7,16 @@ ADDITIONAL_KOPANO_PACKAGES=${ADDITIONAL_KOPANO_PACKAGES:-""} | |||||||
| ADDITIONAL_KOPANO_WEBAPP_PLUGINS=${ADDITIONAL_KOPANO_WEBAPP_PLUGINS:-""} | ADDITIONAL_KOPANO_WEBAPP_PLUGINS=${ADDITIONAL_KOPANO_WEBAPP_PLUGINS:-""} | ||||||
| 
 | 
 | ||||||
| set -eu # unset variables are errors & non-zero return values exit the whole script | set -eu # unset variables are errors & non-zero return values exit the whole script | ||||||
|  | [ "$DEBUG" ] && set -x | ||||||
| 
 | 
 | ||||||
| # shellcheck source=php/start-helper.sh | # shellcheck source=php/start-helper.sh | ||||||
| source /kopano/start-helper.sh | source /kopano/start-helper.sh | ||||||
| 
 | 
 | ||||||
| ADDITIONAL_KOPANO_PACKAGES="$ADDITIONAL_KOPANO_PACKAGES $ADDITIONAL_KOPANO_WEBAPP_PLUGINS" | ADDITIONAL_KOPANO_PACKAGES="$ADDITIONAL_KOPANO_PACKAGES $ADDITIONAL_KOPANO_WEBAPP_PLUGINS" | ||||||
| 
 | 
 | ||||||
|  | ADDITIONAL_KOPANO_PACKAGES=$(echo "$ADDITIONAL_KOPANO_PACKAGES" | tr -d '"') | ||||||
| [ -n "${ADDITIONAL_KOPANO_PACKAGES// }" ] && apt update | [ -n "${ADDITIONAL_KOPANO_PACKAGES// }" ] && apt update | ||||||
| [ -n "${ADDITIONAL_KOPANO_PACKAGES// }" ] && for installpkg in $(echo "$ADDITIONAL_KOPANO_PACKAGES" | tr -d '"'); do | [ -n "${ADDITIONAL_KOPANO_PACKAGES// }" ] && for installpkg in $ADDITIONAL_KOPANO_PACKAGES; do | ||||||
| 	# shellcheck disable=SC2016 disable=SC2086 | 	# shellcheck disable=SC2016 disable=SC2086 | ||||||
| 	if [ "$(dpkg-query -W -f='${Status}' $installpkg 2>/dev/null | grep -c 'ok installed')" -eq 0 ]; then | 	if [ "$(dpkg-query -W -f='${Status}' $installpkg 2>/dev/null | grep -c 'ok installed')" -eq 0 ]; then | ||||||
| 		apt --assume-yes --no-upgrade install "$installpkg" | 		apt --assume-yes --no-upgrade install "$installpkg" | ||||||
|  | |||||||
| @ -6,6 +6,7 @@ KCCONF_SERVERPORT=${KCCONF_SERVERPORT:-236} | |||||||
| ADDITIONAL_KOPANO_PACKAGES=${ADDITIONAL_KOPANO_PACKAGES:-""} | ADDITIONAL_KOPANO_PACKAGES=${ADDITIONAL_KOPANO_PACKAGES:-""} | ||||||
| 
 | 
 | ||||||
| set -eu # unset variables are errors & non-zero return values exit the whole script | set -eu # unset variables are errors & non-zero return values exit the whole script | ||||||
|  | [ "$DEBUG" ] && set -x | ||||||
| 
 | 
 | ||||||
| php_cfg_gen() { | php_cfg_gen() { | ||||||
| 	local cfg_file="$1" | 	local cfg_file="$1" | ||||||
| @ -37,8 +38,9 @@ php_cfg_gen() { | |||||||
| 	fi | 	fi | ||||||
| } | } | ||||||
| 
 | 
 | ||||||
|  | ADDITIONAL_KOPANO_PACKAGES=$(echo "$ADDITIONAL_KOPANO_PACKAGES" | tr -d '"') | ||||||
| [ -n "${ADDITIONAL_KOPANO_PACKAGES// }" ] && apt update | [ -n "${ADDITIONAL_KOPANO_PACKAGES// }" ] && apt update | ||||||
| [ -n "${ADDITIONAL_KOPANO_PACKAGES// }" ] && for installpkg in $(echo "$ADDITIONAL_KOPANO_PACKAGES" | tr -d '"'); do | [ -n "${ADDITIONAL_KOPANO_PACKAGES// }" ] && for installpkg in $ADDITIONAL_KOPANO_PACKAGES; do | ||||||
| 	# shellcheck disable=SC2016 disable=SC2086 | 	# shellcheck disable=SC2016 disable=SC2086 | ||||||
| 	if [ "$(dpkg-query -W -f='${Status}' $installpkg 2>/dev/null | grep -c 'ok installed')" -eq 0 ]; then | 	if [ "$(dpkg-query -W -f='${Status}' $installpkg 2>/dev/null | grep -c 'ok installed')" -eq 0 ]; then | ||||||
| 		apt --assume-yes --no-upgrade install "$installpkg" | 		apt --assume-yes --no-upgrade install "$installpkg" | ||||||
|  | |||||||
		Loading…
	
	
			
			x
			
			
		
	
		Reference in New Issue
	
	Block a user