Incorporating review comments.

1. Removing label to pull always
2. Making all hub, firefox and chrome version to be consistent
3. Make hub deploy to be mandatory
This commit is contained in:
ageekymonk 2018-02-06 11:50:47 +11:00
parent 0986097353
commit 83005a8fde
No known key found for this signature in database
GPG Key ID: B94B060D25FFA652
2 changed files with 7 additions and 75 deletions

View File

@ -1,28 +1,20 @@
version: '2' version: '2'
services: services:
{{- if eq .Values.DEPLOY_SELENIUM_HUB "true"}}
seleniumhub: seleniumhub:
image: selenium/hub:${SELENIUM_HUB_VERSION} image: selenium/hub:${SELENIUM_VERSION}
environment: environment:
GRID_TIMEOUT: ${GRID_TIMEOUT} GRID_TIMEOUT: ${GRID_TIMEOUT}
ports: ports:
- ${PUBLISH_PORT}:4444 - ${PUBLISH_PORT}:4444
labels:
io.rancher.container.pull_image: always
{{- end}}
{{- if eq .Values.DEPLOY_SELENIUM_CHROME "true"}} {{- if eq .Values.DEPLOY_SELENIUM_CHROME "true"}}
selenium-chrome: selenium-chrome:
image: selenium/node-chrome:${SELENIUM_CHROME_VERSION} image: selenium/node-chrome:${SELENIUM_VERSION}
links: links:
- seleniumhub:hub - seleniumhub:hub
labels:
io.rancher.container.pull_image: always
{{- end}} {{- end}}
{{- if eq .Values.DEPLOY_SELENIUM_FIREFOX "true"}} {{- if eq .Values.DEPLOY_SELENIUM_FIREFOX "true"}}
selenium-firefox: selenium-firefox:
image: selenium/node-firefox:${SELENIUM_FIREFOX_VERSION} image: selenium/node-firefox:${SELENIUM_VERSION}
links: links:
- seleniumhub:hub - seleniumhub:hub
labels:
io.rancher.container.pull_image: always
{{- end}} {{- end}}

View File

@ -4,20 +4,12 @@ catalog:
version: v0.0.1 version: v0.0.1
minimum_rancher_version: v1.5.0 minimum_rancher_version: v1.5.0
questions: questions:
- variable: DEPLOY_SELENIUM_HUB - variable: SELENIUM_VERSION
description: Deploy Selenium Hub label: Selenium Version for Hub and Nodes
label: Deploy Selenium Hub description: Selenium Hub and Node Version
required: true
type: enum
default: true
options:
- true
- false
- variable: SELENIUM_HUB_VERSION
label: Selenium Hub Version
description: Selenium Hub Version
required: true required: true
type: enum type: enum
default: 3.8.1-bohrium
options: options:
- 3.8.1-bohrium - 3.8.1-bohrium
- 3.8.1-aluminum - 3.8.1-aluminum
@ -58,32 +50,6 @@ catalog:
options: options:
- true - true
- false - false
- variable: SELENIUM_CHROME_VERSION
label: Selenium Chrome Version
description: Selenium Chrome Version
required: true
type: enum
options:
- 3.8.1-bohrium
- 3.8.1-aluminum
- 3.7.1-cadmium
- 3.7.1-beryllium
- 3.7.1-argon
- 3.7.0-arsenic
- 3.6.0-darmstadtium
- 3.6.0-copper
- 3.6.0-bromine
- 3.6.0-americium
- 3.5.3-boron
- 3.5.3-astatine
- 3.5.2-antimony
- 3.5.1-aluminum
- 3.5.0-argon
- 3.4.0-francium
- 3.4.0-einsteinium
- 3.4.0-dysprosium
- 3.4.0-chromium
- 3.4.0-bismuth
- variable: SELENIUM_CHROME_SCALE - variable: SELENIUM_CHROME_SCALE
label: Number of chrome container label: Number of chrome container
description: Number of chrome container description: Number of chrome container
@ -98,32 +64,6 @@ catalog:
options: options:
- true - true
- false - false
- variable: SELENIUM_FIREFOX_VERSION
label: Selenium Firefox Version
description: Selenium Firefox Version
required: true
type: enum
options:
- 3.8.1-bohrium
- 3.8.1-aluminum
- 3.7.1-cadmium
- 3.7.1-beryllium
- 3.7.1-argon
- 3.7.0-arsenic
- 3.6.0-darmstadtium
- 3.6.0-copper
- 3.6.0-bromine
- 3.6.0-americium
- 3.5.3-boron
- 3.5.3-astatine
- 3.5.2-antimony
- 3.5.1-aluminum
- 3.5.0-argon
- 3.4.0-francium
- 3.4.0-einsteinium
- 3.4.0-dysprosium
- 3.4.0-chromium
- 3.4.0-bismuth
- variable: SELENIUM_FIREFOX_SCALE - variable: SELENIUM_FIREFOX_SCALE
label: Number of firefox container label: Number of firefox container
description: Number of firefox container description: Number of firefox container