flywithu/android-library
1
0
Fork 0
mirror of https://github.com/owncloud/android-library.git synced 2025-06-08 00:16:09 +00:00
Code Issues Releases Wiki Activity

Prevent NPE parsing NULL queries in OAuth2 redirected URIs

Browse Source
This commit is contained in:
David A. Velasco 2017-08-29 10:53:28 +02:00 committed by davigonz
parent 2d35b00273
commit f3a2c05efa
1 changed files with 20 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

38
src/com/owncloud/android/lib/common/authentication/oauth/OAuth2QueryParser.java
View File

@ -45,26 +45,28 @@ public class OAuth2QueryParser {
public Map<String, String> parse(String query) {
mOAuth2ParsedAuthorizationResponse.clear();
String[] pairs = query.split("&");
int i = 0;
String key = "";
String value;
while (pairs.length > i) {
int j = 0;
String[] part = pairs[i].split("=");
while (part.length > j) {
String p = part[j];
if (j == 0) {
key = p;
} else if (j == 1) {
value = p;
mOAuth2ParsedAuthorizationResponse.put(key, value);
}
if (query != null) {
String[] pairs = query.split("&");
int i = 0;
String key = "";
String value;
while (pairs.length > i) {
int j = 0;
String[] part = pairs[i].split("=");
while (part.length > j) {
String p = part[j];
if (j == 0) {
key = p;
} else if (j == 1) {
value = p;
mOAuth2ParsedAuthorizationResponse.put(key, value);
}
Log_OC.v(TAG, "[" + i + "," + j + "] = " + p);
j++;
Log_OC.v(TAG, "[" + i + "," + j + "] = " + p);
j++;
}
i++;
}
i++;
}
return mOAuth2ParsedAuthorizationResponse;