From 69c7a24ebb5b107ef7730de3907a6f176cd79992 Mon Sep 17 00:00:00 2001 From: sd1998 Date: Fri, 26 Oct 2018 14:35:00 +0530 Subject: [PATCH 1/2] Changes for handling HTTP_METHOD_NOT_FOUND responses --- .../android/lib/common/operations/RemoteOperationResult.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/com/owncloud/android/lib/common/operations/RemoteOperationResult.java b/src/com/owncloud/android/lib/common/operations/RemoteOperationResult.java index dbb5eb74..2a946161 100644 --- a/src/com/owncloud/android/lib/common/operations/RemoteOperationResult.java +++ b/src/com/owncloud/android/lib/common/operations/RemoteOperationResult.java @@ -274,6 +274,11 @@ public class RemoteOperationResult ResultCode.SPECIFIC_SERVICE_UNAVAILABLE ); break; + case HttpConstants.HTTP_METHOD_NOT_ALLOWED: + parseErrorMessageAndSetCode( + httpMethod.getResponseBodyAsString(), + ResultCode.SPECIFIC_SERVICE_UNAVAILABLE + ); default: break; } From 106b4fd9e55d208c2089bea89db81daf326fc69f Mon Sep 17 00:00:00 2001 From: sd1998 Date: Fri, 26 Oct 2018 18:05:29 +0530 Subject: [PATCH 2/2] Code review changes --- .../android/lib/common/operations/RemoteOperationResult.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/com/owncloud/android/lib/common/operations/RemoteOperationResult.java b/src/com/owncloud/android/lib/common/operations/RemoteOperationResult.java index 2a946161..5d73f181 100644 --- a/src/com/owncloud/android/lib/common/operations/RemoteOperationResult.java +++ b/src/com/owncloud/android/lib/common/operations/RemoteOperationResult.java @@ -115,7 +115,8 @@ public class RemoteOperationResult LOCAL_FILE_NOT_FOUND, SERVICE_UNAVAILABLE, SPECIFIC_SERVICE_UNAVAILABLE, - SPECIFIC_UNSUPPORTED_MEDIA_TYPE + SPECIFIC_UNSUPPORTED_MEDIA_TYPE, + SPECIFIC_METHOD_NOT_ALLOWED } private boolean mSuccess = false; @@ -277,7 +278,7 @@ public class RemoteOperationResult case HttpConstants.HTTP_METHOD_NOT_ALLOWED: parseErrorMessageAndSetCode( httpMethod.getResponseBodyAsString(), - ResultCode.SPECIFIC_SERVICE_UNAVAILABLE + ResultCode.SPECIFIC_METHOD_NOT_ALLOWED ); default: break;