From bbac8d027840a29014fbac8020b5c58859c3e994 Mon Sep 17 00:00:00 2001 From: agarcia Date: Mon, 25 May 2020 13:50:29 +0200 Subject: [PATCH] Polish remote operation --- .../users/GetRemoteUserQuotaOperation.kt | 21 ++++++------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/users/GetRemoteUserQuotaOperation.kt b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/users/GetRemoteUserQuotaOperation.kt index 0848620a..11c60a03 100644 --- a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/users/GetRemoteUserQuotaOperation.kt +++ b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/users/GetRemoteUserQuotaOperation.kt @@ -58,27 +58,18 @@ class GetRemoteUserQuotaOperation : RemoteOperation() { val status = client.executeHttpMethod(propfindMethod) if (isSuccess(status)) { val remoteQuota = readData(propfindMethod.root.properties) - result = RemoteOperationResult(ResultCode.OK) - - // Add data to the result - if (result.isSuccess) { - result.data = remoteQuota + result = RemoteOperationResult(ResultCode.OK).apply { + data = remoteQuota } + Timber.i("Get quota completed: ${result.data} and message: ${result.logMessage}") + } else { // synchronization failed result = RemoteOperationResult(propfindMethod) + Timber.e("Get quota without success: ${result.logMessage}") } } catch (e: Exception) { result = RemoteOperationResult(e) - } finally { - if (result.isSuccess) { - Timber.i("Get quota completed: ${result.data} and message: ${result.logMessage}") - } else { - if (result.isException) { - Timber.e(result.exception, "Get quota: ${result.logMessage}") - } else { - Timber.e("Get quota without success: ${result.logMessage}") - } - } + Timber.e(result.exception, "Get quota: ${result.logMessage}") } return result }