diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 30dda12f..708f7893 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -1,6 +1,6 @@ " + client.getBaseUri() + ShareUtils.SHAREAPI_ROUTE); + post = new PostMethod(client.getBaseUri() + ShareUtils.SHARING_API_PATH); + Log.d(TAG, "URL ------> " + client.getBaseUri() + ShareUtils.SHARING_API_PATH); post.setRequestHeader( "Content-Type", "application/x-www-form-urlencoded; charset=utf-8"); // necessary for special characters - post.addParameter(PARAM_PATH, mPath); + post.addParameter(PARAM_PATH, mRemoteFilePath); post.addParameter(PARAM_SHARE_TYPE, Integer.toString(mShareType.getValue())); post.addParameter(PARAM_SHARE_WITH, mShareWith); post.addParameter(PARAM_PUBLIC_UPLOAD, Boolean.toString(mPublicUpload)); diff --git a/src/com/owncloud/android/lib/operations/remote/GetSharesForFileRemoteOperation.java b/src/com/owncloud/android/lib/resources/shares/GetRemoteSharesForFileOperation.java similarity index 74% rename from src/com/owncloud/android/lib/operations/remote/GetSharesForFileRemoteOperation.java rename to src/com/owncloud/android/lib/resources/shares/GetRemoteSharesForFileOperation.java index ad1e6e61..a17e8a5b 100644 --- a/src/com/owncloud/android/lib/operations/remote/GetSharesForFileRemoteOperation.java +++ b/src/com/owncloud/android/lib/resources/shares/GetRemoteSharesForFileOperation.java @@ -1,5 +1,5 @@ /* ownCloud Android Library is available under MIT license - * Copyright (C) 2014 ownCloud (http://www.owncloud.org/) + * Copyright (C) 2014 ownCloud Inc. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal @@ -22,7 +22,7 @@ * */ -package com.owncloud.android.lib.operations.remote; +package com.owncloud.android.lib.resources.shares; import java.io.ByteArrayInputStream; import java.io.InputStream; @@ -34,13 +34,10 @@ import org.apache.http.HttpStatus; import android.util.Log; -import com.owncloud.android.lib.network.OwnCloudClient; -import com.owncloud.android.lib.operations.common.OCShare; -import com.owncloud.android.lib.operations.common.RemoteOperation; -import com.owncloud.android.lib.operations.common.RemoteOperationResult; -import com.owncloud.android.lib.operations.common.RemoteOperationResult.ResultCode; -import com.owncloud.android.lib.utils.ShareUtils; -import com.owncloud.android.lib.utils.ShareXMLParser; +import com.owncloud.android.lib.common.OwnCloudClient; +import com.owncloud.android.lib.common.operations.RemoteOperation; +import com.owncloud.android.lib.common.operations.RemoteOperationResult; +import com.owncloud.android.lib.common.operations.RemoteOperationResult.ResultCode; /** * Provide a list shares for a specific file. @@ -51,9 +48,9 @@ import com.owncloud.android.lib.utils.ShareXMLParser; * */ -public class GetSharesForFileRemoteOperation extends RemoteOperation { +public class GetRemoteSharesForFileOperation extends RemoteOperation { - private static final String TAG = GetSharesForFileRemoteOperation.class.getSimpleName(); + private static final String TAG = GetRemoteSharesForFileOperation.class.getSimpleName(); private static final String PARAM_PATH = "path"; private static final String PARAM_RESHARES = "reshares"; @@ -61,21 +58,21 @@ public class GetSharesForFileRemoteOperation extends RemoteOperation { private ArrayList mShares; // List of shares for result, one share in this case - private String mPath; + private String mRemoteFilePath; private boolean mReshares; private boolean mSubfiles; /** * Constructor * - * @param path Path to file or folder - * @param reshares If set to ‘false’ (default), only shares from the current user are returned - * If set to ‘true’, all shares from the given file are returned - * @param subfiles If set to ‘false’ (default), lists only the folder being shared - * If set to ‘true’, all shared files within the folder are returned. + * @param remoteFilePath Path to file or folder + * @param reshares If set to ‘false’ (default), only shares from the current user are returned + * If set to ‘true’, all shares from the given file are returned + * @param subfiles If set to ‘false’ (default), lists only the folder being shared + * If set to ‘true’, all shared files within the folder are returned. */ - public GetSharesForFileRemoteOperation(String path, boolean reshares, boolean subfiles) { - mPath = path; + public GetRemoteSharesForFileOperation(String remoteFilePath, boolean reshares, boolean subfiles) { + mRemoteFilePath = remoteFilePath; mReshares = reshares; mSubfiles = subfiles; } @@ -89,12 +86,12 @@ public class GetSharesForFileRemoteOperation extends RemoteOperation { try { // Get Method - get = new GetMethod(client.getBaseUri() + ShareUtils.SHAREAPI_ROUTE); - Log.d(TAG, "URL ------> " + client.getBaseUri() + ShareUtils.SHAREAPI_ROUTE); + get = new GetMethod(client.getBaseUri() + ShareUtils.SHARING_API_PATH); + Log.d(TAG, "URL ------> " + client.getBaseUri() + ShareUtils.SHARING_API_PATH); // Add Parameters to Get Method get.setQueryString(new NameValuePair[] { - new NameValuePair(PARAM_PATH, mPath), + new NameValuePair(PARAM_PATH, mRemoteFilePath), new NameValuePair(PARAM_RESHARES, String.valueOf(mReshares)), new NameValuePair(PARAM_SUBFILES, String.valueOf(mSubfiles)) }); diff --git a/src/com/owncloud/android/lib/operations/remote/GetRemoteSharesOperation.java b/src/com/owncloud/android/lib/resources/shares/GetRemoteSharesOperation.java similarity index 84% rename from src/com/owncloud/android/lib/operations/remote/GetRemoteSharesOperation.java rename to src/com/owncloud/android/lib/resources/shares/GetRemoteSharesOperation.java index 0f9c4f65..24ca2f5c 100644 --- a/src/com/owncloud/android/lib/operations/remote/GetRemoteSharesOperation.java +++ b/src/com/owncloud/android/lib/resources/shares/GetRemoteSharesOperation.java @@ -1,5 +1,5 @@ /* ownCloud Android Library is available under MIT license - * Copyright (C) 2014 ownCloud (http://www.owncloud.org/) + * Copyright (C) 2014 ownCloud Inc. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal @@ -22,7 +22,7 @@ * */ -package com.owncloud.android.lib.operations.remote; +package com.owncloud.android.lib.resources.shares; import java.io.ByteArrayInputStream; import java.io.InputStream; @@ -31,13 +31,10 @@ import java.util.ArrayList; import org.apache.commons.httpclient.methods.GetMethod; import org.apache.http.HttpStatus; -import com.owncloud.android.lib.network.OwnCloudClient; -import com.owncloud.android.lib.operations.common.RemoteOperation; -import com.owncloud.android.lib.operations.common.RemoteOperationResult; -import com.owncloud.android.lib.operations.common.RemoteOperationResult.ResultCode; -import com.owncloud.android.lib.operations.common.OCShare; -import com.owncloud.android.lib.utils.ShareUtils; -import com.owncloud.android.lib.utils.ShareXMLParser; +import com.owncloud.android.lib.common.OwnCloudClient; +import com.owncloud.android.lib.common.operations.RemoteOperation; +import com.owncloud.android.lib.common.operations.RemoteOperationResult; +import com.owncloud.android.lib.common.operations.RemoteOperationResult.ResultCode; import android.util.Log; @@ -69,8 +66,8 @@ public class GetRemoteSharesOperation extends RemoteOperation { // Get the response try{ - get = new GetMethod(client.getBaseUri() + ShareUtils.SHAREAPI_ROUTE); - Log.d(TAG, "URL ------> " + client.getBaseUri() + ShareUtils.SHAREAPI_ROUTE); + get = new GetMethod(client.getBaseUri() + ShareUtils.SHARING_API_PATH); + Log.d(TAG, "URL ------> " + client.getBaseUri() + ShareUtils.SHARING_API_PATH); status = client.executeMethod(get); if(isSuccess(status)) { Log.d(TAG, "Obtain RESPONSE"); diff --git a/src/com/owncloud/android/lib/operations/common/OCShare.java b/src/com/owncloud/android/lib/resources/shares/OCShare.java similarity index 97% rename from src/com/owncloud/android/lib/operations/common/OCShare.java rename to src/com/owncloud/android/lib/resources/shares/OCShare.java index 9149ab73..1bf6cc1a 100644 --- a/src/com/owncloud/android/lib/operations/common/OCShare.java +++ b/src/com/owncloud/android/lib/resources/shares/OCShare.java @@ -1,5 +1,5 @@ /* ownCloud Android Library is available under MIT license - * Copyright (C) 2014 ownCloud (http://www.owncloud.org/) + * Copyright (C) 2014 ownCloud Inc. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal @@ -22,11 +22,11 @@ * */ -package com.owncloud.android.lib.operations.common; +package com.owncloud.android.lib.resources.shares; import java.io.Serializable; -import com.owncloud.android.lib.utils.FileUtils; +import com.owncloud.android.lib.resources.files.FileUtils; import android.os.Parcel; import android.os.Parcelable; diff --git a/src/com/owncloud/android/lib/operations/remote/RemoveRemoteShareOperation.java b/src/com/owncloud/android/lib/resources/shares/RemoveRemoteShareOperation.java similarity index 82% rename from src/com/owncloud/android/lib/operations/remote/RemoveRemoteShareOperation.java rename to src/com/owncloud/android/lib/resources/shares/RemoveRemoteShareOperation.java index 8f467ff4..83e94372 100644 --- a/src/com/owncloud/android/lib/operations/remote/RemoveRemoteShareOperation.java +++ b/src/com/owncloud/android/lib/resources/shares/RemoveRemoteShareOperation.java @@ -1,5 +1,5 @@ /* ownCloud Android Library is available under MIT license - * Copyright (C) 2014 ownCloud (http://www.owncloud.org/) + * Copyright (C) 2014 ownCloud Inc. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal @@ -22,7 +22,7 @@ * */ -package com.owncloud.android.lib.operations.remote; +package com.owncloud.android.lib.resources.shares; import java.io.ByteArrayInputStream; import java.io.InputStream; @@ -32,12 +32,10 @@ import org.apache.jackrabbit.webdav.client.methods.DeleteMethod; import android.util.Log; -import com.owncloud.android.lib.network.OwnCloudClient; -import com.owncloud.android.lib.operations.common.RemoteOperation; -import com.owncloud.android.lib.operations.common.RemoteOperationResult; -import com.owncloud.android.lib.operations.common.RemoteOperationResult.ResultCode; -import com.owncloud.android.lib.utils.ShareUtils; -import com.owncloud.android.lib.utils.ShareXMLParser; +import com.owncloud.android.lib.common.OwnCloudClient; +import com.owncloud.android.lib.common.operations.RemoteOperation; +import com.owncloud.android.lib.common.operations.RemoteOperationResult; +import com.owncloud.android.lib.common.operations.RemoteOperationResult.ResultCode; /** * Remove a share @@ -50,16 +48,16 @@ public class RemoveRemoteShareOperation extends RemoteOperation { private static final String TAG = RemoveRemoteShareOperation.class.getSimpleName(); - private int mIdShare; + private int mRemoteShareId; /** * Constructor * - * @param idShare Share ID + * @param remoteShareId Share ID */ - public RemoveRemoteShareOperation(int idShare) { - mIdShare = idShare; + public RemoveRemoteShareOperation(int remoteShareId) { + mRemoteShareId = remoteShareId; } @@ -71,9 +69,9 @@ public class RemoveRemoteShareOperation extends RemoteOperation { DeleteMethod delete = null; try { - String id = "/" + String.valueOf(mIdShare); - delete = new DeleteMethod(client.getBaseUri() + ShareUtils.SHAREAPI_ROUTE + id); - Log.d(TAG, "URL ------> " + client.getBaseUri() + ShareUtils.SHAREAPI_ROUTE + id); + String id = "/" + String.valueOf(mRemoteShareId); + delete = new DeleteMethod(client.getBaseUri() + ShareUtils.SHARING_API_PATH + id); + Log.d(TAG, "URL ------> " + client.getBaseUri() + ShareUtils.SHARING_API_PATH + id); status = client.executeMethod(delete); diff --git a/src/com/owncloud/android/lib/operations/common/ShareType.java b/src/com/owncloud/android/lib/resources/shares/ShareType.java similarity index 94% rename from src/com/owncloud/android/lib/operations/common/ShareType.java rename to src/com/owncloud/android/lib/resources/shares/ShareType.java index 920dc3a3..0078578d 100644 --- a/src/com/owncloud/android/lib/operations/common/ShareType.java +++ b/src/com/owncloud/android/lib/resources/shares/ShareType.java @@ -1,5 +1,5 @@ /* ownCloud Android Library is available under MIT license - * Copyright (C) 2014 ownCloud (http://www.owncloud.org/) + * Copyright (C) 2014 ownCloud Inc. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal @@ -22,7 +22,7 @@ * */ -package com.owncloud.android.lib.operations.common; +package com.owncloud.android.lib.resources.shares; /** * Enum for Share Type, with values: diff --git a/src/com/owncloud/android/lib/utils/ShareUtils.java b/src/com/owncloud/android/lib/resources/shares/ShareUtils.java similarity index 87% rename from src/com/owncloud/android/lib/utils/ShareUtils.java rename to src/com/owncloud/android/lib/resources/shares/ShareUtils.java index e134ffac..9e2e6b99 100644 --- a/src/com/owncloud/android/lib/utils/ShareUtils.java +++ b/src/com/owncloud/android/lib/resources/shares/ShareUtils.java @@ -1,5 +1,5 @@ /* ownCloud Android Library is available under MIT license - * Copyright (C) 2014 ownCloud (http://www.owncloud.org/) + * Copyright (C) 2014 ownCloud Inc. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal @@ -22,7 +22,7 @@ * */ -package com.owncloud.android.lib.utils; +package com.owncloud.android.lib.resources.shares; /** * Contains Constants for Share Operation @@ -34,6 +34,6 @@ package com.owncloud.android.lib.utils; public class ShareUtils { // OCS Route - public static final String SHAREAPI_ROUTE ="/ocs/v1.php/apps/files_sharing/api/v1/shares"; + public static final String SHARING_API_PATH ="/ocs/v1.php/apps/files_sharing/api/v1/shares"; } diff --git a/src/com/owncloud/android/lib/utils/ShareXMLParser.java b/src/com/owncloud/android/lib/resources/shares/ShareXMLParser.java similarity index 98% rename from src/com/owncloud/android/lib/utils/ShareXMLParser.java rename to src/com/owncloud/android/lib/resources/shares/ShareXMLParser.java index 4d456a7f..c8e3dbdb 100644 --- a/src/com/owncloud/android/lib/utils/ShareXMLParser.java +++ b/src/com/owncloud/android/lib/resources/shares/ShareXMLParser.java @@ -1,5 +1,5 @@ /* ownCloud Android Library is available under MIT license - * Copyright (C) 2014 ownCloud (http://www.owncloud.org/) + * Copyright (C) 2014 ownCloud Inc. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal @@ -22,7 +22,7 @@ * */ -package com.owncloud.android.lib.utils; +package com.owncloud.android.lib.resources.shares; import java.io.IOException; import java.io.InputStream; @@ -35,8 +35,7 @@ import org.xmlpull.v1.XmlPullParserFactory; import android.util.Log; import android.util.Xml; -import com.owncloud.android.lib.operations.common.OCShare; -import com.owncloud.android.lib.operations.common.ShareType; +import com.owncloud.android.lib.resources.files.FileUtils; /** * Parser for Share API Response diff --git a/src/com/owncloud/android/lib/operations/remote/OwnCloudServerCheckOperation.java b/src/com/owncloud/android/lib/resources/status/GetRemoteStatusOperation.java similarity index 91% rename from src/com/owncloud/android/lib/operations/remote/OwnCloudServerCheckOperation.java rename to src/com/owncloud/android/lib/resources/status/GetRemoteStatusOperation.java index 15e54a3e..b04d50fd 100644 --- a/src/com/owncloud/android/lib/operations/remote/OwnCloudServerCheckOperation.java +++ b/src/com/owncloud/android/lib/resources/status/GetRemoteStatusOperation.java @@ -1,5 +1,5 @@ /* ownCloud Android Library is available under MIT license - * Copyright (C) 2014 ownCloud (http://www.owncloud.org/) + * Copyright (C) 2014 ownCloud Inc. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal @@ -22,18 +22,17 @@ * */ -package com.owncloud.android.lib.operations.remote; +package com.owncloud.android.lib.resources.status; import org.apache.commons.httpclient.HttpStatus; import org.apache.commons.httpclient.methods.GetMethod; import org.json.JSONException; import org.json.JSONObject; -import com.owncloud.android.lib.accounts.AccountUtils; -import com.owncloud.android.lib.network.OwnCloudClient; -import com.owncloud.android.lib.operations.common.RemoteOperation; -import com.owncloud.android.lib.operations.common.RemoteOperationResult; -import com.owncloud.android.lib.utils.OwnCloudVersion; +import com.owncloud.android.lib.common.OwnCloudClient; +import com.owncloud.android.lib.common.accounts.AccountUtils; +import com.owncloud.android.lib.common.operations.RemoteOperation; +import com.owncloud.android.lib.common.operations.RemoteOperationResult; import android.content.Context; import android.net.ConnectivityManager; @@ -48,12 +47,12 @@ import android.util.Log; * */ -public class OwnCloudServerCheckOperation extends RemoteOperation { +public class GetRemoteStatusOperation extends RemoteOperation { /** Maximum time to wait for a response from the server when the connection is being tested, in MILLISECONDs. */ public static final int TRY_CONNECTION_TIMEOUT = 5000; - private static final String TAG = OwnCloudServerCheckOperation.class.getSimpleName(); + private static final String TAG = GetRemoteStatusOperation.class.getSimpleName(); private static final String OCVERSION_SHARED_SUPPORTED = "5.0.13"; @@ -67,7 +66,7 @@ public class OwnCloudServerCheckOperation extends RemoteOperation { private OwnCloudVersion mOCVersion; private OwnCloudVersion mOCVersionString; - public OwnCloudServerCheckOperation(String url, Context context) { + public GetRemoteStatusOperation(String url, Context context) { mUrl = url; mContext = context; mOCVersion = null; diff --git a/src/com/owncloud/android/lib/utils/OwnCloudVersion.java b/src/com/owncloud/android/lib/resources/status/OwnCloudVersion.java similarity index 97% rename from src/com/owncloud/android/lib/utils/OwnCloudVersion.java rename to src/com/owncloud/android/lib/resources/status/OwnCloudVersion.java index dd01186d..daf03e23 100644 --- a/src/com/owncloud/android/lib/utils/OwnCloudVersion.java +++ b/src/com/owncloud/android/lib/resources/status/OwnCloudVersion.java @@ -1,5 +1,5 @@ /* ownCloud Android Library is available under MIT license - * Copyright (C) 2014 ownCloud (http://www.owncloud.org/) + * Copyright (C) 2014 ownCloud Inc. * Copyright (C) 2012 Bartek Przybylski * * Permission is hereby granted, free of charge, to any person obtaining a copy @@ -23,7 +23,7 @@ * */ -package com.owncloud.android.lib.utils; +package com.owncloud.android.lib.resources.status; public class OwnCloudVersion implements Comparable { public static final OwnCloudVersion owncloud_v1 = new OwnCloudVersion( diff --git a/src/com/owncloud/android/lib/operations/remote/GetUserNameRemoteOperation.java b/src/com/owncloud/android/lib/resources/users/GetRemoteUserNameOperation.java similarity index 90% rename from src/com/owncloud/android/lib/operations/remote/GetUserNameRemoteOperation.java rename to src/com/owncloud/android/lib/resources/users/GetRemoteUserNameOperation.java index 2e8e2338..90324b74 100644 --- a/src/com/owncloud/android/lib/operations/remote/GetUserNameRemoteOperation.java +++ b/src/com/owncloud/android/lib/resources/users/GetRemoteUserNameOperation.java @@ -1,5 +1,5 @@ /* ownCloud Android Library is available under MIT license - * Copyright (C) 2014 ownCloud (http://www.owncloud.org/) + * Copyright (C) 2014 ownCloud Inc. * * Permission is hereby granted, free of charge, to any person obtaining a copy * of this software and associated documentation files (the "Software"), to deal @@ -22,7 +22,7 @@ * */ -package com.owncloud.android.lib.operations.remote; +package com.owncloud.android.lib.resources.users; import org.apache.commons.httpclient.methods.GetMethod; import org.apache.http.HttpStatus; @@ -30,9 +30,9 @@ import org.json.JSONObject; import android.util.Log; -import com.owncloud.android.lib.network.OwnCloudClient; -import com.owncloud.android.lib.operations.common.RemoteOperation; -import com.owncloud.android.lib.operations.common.RemoteOperationResult; +import com.owncloud.android.lib.common.OwnCloudClient; +import com.owncloud.android.lib.common.operations.RemoteOperation; +import com.owncloud.android.lib.common.operations.RemoteOperationResult; /** @@ -44,9 +44,9 @@ import com.owncloud.android.lib.operations.common.RemoteOperationResult; * email */ -public class GetUserNameRemoteOperation extends RemoteOperation { +public class GetRemoteUserNameOperation extends RemoteOperation { - private static final String TAG = GetUserNameRemoteOperation.class.getSimpleName(); + private static final String TAG = GetRemoteUserNameOperation.class.getSimpleName(); // HEADER private static final String HEADER_OCS_API = "OCS-APIREQUEST"; @@ -69,7 +69,7 @@ public class GetUserNameRemoteOperation extends RemoteOperation { } - public GetUserNameRemoteOperation() { + public GetRemoteUserNameOperation() { } @Override diff --git a/tests/AndroidManifest.xml b/tests/AndroidManifest.xml index 1ce1eb2f..f2c45a6c 100644 --- a/tests/AndroidManifest.xml +++ b/tests/AndroidManifest.xml @@ -1,6 +1,6 @@