From 78b9aa6247f619780b6d9d93469c33d31c713e21 Mon Sep 17 00:00:00 2001 From: "David A. Velasco" Date: Mon, 14 Mar 2016 09:25:47 +0100 Subject: [PATCH] Redirections to the Identity Provider (IdP) are translated into ResultCode.UNAUTHORIZED --- .../android/lib/common/operations/RemoteOperation.java | 3 ++- .../android/lib/common/operations/RemoteOperationResult.java | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/com/owncloud/android/lib/common/operations/RemoteOperation.java b/src/com/owncloud/android/lib/common/operations/RemoteOperation.java index cb0d6db4..242f614a 100644 --- a/src/com/owncloud/android/lib/common/operations/RemoteOperation.java +++ b/src/com/owncloud/android/lib/common/operations/RemoteOperation.java @@ -307,7 +307,8 @@ public abstract class RemoteOperation implements Runnable { * to trigger authentication update */ if (mCallerActivity != null && mAccount != null && mContext != null && !result.isSuccess() && - (result.getCode() == ResultCode.UNAUTHORIZED || result.isIdPRedirection())) { + ResultCode.UNAUTHORIZED.equals(result.getCode()) + ) { /// possible fail due to lack of authorization // in an operation performed in foreground OwnCloudCredentials cred = mClient.getCredentials(); diff --git a/src/com/owncloud/android/lib/common/operations/RemoteOperationResult.java b/src/com/owncloud/android/lib/common/operations/RemoteOperationResult.java index 85673c85..411c4f52 100644 --- a/src/com/owncloud/android/lib/common/operations/RemoteOperationResult.java +++ b/src/com/owncloud/android/lib/common/operations/RemoteOperationResult.java @@ -183,6 +183,9 @@ public class RemoteOperationResult implements Serializable { } } } + if (isIdPRedirection()) { + mCode = ResultCode.UNAUTHORIZED; // overrides default ResultCode.UNKNOWN + } } public RemoteOperationResult(boolean success, String bodyResponse, int httpCode) {