diff --git a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/GetRemoteShareOperation.java b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/GetRemoteShareOperation.java index 4b815df1..9e71252e 100644 --- a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/GetRemoteShareOperation.java +++ b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/GetRemoteShareOperation.java @@ -46,9 +46,9 @@ import java.net.URL; public class GetRemoteShareOperation extends RemoteOperation { - private long mRemoteId; + private String mRemoteId; - public GetRemoteShareOperation(long remoteId) { + public GetRemoteShareOperation(String remoteId) { mRemoteId = remoteId; } @@ -60,7 +60,7 @@ public class GetRemoteShareOperation extends RemoteOperation Uri requestUri = client.getBaseUri(); Uri.Builder uriBuilder = requestUri.buildUpon(); uriBuilder.appendEncodedPath(ShareUtils.SHARING_API_PATH); - uriBuilder.appendEncodedPath(Long.toString(mRemoteId)); + uriBuilder.appendEncodedPath(mRemoteId); GetMethod getMethod = new GetMethod(new URL(uriBuilder.build().toString())); getMethod.addRequestHeader(OCS_API_HEADER, OCS_API_HEADER_VALUE); diff --git a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/RemoteShare.kt b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/RemoteShare.kt index 21e3835b..83149d8e 100644 --- a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/RemoteShare.kt +++ b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/RemoteShare.kt @@ -34,7 +34,7 @@ import java.io.File * @author David González Verdugo */ data class RemoteShare( - var id: Long = 0, + var id: String = "0", var shareWith: String = "", var path: String = "", var token: String = "", @@ -49,8 +49,7 @@ data class RemoteShare( var sharedDate: Long = INIT_SHARED_DATE, var expirationDate: Long = INIT_EXPIRATION_DATE_IN_MILLIS, var isFolder: Boolean = path.endsWith(File.separator), - var userId: Long = 0, - val isValid: Boolean = id > -1 + var userId: Long = 0 ) { companion object { diff --git a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/RemoveRemoteShareOperation.kt b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/RemoveRemoteShareOperation.kt index 5fa18169..a7d18e5d 100644 --- a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/RemoveRemoteShareOperation.kt +++ b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/RemoveRemoteShareOperation.kt @@ -48,7 +48,7 @@ import java.net.URL * * @param remoteShareId Share ID */ -class RemoveRemoteShareOperation(private val remoteShareId: Long) : RemoteOperation() { +class RemoveRemoteShareOperation(private val remoteShareId: String) : RemoteOperation() { override fun run(client: OwnCloudClient): RemoteOperationResult { var result: RemoteOperationResult @@ -57,7 +57,7 @@ class RemoveRemoteShareOperation(private val remoteShareId: Long) : RemoteOperat val requestUri = client.baseUri val uriBuilder = requestUri.buildUpon() uriBuilder.appendEncodedPath(ShareUtils.SHARING_API_PATH) - uriBuilder.appendEncodedPath(remoteShareId.toString()) + uriBuilder.appendEncodedPath(remoteShareId) val deleteMethod = DeleteMethod( URL(uriBuilder.build().toString()) diff --git a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/ShareXMLParser.kt b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/ShareXMLParser.kt index a63c35a7..75160d8d 100644 --- a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/ShareXMLParser.kt +++ b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/ShareXMLParser.kt @@ -179,7 +179,7 @@ class ShareXMLParser { name.equals(NODE_ID, ignoreCase = true) -> {// Parse Create XML Response share = RemoteShare() val value = readNode(parser, NODE_ID) - share.id = Integer.parseInt(value).toLong() + share.id = value } name.equals(NODE_URL, ignoreCase = true) -> { // NOTE: this field is received in all the public shares from OC 9.0.0 @@ -236,7 +236,7 @@ class ShareXMLParser { } name.equals(NODE_ID, ignoreCase = true) -> { - remoteShare.id = Integer.parseInt(readNode(parser, NODE_ID)).toLong() + remoteShare.id = readNode(parser, NODE_ID) } name.equals(NODE_ITEM_TYPE, ignoreCase = true) -> { @@ -320,9 +320,7 @@ class ShareXMLParser { } } - if (remoteShare.isValid) { - shares.add(remoteShare) - } + shares.add(remoteShare) } private fun fixPathForFolder(share: RemoteShare) { diff --git a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/UpdateRemoteShareOperation.kt b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/UpdateRemoteShareOperation.kt index e2af8959..0df80bc9 100644 --- a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/UpdateRemoteShareOperation.kt +++ b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/UpdateRemoteShareOperation.kt @@ -55,7 +55,7 @@ class UpdateRemoteShareOperation /** * @param remoteId Identifier of the share to update. */ - private val remoteId: Long + private val remoteId: String ) : RemoteOperation() { /** diff --git a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/services/ShareService.kt b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/services/ShareService.kt index 38980256..caca3cd8 100644 --- a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/services/ShareService.kt +++ b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/services/ShareService.kt @@ -44,7 +44,7 @@ interface ShareService : Service { ): RemoteOperationResult fun updateShare( - remoteId: Long, + remoteId: String, name: String, password: String?, expirationDate: Long, @@ -52,5 +52,5 @@ interface ShareService : Service { publicUpload: Boolean ): RemoteOperationResult - fun deleteShare(remoteId: Long): RemoteOperationResult + fun deleteShare(remoteId: String): RemoteOperationResult } diff --git a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/services/implementation/OCShareService.kt b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/services/implementation/OCShareService.kt index a22919bf..109c2204 100644 --- a/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/services/implementation/OCShareService.kt +++ b/owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/services/implementation/OCShareService.kt @@ -66,7 +66,7 @@ class OCShareService(override val client: OwnCloudClient) : }.execute(client) override fun updateShare( - remoteId: Long, + remoteId: String, name: String, password: String?, expirationDate: Long, @@ -84,7 +84,7 @@ class OCShareService(override val client: OwnCloudClient) : this.retrieveShareDetails = true }.execute(client) - override fun deleteShare(remoteId: Long): RemoteOperationResult = + override fun deleteShare(remoteId: String): RemoteOperationResult = RemoveRemoteShareOperation( remoteId ).execute(client)