From 27237576efd9f93ec93eb8bc1d5f123b2caba69a Mon Sep 17 00:00:00 2001 From: "David A. Velasco" Date: Tue, 16 Feb 2016 13:31:55 +0100 Subject: [PATCH] Fixed wrong test case for shares, and warnings in test cases --- .../com/owncloud/android/lib/test_project/TestActivity.java | 1 - .../owncloud/android/lib/test_project/test/CopyFileTest.java | 2 -- .../android/lib/test_project/test/OwnCloudClientTest.java | 1 - .../lib/test_project/test/UpdatePrivateShareTest.java | 5 ++--- 4 files changed, 2 insertions(+), 7 deletions(-) diff --git a/test_client/src/com/owncloud/android/lib/test_project/TestActivity.java b/test_client/src/com/owncloud/android/lib/test_project/TestActivity.java index c9fd712a..6d0134f5 100644 --- a/test_client/src/com/owncloud/android/lib/test_project/TestActivity.java +++ b/test_client/src/com/owncloud/android/lib/test_project/TestActivity.java @@ -37,7 +37,6 @@ import android.app.Activity; import android.content.Context; import android.net.Uri; import android.os.Bundle; -import android.os.Environment; import android.util.Log; import android.view.Menu; diff --git a/test_client/tests/src/com/owncloud/android/lib/test_project/test/CopyFileTest.java b/test_client/tests/src/com/owncloud/android/lib/test_project/test/CopyFileTest.java index 468d2de1..1c350f83 100644 --- a/test_client/tests/src/com/owncloud/android/lib/test_project/test/CopyFileTest.java +++ b/test_client/tests/src/com/owncloud/android/lib/test_project/test/CopyFileTest.java @@ -109,8 +109,6 @@ public class CopyFileTest extends ActivityInstrumentationTestCase2 private static final String SRC_PATH_TO_FILE_6 = SRC_BASE_FOLDER + FILE6; - private static final String SRC_PATH_TO_FILE_7 = SRC_BASE_FOLDER + FILE7; - private static final String SRC_PATH_TO_NON_EXISTENT_FILE = SRC_BASE_FOLDER + NO_FILE; private static final String SRC_PATH_TO_EMPTY_FOLDER = SRC_BASE_FOLDER + EMPTY; diff --git a/test_client/tests/src/com/owncloud/android/lib/test_project/test/OwnCloudClientTest.java b/test_client/tests/src/com/owncloud/android/lib/test_project/test/OwnCloudClientTest.java index 81030e44..0e8eca0a 100644 --- a/test_client/tests/src/com/owncloud/android/lib/test_project/test/OwnCloudClientTest.java +++ b/test_client/tests/src/com/owncloud/android/lib/test_project/test/OwnCloudClientTest.java @@ -30,7 +30,6 @@ import java.security.GeneralSecurityException; import org.apache.commons.httpclient.ConnectTimeoutException; import org.apache.commons.httpclient.HttpException; import org.apache.commons.httpclient.methods.HeadMethod; -import org.apache.commons.httpclient.params.HttpMethodParams; import org.apache.commons.httpclient.protocol.Protocol; import org.apache.commons.httpclient.protocol.ProtocolSocketFactory; import org.apache.commons.httpclient.HttpStatus; diff --git a/test_client/tests/src/com/owncloud/android/lib/test_project/test/UpdatePrivateShareTest.java b/test_client/tests/src/com/owncloud/android/lib/test_project/test/UpdatePrivateShareTest.java index d839530b..128b0641 100644 --- a/test_client/tests/src/com/owncloud/android/lib/test_project/test/UpdatePrivateShareTest.java +++ b/test_client/tests/src/com/owncloud/android/lib/test_project/test/UpdatePrivateShareTest.java @@ -28,7 +28,6 @@ package com.owncloud.android.lib.test_project.test; import java.io.File; import java.security.GeneralSecurityException; -import java.util.Calendar; import junit.framework.AssertionFailedError; @@ -207,8 +206,8 @@ public class UpdatePrivateShareTest extends RemoteTest { UpdateRemoteShareOperation updateNoShare = new UpdateRemoteShareOperation( mFileShare.getRemoteId() ); - updateShare.setPermissions(OCShare.READ_PERMISSION_FLAG); // minimum permissions - result = updateShare.execute(mClient); + updateNoShare.setPermissions(OCShare.READ_PERMISSION_FLAG); // minimum permissions + result = updateNoShare.execute(mClient); assertFalse(result.isSuccess()); }