flywithu/android-library
1
0
Fork 0
mirror of https://github.com/owncloud/android-library.git synced 2025-06-07 16:06:08 +00:00
Code Issues Releases Wiki Activity

apply suggested changes

Browse Source 
delete unused const values

bla
This commit is contained in:
Christian Schabesberger 2020-10-21 14:11:32 +02:00 committed by Abel García de Prada
parent 6ec1bd2bb2
commit 257494a9dc
5 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/GetRemoteShareesOperation.kt
View File

@ -164,12 +164,5 @@ class GetRemoteShareesOperation
// Arguments - constant values // Arguments - constant values
private const val VALUE_FORMAT = "json" private const val VALUE_FORMAT = "json"
private const val VALUE_ITEM_TYPE = "file" // to get the server search for users / groups private const val VALUE_ITEM_TYPE = "file" // to get the server search for users / groups
// JSON Node names
const val NODE_VALUE = "value"
const val PROPERTY_LABEL = "label"
const val PROPERTY_SHARE_TYPE = "shareType"
const val PROPERTY_SHARE_WITH = "shareWith"
const val PROPERTY_SHARE_WITH_ADDITIONAL_INFO = "shareWithAdditionalInfo"
} }
} }

3
owncloudComLibrary/src/main/java/com/owncloud/android/lib/resources/shares/RemoteShare.kt
View File

@ -105,7 +105,6 @@ enum class ShareType constructor(val value: Int) {
FEDERATED(6); FEDERATED(6);
companion object { companion object {
private val values = values(); fun fromValue(value: Int) = values().firstOrNull { it.value == value }
fun fromValue(value: Int) = values.firstOrNull { it.value == value }
} }
} }

8
owncloudComLibrary/src/test/java/com/owncloud/android/lib/resources/shares/responses/ShareeResponseTest.kt
View File

@ -51,6 +51,12 @@ class ShareeResponseTest {
response = loadResponses(EXAMPLE_RESPONSE_JSON, adapter)!! response = loadResponses(EXAMPLE_RESPONSE_JSON, adapter)!!
} }
@Test
fun `check structure - ok - example response files exist`() {
val file = File(EXAMPLE_RESPONSE_JSON)
assertTrue(file.exists())
}
@Test @Test
fun `check structure - ok - contains meta`() { fun `check structure - ok - contains meta`() {
assertEquals("OK", response.ocs.meta.message!!) assertEquals("OK", response.ocs.meta.message!!)
@ -115,7 +121,7 @@ class ShareeResponseTest {
companion object { companion object {
val RESOURCES_PATH = val RESOURCES_PATH =
"/home/schabi/Projects/owncloud-android/owncloud-android-library/owncloudComLibrary/src/test/resources/com.owncloud.android.lib.resources.sharees.responses" "src/test/responses/com.owncloud.android.lib.resources.sharees.responses"
val EXAMPLE_RESPONSE_JSON = "$RESOURCES_PATH/example_sharee_response.json" val EXAMPLE_RESPONSE_JSON = "$RESOURCES_PATH/example_sharee_response.json"
val EMPTY_RESPONSE_JSON = "$RESOURCES_PATH/empty_sharee_response.json" val EMPTY_RESPONSE_JSON = "$RESOURCES_PATH/empty_sharee_response.json"
} }

0
owncloudComLibrary/src/test/resources/com.owncloud.android.lib.resources.sharees.responses/empty_sharee_response.json → owncloudComLibrary/src/test/responses/com.owncloud.android.lib.resources.sharees.responses/empty_sharee_response.json
View File

0
owncloudComLibrary/src/test/resources/com.owncloud.android.lib.resources.sharees.responses/example_sharee_response.json → owncloudComLibrary/src/test/responses/com.owncloud.android.lib.resources.sharees.responses/example_sharee_response.json
View File