CryptoExchange.Net.UnitTests/SystemTextJsonConverterTests.cs

@@ -7,7 +7,6 @@ using System.Text.Json.Serialization;
 using NUnit.Framework.Legacy;
 using CryptoExchange.Net.Converters;
 using CryptoExchange.Net.Testing.Comparers;
-using CryptoExchange.Net.SharedApis;
 
 namespace CryptoExchange.Net.UnitTests
 {
@@ -299,40 +298,6 @@ namespace CryptoExchange.Net.UnitTests
             Assert.That(deserialized.Prop8.Prop31, Is.EqualTo(5));
             Assert.That(deserialized.Prop8.Prop32, Is.EqualTo("101"));
         }
-
-        [TestCase(TradingMode.Spot, "ETH", "USDT", null)]
-        [TestCase(TradingMode.PerpetualLinear, "ETH", "USDT", null)]
-        [TestCase(TradingMode.DeliveryLinear, "ETH", "USDT", 1748432430)]
-        public void TestSharedSymbolConversion(TradingMode tradingMode, string baseAsset, string quoteAsset, int? deliverTime)
-        {
-            DateTime? time = deliverTime == null ? null : DateTimeConverter.ParseFromDouble(deliverTime.Value);
-            var symbol = new SharedSymbol(tradingMode, baseAsset, quoteAsset, time);
-
-            var serialized = JsonSerializer.Serialize(symbol);
-            var restored = JsonSerializer.Deserialize<SharedSymbol>(serialized);
-
-            Assert.That(restored.TradingMode, Is.EqualTo(symbol.TradingMode));
-            Assert.That(restored.BaseAsset, Is.EqualTo(symbol.BaseAsset));
-            Assert.That(restored.QuoteAsset, Is.EqualTo(symbol.QuoteAsset));
-            Assert.That(restored.DeliverTime, Is.EqualTo(symbol.DeliverTime));
-        }
-
-        [TestCase(0.1, null, null)]
-        [TestCase(0.1, 0.1, null)]
-        [TestCase(0.1, 0.1, 0.1)]
-        [TestCase(null, 0.1, null)]
-        [TestCase(null, 0.1, 0.1)]
-        public void TestSharedQuantityConversion(double? baseQuantity, double? quoteQuantity, double? contractQuantity)
-        {
-            var symbol = new SharedOrderQuantity((decimal?)baseQuantity, (decimal?)quoteQuantity, (decimal?)contractQuantity);
-
-            var serialized = JsonSerializer.Serialize(symbol);
-            var restored = JsonSerializer.Deserialize<SharedOrderQuantity>(serialized);
-
-            Assert.That(restored.QuantityInBaseAsset, Is.EqualTo(symbol.QuantityInBaseAsset));
-            Assert.That(restored.QuantityInQuoteAsset, Is.EqualTo(symbol.QuantityInQuoteAsset));
-            Assert.That(restored.QuantityInContracts, Is.EqualTo(symbol.QuantityInContracts));
-        }
     }
 
     public class STJDecimalObject

CryptoExchange.Net/Converters/SystemTextJson/SharedQuantityConverter.cs

@@ -1,60 +0,0 @@
-using CryptoExchange.Net.SharedApis;
-using System;
-using System.Collections.Generic;
-using System.Text;
-using System.Text.Json;
-using System.Text.Json.Serialization;
-
-namespace CryptoExchange.Net.Converters.SystemTextJson
-{
-    internal class SharedQuantityConverter : SharedQuantityReferenceConverter<SharedQuantity> { }
-    internal class SharedOrderQuantityConverter : SharedQuantityReferenceConverter<SharedOrderQuantity> { }
-
-    internal class SharedQuantityReferenceConverter<T> : JsonConverter<T> where T: SharedQuantityReference, new()
-    {
-        public override T? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
-        {
-            if (reader.TokenType != JsonTokenType.StartArray)
-                throw new Exception("");
-
-            reader.Read(); // Start array
-            var baseQuantity = reader.TokenType == JsonTokenType.Null ? (decimal?)null : reader.GetDecimal();
-            reader.Read();
-            var quoteQuantity = reader.TokenType == JsonTokenType.Null ? (decimal?)null : reader.GetDecimal();
-            reader.Read();
-            var contractQuantity = reader.TokenType == JsonTokenType.Null ? (decimal?)null : reader.GetDecimal();
-            reader.Read();
-
-            if (reader.TokenType != JsonTokenType.EndArray)
-                throw new Exception("");
-
-            reader.Read(); // End array
-
-            var result = new T();
-            result.QuantityInBaseAsset = baseQuantity;
-            result.QuantityInQuoteAsset = quoteQuantity;
-            result.QuantityInContracts = contractQuantity;
-            return result;
-        }
-
-        public override void Write(Utf8JsonWriter writer, T value, JsonSerializerOptions options)
-        {
-            writer.WriteStartArray();
-            if (value.QuantityInBaseAsset == null)
-                writer.WriteNullValue();
-            else
-                writer.WriteNumberValue(value.QuantityInBaseAsset.Value);
-
-            if (value.QuantityInQuoteAsset == null)
-                writer.WriteNullValue();
-            else
-                writer.WriteNumberValue(value.QuantityInQuoteAsset.Value);
-
-            if (value.QuantityInContracts == null)
-                writer.WriteNullValue();
-            else
-                writer.WriteNumberValue(value.QuantityInContracts.Value);
-            writer.WriteEndArray();
-        }
-    }
-}

CryptoExchange.Net/Converters/SystemTextJson/SharedSymbolConverter.cs

@@ -1,46 +0,0 @@
-using CryptoExchange.Net.SharedApis;
-using System;
-using System.Collections.Generic;
-using System.Text;
-using System.Text.Json;
-using System.Text.Json.Serialization;
-
-namespace CryptoExchange.Net.Converters.SystemTextJson
-{
-    internal class SharedSymbolConverter : JsonConverter<SharedSymbol>
-    {
-        public override SharedSymbol? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
-        {
-            if (reader.TokenType != JsonTokenType.StartArray)
-                throw new Exception("");
-
-            reader.Read(); // Start array
-            var tradingMode = (TradingMode)Enum.Parse(typeof(TradingMode), reader.GetString()!);
-            reader.Read();
-            var baseAsset = reader.GetString()!;
-            reader.Read();
-            var quoteAsset = reader.GetString()!;
-            reader.Read();
-            var timeStr = reader.GetString()!;
-            var deliverTime = string.IsNullOrEmpty(timeStr) ? (DateTime?)null : DateTime.Parse(timeStr);
-            reader.Read();
-
-            if (reader.TokenType != JsonTokenType.EndArray)
-                throw new Exception("");
-
-            reader.Read(); // End array
-
-            return new SharedSymbol(tradingMode, baseAsset, quoteAsset, deliverTime);
-        }
-
-        public override void Write(Utf8JsonWriter writer, SharedSymbol value, JsonSerializerOptions options)
-        {
-            writer.WriteStartArray();
-            writer.WriteStringValue(value.TradingMode.ToString());
-            writer.WriteStringValue(value.BaseAsset);
-            writer.WriteStringValue(value.QuoteAsset);
-            writer.WriteStringValue(value.DeliverTime?.ToString());
-            writer.WriteEndArray();
-        }
-    }
-}

CryptoExchange.Net/CryptoExchange.Net.csproj

@@ -6,9 +6,9 @@
     <PackageId>CryptoExchange.Net</PackageId>
     <Authors>JKorf</Authors>
     <Description>CryptoExchange.Net is a base library which is used to implement different cryptocurrency (exchange) API's. It provides a standardized way of implementing different API's, which results in a very similar experience for users of the API implementations.</Description>
-    <PackageVersion>9.1.0</PackageVersion>
-    <AssemblyVersion>9.1.0</AssemblyVersion>
-    <FileVersion>9.1.0</FileVersion>
+    <PackageVersion>9.0.1</PackageVersion>
+    <AssemblyVersion>9.0.1</AssemblyVersion>
+    <FileVersion>9.0.1</FileVersion>
     <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
     <PackageTags>OKX;OKX.Net;Mexc;Mexc.Net;Kucoin;Kucoin.Net;Kraken;Kraken.Net;Huobi;Huobi.Net;CoinEx;CoinEx.Net;Bybit;Bybit.Net;Bitget;Bitget.Net;Bitfinex;Bitfinex.Net;Binance;Binance.Net;CryptoCurrency;CryptoCurrency Exchange</PackageTags>
     <RepositoryType>git</RepositoryType>
@@ -37,6 +37,12 @@
     <EmbedUntrackedSources>true</EmbedUntrackedSources>
     <ContinuousIntegrationBuild>true</ContinuousIntegrationBuild>
   </PropertyGroup>
+  <ItemGroup Label="Deterministic Build" Condition="'$(Configuration)' == 'Release'">
+    <PackageReference Include="Microsoft.SourceLink.GitHub" Version="8.0.0">
+      <PrivateAssets>all</PrivateAssets>
+      <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
+    </PackageReference>
+  </ItemGroup>
   <PropertyGroup>
     <DocumentationFile>CryptoExchange.Net.xml</DocumentationFile>
   </PropertyGroup>
@@ -51,11 +57,10 @@
     </PackageReference>
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Microsoft.Extensions.Logging" Version="9.0.5" />
-    <PackageReference Include="System.Text.Json" Version="9.0.5" />
-  </ItemGroup>
-  <ItemGroup Label="Transitive Client Packages">
-    <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="9.0.5" />
-    <PackageReference Include="Microsoft.Extensions.Http" Version="9.0.5" />
+    <PackageReference Include="Microsoft.Extensions.Http" Version="9.0.0" />
+    <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="9.0.0" />
+    <PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="9.0.0" />
+    <PackageReference Include="System.Text.Json" Version="9.0.0" />
+    <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="9.0.0" />
   </ItemGroup>
 </Project>

CryptoExchange.Net/SharedApis/SharedQuantity.cs

@@ -1,8 +1,6 @@
-using CryptoExchange.Net.Converters.SystemTextJson;
-using System;
+using System;
 using System.Collections.Generic;
 using System.Text;
-using System.Text.Json.Serialization;
 
 namespace CryptoExchange.Net.SharedApis
 {
@@ -27,7 +25,7 @@ namespace CryptoExchange.Net.SharedApis
         /// <summary>
         /// ctor
         /// </summary>
-        internal SharedQuantityReference(decimal? baseAssetQuantity, decimal? quoteAssetQuantity, decimal? contractQuantity)
+        protected SharedQuantityReference(decimal? baseAssetQuantity, decimal? quoteAssetQuantity, decimal? contractQuantity)
         {
             QuantityInBaseAsset = baseAssetQuantity;
             QuantityInQuoteAsset = quoteAssetQuantity;
@@ -38,7 +36,6 @@ namespace CryptoExchange.Net.SharedApis
     /// <summary>
     /// Quantity for an order
     /// </summary>
-    [JsonConverter(typeof(SharedQuantityConverter))]
     public record SharedQuantity : SharedQuantityReference
     {
         private SharedQuantity(decimal? baseAssetQuantity, decimal? quoteAssetQuantity, decimal? contractQuantity)
@@ -46,11 +43,6 @@ namespace CryptoExchange.Net.SharedApis
         {
         }
 
-        /// <summary>
-        /// ctor
-        /// </summary>
-        public SharedQuantity() : base(null, null, null) { }
-
         /// <summary>
         /// Specify quantity in base asset
         /// </summary>
@@ -106,7 +98,6 @@ namespace CryptoExchange.Net.SharedApis
     /// <summary>
     /// Order quantity
     /// </summary>
-    [JsonConverter(typeof(SharedOrderQuantityConverter))]
     public record SharedOrderQuantity : SharedQuantityReference
     {
         /// <summary>

CryptoExchange.Net/SharedApis/SharedSymbol.cs

@@ -1,15 +1,12 @@
-using CryptoExchange.Net.Converters.SystemTextJson;
-using CryptoExchange.Net.Objects;
+using CryptoExchange.Net.Objects;
 using System;
 using System.Collections.Generic;
-using System.Text.Json.Serialization;
 
 namespace CryptoExchange.Net.SharedApis
 {
     /// <summary>
     /// A symbol representation based on a base and quote asset
     /// </summary>
-    [JsonConverter(typeof(SharedSymbolConverter))]
     public record SharedSymbol
     {
         /// <summary>

README.md

@@ -57,13 +57,6 @@ Make a one time donation in a crypto currency of your choice. If you prefer to d
 Alternatively, sponsor me on Github using [Github Sponsors](https://github.com/sponsors/JKorf). 
 
 ## Release notes
-* Version 9.1.0 - 28 May 2025
-    * Added JsonConverter implementation for SharedQuantity and SharedSymbol types, making usage of the types easier
-    * Updated dotnet dependency packages from 9.0.0 to 9.0.5
-    * Replaced Microsoft.Extensions.Logging.Abstractions with Microsoft.Extensions.Logging
-    * Replaced Microsoft.Extensions.Options.ConfigurationExtensions with Microsoft.Extensions.Configuration.Binder, which includes a source generator for AOT publishing
-    * Removed redundant Microsoft.Extensions.DependencyInjection.Abstractions package reference
-
 * Version 9.0.1 - 20 May 2025
     * Improved response time on CancellationToken cancel during subscribing
     * Added support for sending query without expecting a response