flywithu/CryptoExchange.Net
1
0
Fork 0
mirror of https://github.com/JKorf/CryptoExchange.Net.git synced 2026-11-05 09:47:49 +00:00
Code Issues Releases Wiki Activity

Fixed cancellation source disposal race in CloseAsync (#300)

Browse Source
This commit is contained in:
nils2525
2026-11-03 04:38:38 -08:00
committed by GitHub
parent a4ae3c6d87
commit f88ed02735
1 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CryptoExchange.Net/Sockets/Default/CryptoExchangeWebSocketClient.cs
+10 -9
View File
@@ -446,18 +446,16 @@ namespace CryptoExchange.Net.Sockets.Default
if (_closeTask?.IsCompleted == false) if (_closeTask?.IsCompleted == false)
{ {
_logger.SocketCloseAsyncWaitingForExistingCloseTask(Id); _logger.SocketCloseAsyncWaitingForExistingCloseTask(Id);
await _closeTask.ConfigureAwait(false);
return;
} }
else
if (!IsOpen)
{ {
_logger.SocketCloseAsyncSocketNotOpen(Id); if (!IsOpen)
return; _logger.SocketCloseAsyncSocketNotOpen(Id);
} else
_logger.SocketClosing(Id);
_logger.SocketClosing(Id); _closeTask = CloseInternalAsync();
_closeTask = CloseInternalAsync(); }
} }
finally finally
{ {
@@ -465,8 +463,11 @@ namespace CryptoExchange.Net.Sockets.Default
} }
await _closeTask.ConfigureAwait(false); await _closeTask.ConfigureAwait(false);
// Processing may still be running after the socket closes; finish before the caller disposes it.
if(_processTask != null) if(_processTask != null)
await _processTask.ConfigureAwait(false); await _processTask.ConfigureAwait(false);
await (OnClose?.Invoke() ?? Task.CompletedTask).ConfigureAwait(false); await (OnClose?.Invoke() ?? Task.CompletedTask).ConfigureAwait(false);
_logger.SocketClosed(Id); _logger.SocketClosed(Id);
} }