From f3d535f286d601a65be356a37bac68109a626a07 Mon Sep 17 00:00:00 2001 From: Jkorf Date: Thu, 20 Nov 2025 14:03:59 +0100 Subject: [PATCH] Fixed incorrect check for TimeFilterSupport in combination with StartTime parameter for some Shared endpoints --- .../Models/Options/Endpoints/GetClosedOrdersOptions.cs | 2 +- .../SharedApis/Models/Options/Endpoints/GetDepositsOptions.cs | 2 +- .../Models/Options/Endpoints/GetWithdrawalsOptions.cs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CryptoExchange.Net/SharedApis/Models/Options/Endpoints/GetClosedOrdersOptions.cs b/CryptoExchange.Net/SharedApis/Models/Options/Endpoints/GetClosedOrdersOptions.cs index d273f1a..1727806 100644 --- a/CryptoExchange.Net/SharedApis/Models/Options/Endpoints/GetClosedOrdersOptions.cs +++ b/CryptoExchange.Net/SharedApis/Models/Options/Endpoints/GetClosedOrdersOptions.cs @@ -24,7 +24,7 @@ namespace CryptoExchange.Net.SharedApis /// public override Error? ValidateRequest(string exchange, GetClosedOrdersRequest request, TradingMode? tradingMode, TradingMode[] supportedApiTypes) { - if (TimeFilterSupported && request.StartTime != null) + if (!TimeFilterSupported && request.StartTime != null) return ArgumentError.Invalid(nameof(GetClosedOrdersRequest.StartTime), $"Time filter is not supported"); return base.ValidateRequest(exchange, request, tradingMode, supportedApiTypes); diff --git a/CryptoExchange.Net/SharedApis/Models/Options/Endpoints/GetDepositsOptions.cs b/CryptoExchange.Net/SharedApis/Models/Options/Endpoints/GetDepositsOptions.cs index 873f144..fee678b 100644 --- a/CryptoExchange.Net/SharedApis/Models/Options/Endpoints/GetDepositsOptions.cs +++ b/CryptoExchange.Net/SharedApis/Models/Options/Endpoints/GetDepositsOptions.cs @@ -24,7 +24,7 @@ namespace CryptoExchange.Net.SharedApis /// public override Error? ValidateRequest(string exchange, GetDepositsRequest request, TradingMode? tradingMode, TradingMode[] supportedApiTypes) { - if (TimeFilterSupported && request.StartTime != null) + if (!TimeFilterSupported && request.StartTime != null) return ArgumentError.Invalid(nameof(GetDepositsRequest.StartTime), $"Time filter is not supported"); return base.ValidateRequest(exchange, request, tradingMode, supportedApiTypes); diff --git a/CryptoExchange.Net/SharedApis/Models/Options/Endpoints/GetWithdrawalsOptions.cs b/CryptoExchange.Net/SharedApis/Models/Options/Endpoints/GetWithdrawalsOptions.cs index f6f3c7c..0157237 100644 --- a/CryptoExchange.Net/SharedApis/Models/Options/Endpoints/GetWithdrawalsOptions.cs +++ b/CryptoExchange.Net/SharedApis/Models/Options/Endpoints/GetWithdrawalsOptions.cs @@ -24,7 +24,7 @@ namespace CryptoExchange.Net.SharedApis /// public override Error? ValidateRequest(string exchange, GetWithdrawalsRequest request, TradingMode? tradingMode, TradingMode[] supportedApiTypes) { - if (TimeFilterSupported && request.StartTime != null) + if (!TimeFilterSupported && request.StartTime != null) return ArgumentError.Invalid(nameof(GetWithdrawalsRequest.StartTime), $"Time filter is not supported"); return base.ValidateRequest(exchange, request, tradingMode, supportedApiTypes);