diff --git a/CryptoExchange.Net/Clients/BaseClient.cs b/CryptoExchange.Net/Clients/BaseClient.cs index c015ccd..f64d866 100644 --- a/CryptoExchange.Net/Clients/BaseClient.cs +++ b/CryptoExchange.Net/Clients/BaseClient.cs @@ -19,9 +19,9 @@ namespace CryptoExchange.Net public abstract class BaseClient : IDisposable { /// - /// The name of the exchange the client is for + /// The name of the API the client is for /// - internal string ExchangeName { get; } + internal string Name { get; } /// /// Api clients in this client /// @@ -56,19 +56,19 @@ namespace CryptoExchange.Net /// /// ctor /// - /// The name of the exchange this client is for + /// The name of the API this client is for /// The options for this client - protected BaseClient(string exchangeName, BaseClientOptions options) + protected BaseClient(string name, BaseClientOptions options) { - log = new Log(exchangeName); + log = new Log(name); log.UpdateWriters(options.LogWriters); log.Level = options.LogLevel; ClientOptions = options; - ExchangeName = exchangeName; + Name = name; - log.Write(LogLevel.Trace, $"Client configuration: {options}, CryptoExchange.Net: v{typeof(BaseClient).Assembly.GetName().Version}, {ExchangeName}.Net: v{GetType().Assembly.GetName().Version}"); + log.Write(LogLevel.Trace, $"Client configuration: {options}, CryptoExchange.Net: v{typeof(BaseClient).Assembly.GetName().Version}, {name}.Net: v{GetType().Assembly.GetName().Version}"); } /// @@ -278,7 +278,7 @@ namespace CryptoExchange.Net /// public virtual void Dispose() { - log.Write(LogLevel.Debug, "Disposing exchange client"); + log.Write(LogLevel.Debug, "Disposing client"); foreach (var client in ApiClients) client.Dispose(); } diff --git a/CryptoExchange.Net/Clients/BaseRestClient.cs b/CryptoExchange.Net/Clients/BaseRestClient.cs index 45b0077..cb2b58f 100644 --- a/CryptoExchange.Net/Clients/BaseRestClient.cs +++ b/CryptoExchange.Net/Clients/BaseRestClient.cs @@ -74,15 +74,15 @@ namespace CryptoExchange.Net /// /// ctor /// - /// The name of the exchange this client is for - /// The options for this client - protected BaseRestClient(string exchangeName, BaseRestClientOptions exchangeOptions) : base(exchangeName, exchangeOptions) + /// The name of the API this client is for + /// The options for this client + protected BaseRestClient(string name, BaseRestClientOptions options) : base(name, options) { - if (exchangeOptions == null) - throw new ArgumentNullException(nameof(exchangeOptions)); + if (options == null) + throw new ArgumentNullException(nameof(options)); - ClientOptions = exchangeOptions; - RequestFactory.Configure(exchangeOptions.RequestTimeout, exchangeOptions.Proxy, exchangeOptions.HttpClient); + ClientOptions = options; + RequestFactory.Configure(options.RequestTimeout, options.Proxy, options.HttpClient); } /// diff --git a/CryptoExchange.Net/Clients/BaseSocketClient.cs b/CryptoExchange.Net/Clients/BaseSocketClient.cs index 5450735..5b33c1b 100644 --- a/CryptoExchange.Net/Clients/BaseSocketClient.cs +++ b/CryptoExchange.Net/Clients/BaseSocketClient.cs @@ -101,14 +101,14 @@ namespace CryptoExchange.Net /// /// ctor /// - /// The name of the exchange this client is for - /// The options for this client - protected BaseSocketClient(string exchangeName, BaseSocketClientOptions exchangeOptions): base(exchangeName, exchangeOptions) + /// The name of the API this client is for + /// The options for this client + protected BaseSocketClient(string name, BaseSocketClientOptions options) : base(name, options) { - if (exchangeOptions == null) - throw new ArgumentNullException(nameof(exchangeOptions)); + if (options == null) + throw new ArgumentNullException(nameof(options)); - ClientOptions = exchangeOptions; + ClientOptions = options; } /// diff --git a/CryptoExchange.Net/CryptoExchange.Net.csproj b/CryptoExchange.Net/CryptoExchange.Net.csproj index f05e620..b4e61c1 100644 --- a/CryptoExchange.Net/CryptoExchange.Net.csproj +++ b/CryptoExchange.Net/CryptoExchange.Net.csproj @@ -5,7 +5,7 @@ CryptoExchange.Net JKorf - A base package for implementing cryptocurrency exchange API's + A base package for implementing cryptocurrency API's 5.0.0-beta9 5.0.0 5.0.0-beta9 diff --git a/CryptoExchange.Net/Objects/Options.cs b/CryptoExchange.Net/Objects/Options.cs index a99587a..7dcfdcb 100644 --- a/CryptoExchange.Net/Objects/Options.cs +++ b/CryptoExchange.Net/Objects/Options.cs @@ -163,7 +163,7 @@ namespace CryptoExchange.Net.Objects public TimeSpan SocketNoDataTimeout { get; set; } /// - /// The amount of subscriptions that should be made on a single socket connection. Not all exchanges support multiple subscriptions on a single socket. + /// The amount of subscriptions that should be made on a single socket connection. Not all API's support multiple subscriptions on a single socket. /// Setting this to a higher number increases subscription speed because not every subscription needs to connect to the server, but having more subscriptions on a /// single connection will also increase the amount of traffic on that single connection, potentially leading to issues. ///