From dd1cefdc90d6fdbc87f2b8e84c922aade526152c Mon Sep 17 00:00:00 2001 From: Jkorf Date: Mon, 29 Jun 2026 11:20:06 +0200 Subject: [PATCH] Fixed bug in bool converter --- .../ConverterTests/BoolConverterTests.cs | 11 +++++++++++ .../Converters/SystemTextJson/BoolConverter.cs | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/CryptoExchange.Net.UnitTests/ConverterTests/BoolConverterTests.cs b/CryptoExchange.Net.UnitTests/ConverterTests/BoolConverterTests.cs index b65d1edb..6160c459 100644 --- a/CryptoExchange.Net.UnitTests/ConverterTests/BoolConverterTests.cs +++ b/CryptoExchange.Net.UnitTests/ConverterTests/BoolConverterTests.cs @@ -25,6 +25,17 @@ namespace CryptoExchange.Net.UnitTests.ConverterTests Assert.That(output!.Value == expected); } + [TestCase(1, true)] + [TestCase(2, true)] + [TestCase(0, false)] + [TestCase(-1, false)] + public void TestBoolConverterInts(int value, bool? expected) + { + var val = value == null ? "null" : $"{value}"; + var output = JsonSerializer.Deserialize($"{{ \"Value\": {val} }}", SerializerOptions.WithConverters(new TestSerializerContext())); + Assert.That(output!.Value == expected); + } + [TestCase("1", true)] [TestCase("true", true)] [TestCase("yes", true)] diff --git a/CryptoExchange.Net/Converters/SystemTextJson/BoolConverter.cs b/CryptoExchange.Net/Converters/SystemTextJson/BoolConverter.cs index 9309f777..76ba9e98 100644 --- a/CryptoExchange.Net/Converters/SystemTextJson/BoolConverter.cs +++ b/CryptoExchange.Net/Converters/SystemTextJson/BoolConverter.cs @@ -59,7 +59,7 @@ namespace CryptoExchange.Net.Converters.SystemTextJson if (reader.TokenType == JsonTokenType.Number) { var number = reader.GetInt16(); - if (number > 1) + if (number >= 1) return true; return false;