flywithu/CryptoExchange.Net
1
0
Fork 0
mirror of https://github.com/JKorf/CryptoExchange.Net.git synced 2026-08-15 02:13:01 +00:00
Code Issues Releases Wiki Activity

Websocket performance update (#261)

Browse Source 
Performance update:

Authentication
	Added Ed25519 signing support for NET8.0 and newer
	Added static methods on ApiCredentials to create credentials of a specific type
	Added static ApiCredentials.ReadFromFile method to read a key from file
	Added required abstract SupportedCredentialTypes property on AuthenticationProvider base class

General Performance
	Added checks before logging statements to prevent overhead of building the log string if logging is not needed	
	Added ExchangeHelpers.ProcessQueuedAsync method to process updates async
	Replaced locking object types from object to Lock in NET9.0 and newer 
	Replaced some Task response types with ValueTask to prevent allocation overhead on hot paths
	Updated Json ArrayConverter to reduce some allocation overhead 
	Updated Json BoolConverter to prevent boxing
	Updated Json DateTimeConverter to prevent boxing
	Updated Json EnumConverter caching to reduce lookup overhead
	Updated ExtensionMethods.CreateParamString to reduce allocations
	Updated ExtensionMethods.AppendPath to reduce overhead	

REST 
	Refactored REST message processing to separate IRestMessageHandler instance
	Split RestApiClient.PrepareAsync into CheckTimeSync and RateLimitAsync
	Updated IRequest.Accept type from string to MediaTypeWithQualityHeaderValue to prevent creation on each request
	Updated IRequest.GetHeaders response type from KeyValuePair<string, string[]>[] to HttpRequestHeaders to prevent additional mapping
	Updated IResponse.ResponseHeaders type from KeyValuePair<string, string[]>[] to HttpResponseHeaders to prevent additional mapping
	Updated WebCallResult RequestHeaders and ResponseHeaders types to HttpRequestHeaders and HttpResponseHeaders	
	Removed unnecessary empty dictionary initializations for each request
	Removed CallResult creation in internal methods to prevent having to create multiple versions for different result types 

Socket
	Added HighPerformance websocket client implementation which significantly reduces memory overhead and improves speed but with certain limitations
	Added MaxIndividualSubscriptionsPerConnection setting in SocketApiClient to limit the number of individual stream subscriptions on a connection
	Added SocketIndividualSubscriptionCombineTarget option to set the target number of individual stream subscriptions per connection
	Added new websocket message handling logic which is faster and reduces memory allocation
	Added UseUpdatedDeserialization option to toggle between updated deserialization and old deserialization 
	Added Exchange property to DataEvent to prevent additional mapping overhead for Shared apis
	Refactored message callback to be sync instead of async to prevent async overhead
	Refactored CryptoExchangeWebSocketClient.IncomingKbps calculation to significantly reduce overhead
	Moved websocket client creation from SocketApiClient to SocketConnection	
	Removed DataEvent.As and DataEvent.ToCallResult methods in favor of single ToType method
	Removed DataEvent creation on lower levels to prevent having to create multiple versions for different result types
	Removed Subscription<TSubResponse, TUnsubResponse> as its no longer used

Other
	Added null check to ParameterCollection for required parameters 
	Added Net10.0 target framework
	Updated dependency versions
	Updated Shared asset aliases check to be culture invariant
	Updated Error string representation
	Updated some namespaces
	Updated SymbolOrderBook processing of buffered updates to prevent additional allocation
	Removed ExchangeEvent type which is no longer needed
	Removed unused usings
This commit is contained in:
Jan Korf
2025-12-16 11:27:49 +01:00
committed by GitHub
parent f125bc88b0
commit d079796020
238 changed files with 5061 additions and 2066 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CryptoExchange.Net/Objects/ParameterCollection.cs
+29 -20
View File
@@ -13,6 +13,15 @@ namespace CryptoExchange.Net.Objects
/// </summary>
public class ParameterCollection : Dictionary<string, object>
{
/// <inheritdoc />
public new void Add(string key, object value)
{
if (value == null)
throw new ArgumentNullException(key);
base.Add(key, value);
}
/// <summary>
/// Add an optional parameter. Not added if value is null
/// </summary>
@@ -21,7 +30,7 @@ namespace CryptoExchange.Net.Objects
public void AddOptional(string key, object? value)
{
if (value != null)
Add(key, value);
base.Add(key, value);
}
/// <summary>
@@ -31,7 +40,7 @@ namespace CryptoExchange.Net.Objects
/// <param name="value"></param>
public void AddString(string key, decimal value)
{
Add(key, value.ToString(CultureInfo.InvariantCulture));
base.Add(key, value.ToString(CultureInfo.InvariantCulture));
}
/// <summary>
@@ -42,7 +51,7 @@ namespace CryptoExchange.Net.Objects
public void AddOptionalString(string key, decimal? value)
{
if (value != null)
Add(key, value.Value.ToString(CultureInfo.InvariantCulture));
base.Add(key, value.Value.ToString(CultureInfo.InvariantCulture));
}
/// <summary>
@@ -52,7 +61,7 @@ namespace CryptoExchange.Net.Objects
/// <param name="value"></param>
public void AddString(string key, int value)
{
Add(key, value.ToString(CultureInfo.InvariantCulture));
base.Add(key, value.ToString(CultureInfo.InvariantCulture));
}
/// <summary>
@@ -63,7 +72,7 @@ namespace CryptoExchange.Net.Objects
public void AddOptionalString(string key, int? value)
{
if (value != null)
Add(key, value.Value.ToString(CultureInfo.InvariantCulture));
base.Add(key, value.Value.ToString(CultureInfo.InvariantCulture));
}
/// <summary>
@@ -73,7 +82,7 @@ namespace CryptoExchange.Net.Objects
/// <param name="value"></param>
public void AddString(string key, long value)
{
Add(key, value.ToString(CultureInfo.InvariantCulture));
base.Add(key, value.ToString(CultureInfo.InvariantCulture));
}
/// <summary>
@@ -84,7 +93,7 @@ namespace CryptoExchange.Net.Objects
public void AddOptionalString(string key, long? value)
{
if (value != null)
Add(key, value.Value.ToString(CultureInfo.InvariantCulture));
base.Add(key, value.Value.ToString(CultureInfo.InvariantCulture));
}
/// <summary>
@@ -94,7 +103,7 @@ namespace CryptoExchange.Net.Objects
/// <param name="value"></param>
public void AddMilliseconds(string key, DateTime value)
{
Add(key, DateTimeConverter.ConvertToMilliseconds(value));
base.Add(key, DateTimeConverter.ConvertToMilliseconds(value));
}
/// <summary>
@@ -105,7 +114,7 @@ namespace CryptoExchange.Net.Objects
public void AddOptionalMilliseconds(string key, DateTime? value)
{
if (value != null)
Add(key, DateTimeConverter.ConvertToMilliseconds(value));
base.Add(key, DateTimeConverter.ConvertToMilliseconds(value));
}
/// <summary>
@@ -115,7 +124,7 @@ namespace CryptoExchange.Net.Objects
/// <param name="value"></param>
public void AddMillisecondsString(string key, DateTime value)
{
Add(key, DateTimeConverter.ConvertToMilliseconds(value).Value.ToString(CultureInfo.InvariantCulture));
base.Add(key, DateTimeConverter.ConvertToMilliseconds(value).Value.ToString(CultureInfo.InvariantCulture));
}
/// <summary>
@@ -126,7 +135,7 @@ namespace CryptoExchange.Net.Objects
public void AddOptionalMillisecondsString(string key, DateTime? value)
{
if (value != null)
Add(key, DateTimeConverter.ConvertToMilliseconds(value).Value.ToString(CultureInfo.InvariantCulture));
base.Add(key, DateTimeConverter.ConvertToMilliseconds(value).Value.ToString(CultureInfo.InvariantCulture));
}
/// <summary>
@@ -136,7 +145,7 @@ namespace CryptoExchange.Net.Objects
/// <param name="value"></param>
public void AddSeconds(string key, DateTime value)
{
Add(key, DateTimeConverter.ConvertToSeconds(value));
base.Add(key, DateTimeConverter.ConvertToSeconds(value));
}
/// <summary>
@@ -147,7 +156,7 @@ namespace CryptoExchange.Net.Objects
public void AddOptionalSeconds(string key, DateTime? value)
{
if (value != null)
Add(key, DateTimeConverter.ConvertToSeconds(value));
base.Add(key, DateTimeConverter.ConvertToSeconds(value));
}
/// <summary>
@@ -157,7 +166,7 @@ namespace CryptoExchange.Net.Objects
/// <param name="value"></param>
public void AddSecondsString(string key, DateTime value)
{
Add(key, DateTimeConverter.ConvertToSeconds(value).ToString()!);
base.Add(key, DateTimeConverter.ConvertToSeconds(value).ToString()!);
}
/// <summary>
@@ -168,7 +177,7 @@ namespace CryptoExchange.Net.Objects
public void AddOptionalSecondsString(string key, DateTime? value)
{
if (value != null)
Add(key, DateTimeConverter.ConvertToSeconds(value).ToString()!);
base.Add(key, DateTimeConverter.ConvertToSeconds(value).ToString()!);
}
/// <summary>
@@ -181,7 +190,7 @@ namespace CryptoExchange.Net.Objects
#endif
where T : struct, Enum
{
Add(key, EnumConverter<T>.GetString(value)!);
base.Add(key, EnumConverter<T>.GetString(value)!);
}
/// <summary>
@@ -197,7 +206,7 @@ namespace CryptoExchange.Net.Objects
where T : struct, Enum
{
var stringVal = EnumConverter<T>.GetString(value)!;
Add(key, int.Parse(stringVal)!);
base.Add(key, int.Parse(stringVal)!);
}
/// <summary>
@@ -213,7 +222,7 @@ namespace CryptoExchange.Net.Objects
where T : struct, Enum
{
if (value != null)
Add(key, EnumConverter<T>.GetString(value));
base.Add(key, EnumConverter<T>.GetString(value));
}
/// <summary>
@@ -229,7 +238,7 @@ namespace CryptoExchange.Net.Objects
if (value != null)
{
var stringVal = EnumConverter<T>.GetString(value);
Add(key, int.Parse(stringVal));
base.Add(key, int.Parse(stringVal));
}
}
@@ -243,7 +252,7 @@ namespace CryptoExchange.Net.Objects
if (this.Any())
throw new InvalidOperationException("Can't set body when other parameters already specified");
Add(Constants.BodyPlaceHolderKey, body);
base.Add(Constants.BodyPlaceHolderKey, body);
}
}
}