Fix for socket issues .net framework

CryptoExchange.Net/Sockets/CryptoExchangeWebSocketClient.cs

@@ -44,7 +44,7 @@ namespace CryptoExchange.Net.Sockets
         /// <summary>
         /// Received messages time -> size
         /// </summary>
-        protected readonly Dictionary<DateTime, int> _receivedMessages;
+        internal readonly List<ReceiveItem> _receivedMessages;
         /// <summary>
         /// Received messages lock
         /// </summary>
@@ -152,7 +152,7 @@ namespace CryptoExchange.Net.Sockets
                     if (!_receivedMessages.Any())
                         return 0;
 
-                    return Math.Round(_receivedMessages.Values.Sum(v => v) / 1000 / 3d);
+                    return Math.Round(_receivedMessages.Sum(v => v.Bytes) / 1000 / 3d);
                 }
             }
         }
@@ -215,7 +215,7 @@ namespace CryptoExchange.Net.Sockets
             this.headers = headers;
 
             _outgoingMessages = new List<DateTime>();
-            _receivedMessages = new Dictionary<DateTime, int>();
+            _receivedMessages = new List<ReceiveItem>();
             _sendEvent = new AsyncResetEvent();
             _sendBuffer = new ConcurrentQueue<byte[]>();
             _ctsSource = new CancellationTokenSource();
@@ -380,6 +380,8 @@ namespace CryptoExchange.Net.Sockets
         private async Task SendLoopAsync()
         {
             _startedSent = true;
+            try
+            {
                 while (true)
                 {
                     if (_closing)
@@ -435,6 +437,15 @@ namespace CryptoExchange.Net.Sockets
                     }
                 }
             }
+            catch (Exception e)
+            {
+                // Because this is running in a separate task and not awaited until the socket gets closed
+                // any exception here will crash the send processing, but do so silently unless the socket get's stopped.
+                // Make sure we at least let the owner know there was an error
+                Handle(errorHandlers, e);
+                throw;
+            }
+        }
 
         /// <summary>
         /// Loop for receiving and reassembling data
@@ -446,6 +457,8 @@ namespace CryptoExchange.Net.Sockets
 
             var buffer = new ArraySegment<byte>(new byte[65536]);
             var received = 0;
+            try
+            {
                 while (true)
                 {
                     if (_closing)
@@ -461,7 +474,7 @@ namespace CryptoExchange.Net.Sockets
                             receiveResult = await _socket.ReceiveAsync(buffer, _ctsSource.Token).ConfigureAwait(false);
                             received += receiveResult.Count;
                             lock (_receivedMessagesLock)
-                            _receivedMessages.Add(DateTime.UtcNow, receiveResult.Count);
+                                _receivedMessages.Add(new ReceiveItem(DateTime.UtcNow, receiveResult.Count));
                         }
                         catch (OperationCanceledException)
                         {
@@ -542,6 +555,15 @@ namespace CryptoExchange.Net.Sockets
                     }
                 }
             }
+            catch(Exception e)
+            {
+                // Because this is running in a separate task and not awaited until the socket gets closed
+                // any exception here will crash the receive processing, but do so silently unless the socket get's stopped.
+                // Make sure we at least let the owner know there was an error
+                Handle(errorHandlers, e);
+                throw;
+            }
+        }
 
         /// <summary>
         /// Handles the message
@@ -604,6 +626,8 @@ namespace CryptoExchange.Net.Sockets
         protected async Task CheckTimeoutAsync()
         {
             log.Write(LogLevel.Debug, $"Socket {Id} Starting task checking for no data received for {Timeout}");
+            try 
+            { 
                 while (true)
                 {
                     if (_closing)
@@ -626,6 +650,15 @@ namespace CryptoExchange.Net.Sockets
                     }
                 }
             }
+            catch (Exception e)
+            {
+                // Because this is running in a separate task and not awaited until the socket gets closed
+                // any exception here will stop the timeout checking, but do so silently unless the socket get's stopped.
+                // Make sure we at least let the owner know there was an error
+                Handle(errorHandlers, e);
+                throw;
+            }
+        }
 
         /// <summary>
         /// Helper to invoke handlers
@@ -679,12 +712,24 @@ namespace CryptoExchange.Net.Sockets
             var checkTime = DateTime.UtcNow;
             if (checkTime - _lastReceivedMessagesUpdate > TimeSpan.FromSeconds(1))
             {
-                foreach (var msgTime in _receivedMessages.Keys.ToList())
-                    if (checkTime - msgTime > TimeSpan.FromSeconds(3))
-                        _receivedMessages.Remove(msgTime);
+                foreach (var msg in _receivedMessages.ToList()) // To list here because we're removing from the list
+                    if (checkTime - msg.Timestamp > TimeSpan.FromSeconds(3))
+                        _receivedMessages.Remove(msg);
 
                 _lastReceivedMessagesUpdate = checkTime;
             }
         }
     }
+
+    internal struct ReceiveItem
+    {
+        public DateTime Timestamp { get; set; }
+        public int Bytes { get; set; }
+
+        public ReceiveItem(DateTime timestamp, int bytes)
+        {
+            Timestamp = timestamp;
+            Bytes = bytes;
+        }
+    }
 }