flywithu/CryptoExchange.Net
1
0
Fork 0
mirror of https://github.com/JKorf/CryptoExchange.Net synced 2025-06-18 21:36:22 +00:00
Code Issues Releases Wiki Activity

Dont lock subscriptions during message handling

Browse Source
This commit is contained in:
Jkorf 2021-09-24 15:18:42 +02:00
parent 29ebd13958
commit 89de0da724
2 changed files with 24 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
CryptoExchange.Net/CryptoExchange.Net.xml
View File

@ -1030,6 +1030,13 @@
<param name="cancellationToken"></param> <param name="cancellationToken"></param>
<returns></returns> <returns></returns>
</member> </member>
<member name="M:CryptoExchange.Net.ExtensionMethods.WaitOneAsync(System.Threading.WaitHandle)">
<summary>
Wait one async
</summary>
<param name="handle"></param>
<returns></returns>
</member>
<member name="M:CryptoExchange.Net.ExtensionMethods.WaitOneAsync(System.Threading.WaitHandle,System.TimeSpan)"> <member name="M:CryptoExchange.Net.ExtensionMethods.WaitOneAsync(System.Threading.WaitHandle,System.TimeSpan)">
<summary> <summary>
Wait one async Wait one async

33
CryptoExchange.Net/Sockets/SocketConnection.cs
View File

@ -224,31 +224,32 @@ namespace CryptoExchange.Net.Sockets
var sw = Stopwatch.StartNew(); var sw = Stopwatch.StartNew();
// Loop the subscriptions to check if any of them signal us that the message is for them // Loop the subscriptions to check if any of them signal us that the message is for them
List<SocketSubscription> subscriptionsCopy;
lock (subscriptionLock) lock (subscriptionLock)
subscriptionsCopy = subscriptions.ToList();
foreach (var subscription in subscriptionsCopy)
{ {
foreach (var subscription in subscriptions.ToList()) currentSubscription = subscription;
if (subscription.Request == null)
{ {
currentSubscription = subscription; if (socketClient.MessageMatchesHandler(messageEvent.JsonData, subscription.Identifier!))
if (subscription.Request == null)
{ {
if (socketClient.MessageMatchesHandler(messageEvent.JsonData, subscription.Identifier!)) handled = true;
{ subscription.MessageHandler(messageEvent);
handled = true;
subscription.MessageHandler(messageEvent);
}
} }
else }
else
{
if (socketClient.MessageMatchesHandler(messageEvent.JsonData, subscription.Request))
{ {
if (socketClient.MessageMatchesHandler(messageEvent.JsonData, subscription.Request)) handled = true;
{ messageEvent.JsonData = socketClient.ProcessTokenData(messageEvent.JsonData);
handled = true; subscription.MessageHandler(messageEvent);
messageEvent.JsonData = socketClient.ProcessTokenData(messageEvent.JsonData);
subscription.MessageHandler(messageEvent);
}
} }
} }
} }
sw.Stop(); sw.Stop();
if (sw.ElapsedMilliseconds > 500) if (sw.ElapsedMilliseconds > 500)
log.Write(LogLevel.Warning, $"Socket {Socket.Id} message processing slow ({sw.ElapsedMilliseconds}ms), consider offloading data handling to another thread. " + log.Write(LogLevel.Warning, $"Socket {Socket.Id} message processing slow ({sw.ElapsedMilliseconds}ms), consider offloading data handling to another thread. " +