From 7c34b628665038ac0aa47fe000d0af6f4b455237 Mon Sep 17 00:00:00 2001 From: Jkorf Date: Tue, 7 Apr 2026 16:20:03 +0200 Subject: [PATCH] wip --- .../ClientTests/SocketClientTests.cs | 2 +- .../Converters/SystemTextJson/EnumConverter.cs | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CryptoExchange.Net.UnitTests/ClientTests/SocketClientTests.cs b/CryptoExchange.Net.UnitTests/ClientTests/SocketClientTests.cs index 3d26f5a..059ba66 100644 --- a/CryptoExchange.Net.UnitTests/ClientTests/SocketClientTests.cs +++ b/CryptoExchange.Net.UnitTests/ClientTests/SocketClientTests.cs @@ -9,7 +9,7 @@ using System.Text.Json; using System.Threading; using System.Threading.Tasks; -namespace CryptoExchange.Net.UnitTests +namespace CryptoExchange.Net.UnitTests.ClientTests { [TestFixture] public class SocketClientTests diff --git a/CryptoExchange.Net/Converters/SystemTextJson/EnumConverter.cs b/CryptoExchange.Net/Converters/SystemTextJson/EnumConverter.cs index 4d598a4..687ba5d 100644 --- a/CryptoExchange.Net/Converters/SystemTextJson/EnumConverter.cs +++ b/CryptoExchange.Net/Converters/SystemTextJson/EnumConverter.cs @@ -98,6 +98,7 @@ namespace CryptoExchange.Net.Converters.SystemTextJson private static T? _undefinedEnumValue; private static bool _hasFlagsAttribute = _enumType.IsDefined(typeof(FlagsAttribute)); private static ConcurrentBag _unknownValuesWarned = new ConcurrentBag(); + private static ConcurrentBag _notOptimalValuesWarned = new ConcurrentBag(); internal class NullableEnumConverter : JsonConverter { @@ -210,9 +211,9 @@ namespace CryptoExchange.Net.Converters.SystemTextJson if (RunOptimistic && !isNumber) { - if (!_unknownValuesWarned.Contains(stringValue)) + if (!_notOptimalValuesWarned.Contains(stringValue)) { - _unknownValuesWarned.Add(stringValue!); + _notOptimalValuesWarned.Add(stringValue!); LibraryHelpers.StaticLogger?.LogTrace($"Enum mapping sub-optimal. EnumType: {_enumType.FullName}, Value: {stringValue}, Known values: [{string.Join(", ", _mappingToEnum!.Select(m => $"{m.StringValue}: {m.Value}"))}]"); } }