flywithu/CryptoExchange.Net
1
0
Fork 0
mirror of https://github.com/JKorf/CryptoExchange.Net synced 2025-06-07 16:06:15 +00:00
Code Issues Releases Wiki Activity

Fixed System.Text.Json tests not correctly checking capitalization

Browse Source
This commit is contained in:
JKorf 2024-08-07 16:49:12 +02:00
parent 7fde8bf5da
commit 69b2e2045e
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
CryptoExchange.Net/Testing/Comparers/SystemTextJsonComparer.cs
View File

@ -161,12 +161,16 @@ namespace CryptoExchange.Net.Testing.Comparers
// Property has a value // Property has a value
var property = resultProperties.SingleOrDefault(p => p.Name == prop.Name).p; var property = resultProperties.SingleOrDefault(p => p.Name == prop.Name).p;
property ??= resultProperties.SingleOrDefault(p => p.p.Name == prop.Name).p; property ??= resultProperties.SingleOrDefault(p => p.p.Name == prop.Name).p;
property ??= resultProperties.SingleOrDefault(p => p.p.Name.Equals(prop.Name, StringComparison.InvariantCultureIgnoreCase)).p;
if (property is null) if (property is null)
// Property not found // Property not found
throw new Exception($"{method}: Missing property `{prop.Name}` on `{obj.GetType().Name}`"); throw new Exception($"{method}: Missing property `{prop.Name}` on `{obj.GetType().Name}`");
var getMethod = property.GetGetMethod();
if (getMethod is null)
// There is no getter, so probably just a set for an alternative json name
return;
var propertyValue = property.GetValue(obj); var propertyValue = property.GetValue(obj);
CheckPropertyValue(method, prop.Value, propertyValue, property.PropertyType, property.Name, prop.Name, ignoreProperties); CheckPropertyValue(method, prop.Value, propertyValue, property.PropertyType, property.Name, prop.Name, ignoreProperties);
} }
@ -364,9 +368,10 @@ namespace CryptoExchange.Net.Testing.Comparers
} }
else if (objectValue is bool bl) else if (objectValue is bool bl)
{ {
if (bl && jsonValue.Value<string>() != "1") var jsonStr = jsonValue.Value<string>();
if (bl && (jsonStr != "1" && jsonStr != "true" && jsonStr != "True"))
throw new Exception($"{method}: {property} not equal: {jsonValue.Value<string>()} vs {bl}"); throw new Exception($"{method}: {property} not equal: {jsonValue.Value<string>()} vs {bl}");
if (!bl && jsonValue.Value<string>() != "0") if (!bl && (jsonStr != "0" && jsonStr != "-1" && jsonStr != "false" && jsonStr != "False"))
throw new Exception($"{method}: {property} not equal: {jsonValue.Value<string>()} vs {bl}"); throw new Exception($"{method}: {property} not equal: {jsonValue.Value<string>()} vs {bl}");
} }
else if (propertyType.IsEnum || Nullable.GetUnderlyingType(propertyType)?.IsEnum == true) else if (propertyType.IsEnum || Nullable.GetUnderlyingType(propertyType)?.IsEnum == true)