1
0
mirror of https://github.com/JKorf/CryptoExchange.Net synced 2025-07-23 18:05:43 +00:00

Updated version

This commit is contained in:
Jkorf 2022-02-24 12:55:59 +01:00
parent 0c6e74911d
commit 63d4af8543
5 changed files with 14 additions and 8 deletions

View File

@ -281,7 +281,7 @@ namespace CryptoExchange.Net.UnitTests
{ {
} }
public TestClientOptions(TestClientOptions? baseOn): base(baseOn) public TestClientOptions(TestClientOptions baseOn): base(baseOn)
{ {
if (baseOn == null) if (baseOn == null)
return; return;

View File

@ -70,7 +70,8 @@ namespace CryptoExchange.Net.Authentication
public virtual ApiCredentials Copy() public virtual ApiCredentials Copy()
{ {
if (PrivateKey == null) if (PrivateKey == null)
return new ApiCredentials(Key!, Secret!); // Use .ToString() to create a copy of the SecureString
return new ApiCredentials(Key!.ToString(), Secret!.ToString());
else else
return new ApiCredentials(PrivateKey!.Copy()); return new ApiCredentials(PrivateKey!.Copy());
} }

View File

@ -6,16 +6,16 @@
<PackageId>CryptoExchange.Net</PackageId> <PackageId>CryptoExchange.Net</PackageId>
<Authors>JKorf</Authors> <Authors>JKorf</Authors>
<Description>A base package for implementing cryptocurrency API's</Description> <Description>A base package for implementing cryptocurrency API's</Description>
<PackageVersion>5.0.0</PackageVersion> <PackageVersion>5.1.0</PackageVersion>
<AssemblyVersion>5.0.0</AssemblyVersion> <AssemblyVersion>5.1.0</AssemblyVersion>
<FileVersion>5.0.0</FileVersion> <FileVersion>5.1.0</FileVersion>
<PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance> <PackageRequireLicenseAcceptance>false</PackageRequireLicenseAcceptance>
<RepositoryType>git</RepositoryType> <RepositoryType>git</RepositoryType>
<RepositoryUrl>https://github.com/JKorf/CryptoExchange.Net.git</RepositoryUrl> <RepositoryUrl>https://github.com/JKorf/CryptoExchange.Net.git</RepositoryUrl>
<PackageProjectUrl>https://github.com/JKorf/CryptoExchange.Net</PackageProjectUrl> <PackageProjectUrl>https://github.com/JKorf/CryptoExchange.Net</PackageProjectUrl>
<NeutralLanguage>en</NeutralLanguage> <NeutralLanguage>en</NeutralLanguage>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild> <GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<PackageReleaseNotes>See https://github.com/JKorf/CryptoExchange.Net#release-notes</PackageReleaseNotes> <PackageReleaseNotes>5.1.0 - Improved dispose handling in SymbolOrderBook, Fixed TimeSync RecalculationInterval not being respected, Small rework client options</PackageReleaseNotes>
<Nullable>enable</Nullable> <Nullable>enable</Nullable>
<LangVersion>9.0</LangVersion> <LangVersion>9.0</LangVersion>
<PackageLicenseExpression>MIT</PackageLicenseExpression> <PackageLicenseExpression>MIT</PackageLicenseExpression>

View File

@ -259,13 +259,12 @@ namespace CryptoExchange.Net.Objects
/// ctor /// ctor
/// </summary> /// </summary>
/// <param name="baseOptions">Copy values for the provided options</param> /// <param name="baseOptions">Copy values for the provided options</param>
#pragma warning disable 8618 // Will always get filled by the provided options /// <param name="newValues">Copy values for the provided options</param>
public ApiClientOptions(ApiClientOptions baseOptions, ApiClientOptions? newValues) public ApiClientOptions(ApiClientOptions baseOptions, ApiClientOptions? newValues)
{ {
BaseAddress = newValues?.BaseAddress ?? baseOptions.BaseAddress; BaseAddress = newValues?.BaseAddress ?? baseOptions.BaseAddress;
ApiCredentials = newValues?.ApiCredentials?.Copy() ?? baseOptions.ApiCredentials?.Copy(); ApiCredentials = newValues?.ApiCredentials?.Copy() ?? baseOptions.ApiCredentials?.Copy();
} }
#pragma warning restore 8618
/// <inheritdoc /> /// <inheritdoc />
public override string ToString() public override string ToString()
@ -318,6 +317,7 @@ namespace CryptoExchange.Net.Objects
/// ctor /// ctor
/// </summary> /// </summary>
/// <param name="baseOn">Copy values for the provided options</param> /// <param name="baseOn">Copy values for the provided options</param>
/// <param name="newValues">Copy values for the provided options</param>
public RestApiClientOptions(RestApiClientOptions baseOn, RestApiClientOptions? newValues): base(baseOn, newValues) public RestApiClientOptions(RestApiClientOptions baseOn, RestApiClientOptions? newValues): base(baseOn, newValues)
{ {
RateLimitingBehaviour = newValues?.RateLimitingBehaviour ?? baseOn.RateLimitingBehaviour; RateLimitingBehaviour = newValues?.RateLimitingBehaviour ?? baseOn.RateLimitingBehaviour;

View File

@ -18,6 +18,11 @@ I develop and maintain this package on my own for free in my spare time. Donatio
Alternatively, sponsor me on Github using [Github Sponsors](https://github.com/sponsors/JKorf) Alternatively, sponsor me on Github using [Github Sponsors](https://github.com/sponsors/JKorf)
## Release notes ## Release notes
* Version 5.1.0 - 24 Feb 2022
* Improved dispose handling in SymbolOrderBook
* Fixed TimeSync RecalculationInterval not being respected
* Small rework client options
* Version 5.0.0 * Version 5.0.0
* Added Github.io page for documentation: https://jkorf.github.io/CryptoExchange.Net/ * Added Github.io page for documentation: https://jkorf.github.io/CryptoExchange.Net/
* Added single DateTimeConverter replacing the different timestamp converters * Added single DateTimeConverter replacing the different timestamp converters