wip

CryptoExchange.Net.UnitTests/CryptoExchange.Net.UnitTests.csproj

@@ -5,6 +5,10 @@
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 
+  <ItemGroup>
+    <None Include="..\CryptoExchange.Net\.editorconfig" Link=".editorconfig" />
+  </ItemGroup>
+
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1"></PackageReference>
     <PackageReference Include="Moq" Version="4.20.72" />

CryptoExchange.Net/.editorconfig

@@ -0,0 +1,182 @@
+root = true
+
+[*]
+
+# Indentation and spacing
+indent_style = space
+indent_size = 4
+trim_trailing_whitespace = true
+charset = utf-8
+insert_final_newline = true
+
+# ReSharper code style properties
+resharper_csharp_keep_existing_embedded_arrangement = false
+resharper_csharp_place_accessorholder_attribute_on_same_line = false
+resharper_csharp_wrap_after_declaration_lpar = true
+resharper_csharp_wrap_parameters_style = chop_if_long
+resharper_csharp_blank_lines_around_single_line_auto_property = 1
+resharper_csharp_keep_blank_lines_in_declarations = 1
+resharper_trailing_comma_in_multiline_lists = true
+
+[*.cs]
+
+indent_size = 4
+
+# Code style conventions
+dotnet_style_predefined_type_for_member_access = true:suggestion
+dotnet_style_collection_initializer = true:suggestion
+dotnet_style_object_initializer = true:suggestion
+csharp_style_var_when_type_is_apparent = true:suggestion
+csharp_style_expression_bodied_methods = true:suggestion
+csharp_style_namespace_declarations = file_scoped:warning
+dotnet_style_coalesce_expression = true:suggestion
+dotnet_style_null_propagation = true:suggestion
+dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion
+dotnet_style_prefer_simplified_boolean_expressions = true:suggestion
+csharp_prefer_braces = when_multiline:warning
+
+# Analyzer preferences
+dotnet_diagnostic.CA2007.severity = warning # Call ConfigureAwait on the awaited Task.
+dotnet_code_quality.CA2007.exclude_async_void_methods = true
+dotnet_code_quality.CA2007.output_kind = DynamicallyLinkedLibrary
+
+dotnet_diagnostic.CA1000.severity = none # Do not declare static members on generic types
+dotnet_diagnostic.CA1051.severity = none # Do not declare visible instance fields
+dotnet_diagnostic.CA1510.severity = none # Use ArgumentNullException throw helper
+dotnet_diagnostic.CA1720.severity = none # Identifiers should not contain type names
+dotnet_diagnostic.CA1716.severity = none # Identifiers should not match keywords
+dotnet_diagnostic.CA1835.severity = none # Use ArgumentNullException throw helper
+dotnet_diagnostic.CA1846.severity = none # Prefer AsSpan over Substring
+dotnet_diagnostic.CA1848.severity = none # Use the LoggerMessage delegates
+dotnet_diagnostic.CA1850.severity = none # Prefer static HashData method over ComputeHash
+dotnet_diagnostic.CA1866.severity = none # Use 'string.Method(char)' instead of 'string.Method(string)' for string with single char
+dotnet_diagnostic.CA2201.severity = none # Do not raise reserved exception types
+dotnet_diagnostic.CA2208.severity = none # Do not raise reserved exception types
+dotnet_diagnostic.IDE0005.severity = warning # Using directive is unnecessary
+
+[*.xml]
+ij_xml_space_inside_empty_tag = true
+[*.cs]
+#### Naming styles ####
+
+# Naming rules
+
+dotnet_naming_rule.interface_should_be_begins_with_i.severity = warning
+dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
+dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
+
+dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = warning
+dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
+dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
+
+dotnet_naming_rule.private_or_internal_field_should_be_fields_start_with__.severity = warning
+dotnet_naming_rule.private_or_internal_field_should_be_fields_start_with__.symbols = private_or_internal_field
+dotnet_naming_rule.private_or_internal_field_should_be_fields_start_with__.style = fields_start_with__
+
+# Symbol specifications
+
+dotnet_naming_symbols.interface.applicable_kinds = interface
+dotnet_naming_symbols.interface.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.interface.required_modifiers = 
+
+dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
+dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.non_field_members.required_modifiers = 
+
+dotnet_naming_symbols.private_or_internal_field.applicable_kinds = field
+dotnet_naming_symbols.private_or_internal_field.applicable_accessibilities = internal, private, private_protected
+dotnet_naming_symbols.private_or_internal_field.required_modifiers = 
+
+# Naming styles
+
+dotnet_naming_style.begins_with_i.required_prefix = I
+dotnet_naming_style.begins_with_i.required_suffix = 
+dotnet_naming_style.begins_with_i.word_separator = 
+dotnet_naming_style.begins_with_i.capitalization = pascal_case
+
+dotnet_naming_style.pascal_case.required_prefix = 
+dotnet_naming_style.pascal_case.required_suffix = 
+dotnet_naming_style.pascal_case.word_separator = 
+dotnet_naming_style.pascal_case.capitalization = pascal_case
+
+dotnet_naming_style.fields_start_with__.required_prefix = _
+dotnet_naming_style.fields_start_with__.required_suffix = 
+dotnet_naming_style.fields_start_with__.word_separator = 
+dotnet_naming_style.fields_start_with__.capitalization = camel_case
+csharp_indent_labels = one_less_than_current
+csharp_using_directive_placement = outside_namespace:suggestion
+csharp_prefer_simple_using_statement = true:suggestion
+csharp_style_prefer_method_group_conversion = true:silent
+csharp_style_prefer_top_level_statements = true:silent
+csharp_style_prefer_primary_constructors = true:suggestion
+csharp_prefer_system_threading_lock = true:suggestion
+csharp_style_expression_bodied_constructors = false:silent
+csharp_style_expression_bodied_operators = false:silent
+csharp_style_expression_bodied_properties = true:suggestion
+csharp_style_expression_bodied_indexers = true:suggestion
+csharp_style_expression_bodied_accessors = true:suggestion
+csharp_style_expression_bodied_lambdas = true:silent
+csharp_style_expression_bodied_local_functions = true:silent
+
+[*.vb]
+#### Naming styles ####
+
+# Naming rules
+
+dotnet_naming_rule.interface_should_be_begins_with_i.severity = suggestion
+dotnet_naming_rule.interface_should_be_begins_with_i.symbols = interface
+dotnet_naming_rule.interface_should_be_begins_with_i.style = begins_with_i
+
+dotnet_naming_rule.non_field_members_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.non_field_members_should_be_pascal_case.symbols = non_field_members
+dotnet_naming_rule.non_field_members_should_be_pascal_case.style = pascal_case
+
+# Symbol specifications
+
+dotnet_naming_symbols.interface.applicable_kinds = interface
+dotnet_naming_symbols.interface.applicable_accessibilities = public, friend, private, protected, protected_friend, private_protected
+dotnet_naming_symbols.interface.required_modifiers = 
+
+dotnet_naming_symbols.non_field_members.applicable_kinds = property, event, method
+dotnet_naming_symbols.non_field_members.applicable_accessibilities = public, friend, private, protected, protected_friend, private_protected
+dotnet_naming_symbols.non_field_members.required_modifiers = 
+
+# Naming styles
+
+dotnet_naming_style.begins_with_i.required_prefix = I
+dotnet_naming_style.begins_with_i.required_suffix = 
+dotnet_naming_style.begins_with_i.word_separator = 
+dotnet_naming_style.begins_with_i.capitalization = pascal_case
+
+dotnet_naming_style.pascal_case.required_prefix = 
+dotnet_naming_style.pascal_case.required_suffix = 
+dotnet_naming_style.pascal_case.word_separator = 
+dotnet_naming_style.pascal_case.capitalization = pascal_case
+
+[*.{cs,vb}]
+#### Naming styles ####
+
+# Naming rules
+
+dotnet_naming_rule.types_should_be_pascal_case.severity = suggestion
+dotnet_naming_rule.types_should_be_pascal_case.symbols = types
+dotnet_naming_rule.types_should_be_pascal_case.style = pascal_case
+
+# Symbol specifications
+
+dotnet_naming_symbols.types.applicable_kinds = class, struct, interface, enum
+dotnet_naming_symbols.types.applicable_accessibilities = public, internal, private, protected, protected_internal, private_protected
+dotnet_naming_symbols.types.required_modifiers = 
+
+# Naming styles
+
+dotnet_naming_style.pascal_case.required_prefix = 
+dotnet_naming_style.pascal_case.required_suffix = 
+dotnet_naming_style.pascal_case.word_separator = 
+dotnet_naming_style.pascal_case.capitalization = pascal_case
+dotnet_style_operator_placement_when_wrapping = beginning_of_line
+tab_width = 4
+end_of_line = crlf
+dotnet_style_coalesce_expression = true:suggestion
+dotnet_style_null_propagation = true:suggestion
+dotnet_style_prefer_is_null_check_over_reference_equality_method = true:suggestion

CryptoExchange.Net/AssemblyInfo.cs

@@ -1,6 +1,5 @@
-[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("CryptoExchange.Net.UnitTests")]
+[assembly: System.Runtime.CompilerServices.InternalsVisibleTo("CryptoExchange.Net.UnitTests")]
+
+namespace System.Runtime.CompilerServices;
 
-namespace System.Runtime.CompilerServices
-{
 internal static class IsExternalInit { }
-}

CryptoExchange.Net/Attributes/JsonConversionAttribute.cs

@@ -1,7 +1,7 @@
-using System;
+using System;
+
+namespace CryptoExchange.Net.Attributes;
 
-namespace CryptoExchange.Net.Attributes
-{
 /// <summary>
 /// Used for conversion in ArrayConverter
 /// </summary>
@@ -9,4 +9,3 @@ namespace CryptoExchange.Net.Attributes
 public class JsonConversionAttribute: Attribute
 {
 }
-}

CryptoExchange.Net/Attributes/MapAttribute.cs

@@ -1,7 +1,7 @@
-using System;
+using System;
+
+namespace CryptoExchange.Net.Attributes;
 
-namespace CryptoExchange.Net.Attributes
-{
 /// <summary>
 /// Map a enum entry to string values
 /// </summary>
@@ -22,4 +22,3 @@ namespace CryptoExchange.Net.Attributes
         Values = maps;
     }
 }
-}

CryptoExchange.Net/Authentication/ApiCredentials.cs

@@ -1,10 +1,7 @@
-using System;
+using System;
-using System.IO;
+
-using CryptoExchange.Net.Converters.SystemTextJson;
+namespace CryptoExchange.Net.Authentication;
-using CryptoExchange.Net.Converters.MessageParsing;
 
-namespace CryptoExchange.Net.Authentication
-{
 /// <summary>
 /// Api credentials, used to sign requests accessing private endpoints
 /// </summary>
@@ -57,4 +54,3 @@ namespace CryptoExchange.Net.Authentication
         return new ApiCredentials(Key, Secret, Pass, CredentialType);
     }
 }
-}

CryptoExchange.Net/Authentication/ApiCredentialsType.cs

@@ -1,5 +1,5 @@
-namespace CryptoExchange.Net.Authentication
+namespace CryptoExchange.Net.Authentication;
-{
+
 /// <summary>
 /// Credentials type
 /// </summary>
@@ -18,4 +18,3 @@
     /// </summary>
     RsaPem
 }
-}

CryptoExchange.Net/Authentication/AuthenticationProvider.cs

@@ -1,16 +1,15 @@
-using CryptoExchange.Net.Clients;
+using CryptoExchange.Net.Clients;
 using CryptoExchange.Net.Converters.SystemTextJson;
 using CryptoExchange.Net.Interfaces;
 using CryptoExchange.Net.Objects;
 using System;
 using System.Collections.Generic;
 using System.Globalization;
-using System.Net.Http;
 using System.Security.Cryptography;
 using System.Text;
 
-namespace CryptoExchange.Net.Authentication
+namespace CryptoExchange.Net.Authentication;
-{
+
 /// <summary>
 /// Base class for authentication providers
 /// </summary>
@@ -209,7 +208,9 @@ namespace CryptoExchange.Net.Authentication
     /// <returns></returns>
     protected static string SignMD5(string data, SignOutputType? outputType = null)
     {
+#pragma warning disable CA5351
         using var encryptor = MD5.Create();
+#pragma warning restore CA5351
         var resultBytes = encryptor.ComputeHash(Encoding.UTF8.GetBytes(data));
         return outputType == SignOutputType.Base64 ? BytesToBase64String(resultBytes) : BytesToHexString(resultBytes);
     }
@@ -222,7 +223,9 @@ namespace CryptoExchange.Net.Authentication
     /// <returns></returns>
     protected static string SignMD5(byte[] data, SignOutputType? outputType = null)
     {
+#pragma warning disable CA5351
         using var encryptor = MD5.Create();
+#pragma warning restore CA5351
         var resultBytes = encryptor.ComputeHash(data);
         return outputType == SignOutputType.Base64 ? BytesToBase64String(resultBytes) : BytesToHexString(resultBytes);
     }
@@ -234,7 +237,9 @@ namespace CryptoExchange.Net.Authentication
     /// <returns></returns>
     protected static byte[] SignMD5Bytes(string data)
     {
+#pragma warning disable CA5351
         using var encryptor = MD5.Create();
+#pragma warning restore CA5351
         return encryptor.ComputeHash(Encoding.UTF8.GetBytes(data));
     }
 
@@ -470,4 +475,3 @@ namespace CryptoExchange.Net.Authentication
     {
     }
 }
-}

CryptoExchange.Net/Authentication/SignOutputType.cs

@@ -1,5 +1,5 @@
-namespace CryptoExchange.Net.Authentication
+namespace CryptoExchange.Net.Authentication;
-{
+
 /// <summary>
 /// Output string type
 /// </summary>
@@ -14,4 +14,3 @@
     /// </summary>
     Base64
 }
-}

CryptoExchange.Net/Caching/MemoryCache.cs

@@ -1,9 +1,9 @@
-using System;
+using System;
 using System.Collections.Concurrent;
 using System.Linq;
 
-namespace CryptoExchange.Net.Caching
+namespace CryptoExchange.Net.Caching;
-{
+
 internal class MemoryCache
 {
     private readonly ConcurrentDictionary<string, CacheItem> _cache = new ConcurrentDictionary<string, CacheItem>();
@@ -50,4 +50,3 @@ namespace CryptoExchange.Net.Caching
         }
     }
 }
-}

CryptoExchange.Net/Clients/BaseApiClient.cs

@@ -1,15 +1,13 @@
 using System;
-using System.Collections.Generic;
 using CryptoExchange.Net.Authentication;
 using CryptoExchange.Net.Interfaces;
-using CryptoExchange.Net.Objects;
 using CryptoExchange.Net.Objects.Errors;
 using CryptoExchange.Net.Objects.Options;
 using CryptoExchange.Net.SharedApis;
 using Microsoft.Extensions.Logging;
 
-namespace CryptoExchange.Net.Clients
+namespace CryptoExchange.Net.Clients;
-{
+
 /// <summary>
 /// Base API for all API clients
 /// </summary>
@@ -131,4 +129,3 @@ namespace CryptoExchange.Net.Clients
         _disposing = true;
     }
 }
-}

CryptoExchange.Net/Clients/BaseClient.cs

@@ -1,12 +1,11 @@
-using CryptoExchange.Net.Authentication;
+using CryptoExchange.Net.Authentication;
 using CryptoExchange.Net.Objects.Options;
 using Microsoft.Extensions.Logging;
-using Microsoft.Extensions.Logging.Abstractions;
 using System;
 using System.Collections.Generic;
 
-namespace CryptoExchange.Net.Clients
+namespace CryptoExchange.Net.Clients;
-{
+
 /// <summary>
 /// The base for all clients, websocket client and rest client
 /// </summary>
@@ -80,7 +79,7 @@ namespace CryptoExchange.Net.Clients
             throw new ArgumentNullException(nameof(options));
 
         ClientOptions = options;
-            _logger.Log(LogLevel.Trace, $"Client configuration: {options}, CryptoExchange.Net: v{CryptoExchangeLibVersion}, {Exchange}.Net: v{ExchangeLibVersion}");
+        _logger.Log(LogLevel.Trace, "Client configuration: {Options}, CryptoExchange.Net: v{CryptoExchangeVersion}, {Exchange}.Net: v{ExchangeVersion}", options, CryptoExchangeLibVersion, Exchange, ExchangeLibVersion);
     }
 
     /// <summary>
@@ -102,7 +101,7 @@ namespace CryptoExchange.Net.Clients
         if (ClientOptions == null)
             throw new InvalidOperationException("Client should have called Initialize before adding API clients");
 
-            _logger.Log(LogLevel.Trace, $"  {apiClient.GetType().Name}, base address: {apiClient.BaseAddress}");
+        _logger.Log(LogLevel.Trace, "  {ApiClient}, base address: {BaseAddress}", apiClient.GetType().Name, apiClient.BaseAddress);
         ApiClients.Add(apiClient);
         return apiClient;
     }
@@ -127,4 +126,3 @@ namespace CryptoExchange.Net.Clients
             client.Dispose();
     }
 }
-}

CryptoExchange.Net/Clients/BaseRestClient.cs

@@ -3,8 +3,8 @@ using CryptoExchange.Net.Interfaces;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Logging.Abstractions;
 
-namespace CryptoExchange.Net.Clients
+namespace CryptoExchange.Net.Clients;
-{
+
 /// <summary>
 /// Base rest client
 /// </summary>
@@ -23,4 +23,3 @@ namespace CryptoExchange.Net.Clients
         _logger = loggerFactory?.CreateLogger(name + ".RestClient") ?? NullLoggerFactory.Instance.CreateLogger(name);
     }
 }
-}

CryptoExchange.Net/Clients/BaseSocketClient.cs

@@ -1,17 +1,16 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Text;
 using System.Threading.Tasks;
-using System.Xml.Linq;
 using CryptoExchange.Net.Interfaces;
 using CryptoExchange.Net.Logging.Extensions;
 using CryptoExchange.Net.Objects.Sockets;
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Logging.Abstractions;
 
-namespace CryptoExchange.Net.Clients
+namespace CryptoExchange.Net.Clients;
-{
+
 /// <summary>
 /// Base for socket client implementations
 /// </summary>
@@ -129,4 +128,3 @@ namespace CryptoExchange.Net.Clients
         return result;
     }
 }
-}

CryptoExchange.Net/Clients/CryptoBaseClient.cs

@@ -1,9 +1,9 @@
-using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.DependencyInjection;
 using System;
 using System.Collections.Generic;
 
-namespace CryptoExchange.Net.Clients
+namespace CryptoExchange.Net.Clients;
-{
+
 /// <summary>
 /// Base crypto client
 /// </summary>
@@ -64,4 +64,3 @@ namespace CryptoExchange.Net.Clients
         _serviceCache.Clear();
     }
 }
-}

CryptoExchange.Net/Clients/CryptoRestClient.cs

@@ -1,11 +1,8 @@
-using CryptoExchange.Net.Interfaces;
+using CryptoExchange.Net.Interfaces;
-using Microsoft.Extensions.DependencyInjection;
 using System;
-using System.Collections.Generic;
-using System.Linq;
 
-namespace CryptoExchange.Net.Clients
+namespace CryptoExchange.Net.Clients;
-{
+
 /// <inheritdoc />
 public class CryptoRestClient : CryptoBaseClient, ICryptoRestClient
 {
@@ -24,4 +21,3 @@ namespace CryptoExchange.Net.Clients
     {
     }
 }
-}

CryptoExchange.Net/Clients/CryptoSocketClient.cs

@@ -1,8 +1,8 @@
-using CryptoExchange.Net.Interfaces;
+using CryptoExchange.Net.Interfaces;
 using System;
 
-namespace CryptoExchange.Net.Clients
+namespace CryptoExchange.Net.Clients;
-{
+
 /// <inheritdoc />
 public class CryptoSocketClient : CryptoBaseClient, ICryptoSocketClient
 {
@@ -21,4 +21,3 @@ namespace CryptoExchange.Net.Clients
     {
     }
 }
-}

CryptoExchange.Net/Clients/RestApiClient.cs

@@ -18,8 +18,8 @@ using CryptoExchange.Net.RateLimiting.Interfaces;
 using CryptoExchange.Net.Requests;
 using Microsoft.Extensions.Logging;
 
-namespace CryptoExchange.Net.Clients
+namespace CryptoExchange.Net.Clients;
-{
+
 /// <summary>
 /// Base rest API client for interacting with a REST API
 /// </summary>
@@ -722,4 +722,3 @@ namespace CryptoExchange.Net.Clients
         && definition.Method == HttpMethod.Get
         && !definition.PreventCaching;
 }
-}

CryptoExchange.Net/Clients/SocketApiClient.cs

@@ -17,8 +17,8 @@ using System.Text;
 using System.Threading;
 using System.Threading.Tasks;
 
-namespace CryptoExchange.Net.Clients
+namespace CryptoExchange.Net.Clients;
-{
+
 /// <summary>
 /// Base socket API client for interaction with a websocket API
 /// </summary>
@@ -86,7 +86,7 @@ namespace CryptoExchange.Net.Clients
     /// <summary>
     /// Whether to continue processing and forward unparsable messages to handlers
     /// </summary>
-        protected internal bool ProcessUnparsableMessages { get; set; } = false;
+    protected internal bool ProcessUnparsableMessages { get; set; }
 
     /// <inheritdoc />
     public double IncomingKbps
@@ -340,7 +340,13 @@ namespace CryptoExchange.Net.Clients
 
         SocketConnection socketConnection;
         var released = false;
-            await semaphoreSlim.WaitAsync().ConfigureAwait(false);
+
+        try
+        {
+            await semaphoreSlim.WaitAsync(ct).ConfigureAwait(false);
+        }
+        catch (OperationCanceledException) { }
+
         try
         {
             var socketResult = await GetSocketConnection(url, query.Authenticated, true).ConfigureAwait(false);
@@ -395,7 +401,13 @@ namespace CryptoExchange.Net.Clients
             return connectResult;
 
         if (ClientOptions.DelayAfterConnect != TimeSpan.Zero)
-                await Task.Delay(ClientOptions.DelayAfterConnect).ConfigureAwait(false);
+        {
+            try
+            {
+                await Task.Delay(ClientOptions.DelayAfterConnect, ct).ConfigureAwait(false);
+            }
+            catch (OperationCanceledException) { }
+        }
 
         if (!authenticated || socket.Authenticated)
             return CallResult.SuccessResult;
@@ -862,4 +874,3 @@ namespace CryptoExchange.Net.Clients
     /// <returns></returns>
     public virtual ReadOnlyMemory<byte> PreprocessStreamMessage(SocketConnection connection, WebSocketMessageType type, ReadOnlyMemory<byte> data) => data;
 }
-}

CryptoExchange.Net/Converters/ArrayPropertyAttribute.cs

@@ -1,7 +1,7 @@
-using System;
+using System;
+
+namespace CryptoExchange.Net.Converters;
 
-namespace CryptoExchange.Net.Converters
-{
 /// <summary>
 /// Mark property as an index in the array
 /// </summary>
@@ -22,4 +22,3 @@ namespace CryptoExchange.Net.Converters
         Index = index;
     }
 }
-}

CryptoExchange.Net/Converters/JsonSerializerContextCache.cs

@@ -1,11 +1,9 @@
-using System;
+using System;
 using System.Collections.Concurrent;
-using System.Collections.Generic;
-using System.Text;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters
+namespace CryptoExchange.Net.Converters;
-{
+
 /// <summary>
 /// Caching for JsonSerializerContext instances
 /// </summary>
@@ -28,4 +26,3 @@ namespace CryptoExchange.Net.Converters
         return instance;
     }
 }
-}

CryptoExchange.Net/Converters/MessageParsing/MessageNode.cs

@@ -1,5 +1,5 @@
-namespace CryptoExchange.Net.Converters.MessageParsing
+namespace CryptoExchange.Net.Converters.MessageParsing;
-{
+
 /// <summary>
 /// Node accessor
 /// </summary>
@@ -46,4 +46,3 @@
     /// <returns></returns>
     public static NodeAccessor PropertyName() { return new NodeAccessor(null, null, 2); }
 }
-}

CryptoExchange.Net/Converters/MessageParsing/MessagePath.cs

@@ -1,8 +1,8 @@
-using System.Collections;
+using System.Collections;
 using System.Collections.Generic;
 
-namespace CryptoExchange.Net.Converters.MessageParsing
+namespace CryptoExchange.Net.Converters.MessageParsing;
-{
+
 /// <summary>
 /// Message access definition
 /// </summary>
@@ -47,4 +47,3 @@ namespace CryptoExchange.Net.Converters.MessageParsing
         return GetEnumerator();
     }
 }
-}

CryptoExchange.Net/Converters/MessageParsing/MessagePathExtension.cs

@@ -1,5 +1,5 @@
-namespace CryptoExchange.Net.Converters.MessageParsing
+namespace CryptoExchange.Net.Converters.MessageParsing;
-{
+
 /// <summary>
 /// Message path extension methods
 /// </summary>
@@ -40,4 +40,3 @@
         return path;
     }
 }
-}

CryptoExchange.Net/Converters/MessageParsing/NodeType.cs

@@ -1,5 +1,5 @@
-namespace CryptoExchange.Net.Converters.MessageParsing
+namespace CryptoExchange.Net.Converters.MessageParsing;
-{
+
 /// <summary>
 /// Message node type
 /// </summary>
@@ -18,4 +18,3 @@
     /// </summary>
     Value
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/ArrayConverter.cs

@@ -1,18 +1,17 @@
-using System;
+using System;
-using System.Collections.Concurrent;
 using System.Globalization;
 using System.Linq;
 using System.Reflection;
 using System.Text.Json.Serialization;
 using System.Text.Json;
-using CryptoExchange.Net.Attributes;
 using System.Collections.Generic;
+#if NET5_0_OR_GREATER
 using System.Diagnostics.CodeAnalysis;
+#endif
 using System.Threading;
-using System.Diagnostics;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 /// <summary>
 /// Converter for arrays to objects. Can deserialize data like [0.1, 0.2, "test"] to an object. Mapping is done by marking the class with [JsonConverter(typeof(ArrayConverter))] and the properties
 /// with [ArrayProperty(x)] where x is the index of the property in the array
@@ -228,7 +227,6 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
         public JsonConverter? JsonConverter { get; set; }
         public bool DefaultDeserialization { get; set; }
         public Type TargetType { get; set; } = null!;
-            public JsonSerializerOptions? JsonSerializerOptions { get; set; } = null;
+        public JsonSerializerOptions? JsonSerializerOptions { get; set; }
-        }
     }
 }

CryptoExchange.Net/Converters/SystemTextJson/BigDecimalConverter.cs

@@ -1,10 +1,10 @@
-using System;
+using System;
 using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 /// <summary>
 /// Decimal converter that handles overflowing decimal values (by setting it to decimal.MaxValue)
 /// </summary>
@@ -43,4 +43,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
         writer.WriteNumberValue(value);
     }
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/BoolConverter.cs

@@ -1,11 +1,11 @@
-using System;
+using System;
 using System.Diagnostics;
 using System.Runtime.Serialization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 /// <summary>
 /// Bool converter
 /// </summary>
@@ -28,7 +28,7 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
         public override T Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
             => (T)((object?)ReadBool(ref reader, typeToConvert, options) ?? default(T))!;
         
-            public bool? ReadBool(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
+        public static bool? ReadBool(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
         {
             if (reader.TokenType == JsonTokenType.True)
                 return true;
@@ -81,4 +81,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
     }
 
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/CommaSplitEnumConverter.cs

@@ -1,13 +1,13 @@
-using System;
+using System;
-using System.Collections.Generic;
+#if NET5_0_OR_GREATER
 using System.Diagnostics.CodeAnalysis;
+#endif
 using System.Linq;
-using System.Text;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 /// <summary>
 /// Converter for comma separated enum values
 /// </summary>
@@ -34,4 +34,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
         writer.WriteStringValue(string.Join(",", value.Select(x => EnumConverter.GetString(x))));
     }
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/DateTimeConverter.cs

@@ -1,12 +1,12 @@
-using System;
+using System;
 using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 /// <summary>
 /// Date time converter
 /// </summary>
@@ -34,7 +34,7 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
         public override T Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
             => (T)((object?)ReadDateTime(ref reader, typeToConvert, options) ?? default(T))!;
 
-            private DateTime? ReadDateTime(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
+        private static DateTime? ReadDateTime(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
         {
             if (reader.TokenType == JsonTokenType.Null)
             {
@@ -239,4 +239,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
     [return: NotNullIfNotNull("time")]
     public static long? ConvertToNanoseconds(DateTime? time) => time == null ? null : (long)Math.Round((time.Value - _epoch).Ticks / _ticksPerNanosecond);
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/DecimalConverter.cs

@@ -1,10 +1,9 @@
-using System;
+using System;
-using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 /// <summary>
 /// Decimal converter
 /// </summary>
@@ -42,4 +41,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
             writer.WriteNumberValue(value.Value);
     }
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/DecimalStringWriterConverter.cs

@@ -1,10 +1,10 @@
-using System;
+using System;
 using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 /// <summary>
 /// Converter for serializing decimal values as string
 /// </summary>
@@ -20,4 +20,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
     public override void Write(Utf8JsonWriter writer, decimal value, JsonSerializerOptions options)
         => writer.WriteStringValue(value.ToString(CultureInfo.InvariantCulture) ?? null);
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/EnumConverter.cs

@@ -1,4 +1,4 @@
-using CryptoExchange.Net.Attributes;
+using CryptoExchange.Net.Attributes;
 using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;
@@ -9,8 +9,8 @@ using System.Reflection;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 /// <summary>
 /// Static EnumConverter methods
 /// </summary>
@@ -64,8 +64,8 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
 #endif
      : JsonConverter<T>, INullableConverterFactory where T : struct, Enum
 {
-        private static List<KeyValuePair<T, string>>? _mapping = null;
+    private static List<KeyValuePair<T, string>>? _mapping;
-        private NullableEnumConverter? _nullableEnumConverter = null;
+    private NullableEnumConverter? _nullableEnumConverter;
 
     private static ConcurrentBag<string> _unknownValuesWarned = new ConcurrentBag<string>();
 
@@ -79,7 +79,7 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
         }
         public override T? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
         {
-                return _enumConverter.ReadNullable(ref reader, typeToConvert, options, out var isEmptyString, out var warn);
+            return EnumConverter<T>.ReadNullable(ref reader, typeToConvert, options, out var isEmptyString, out var warn);
         }
 
         public override void Write(Utf8JsonWriter writer, T? value, JsonSerializerOptions options)
@@ -122,7 +122,7 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
         }
     }
 
-        private T? ReadNullable(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options, out bool isEmptyString, out bool warn)
+    private static T? ReadNullable(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options, out bool isEmptyString, out bool warn)
     {
         isEmptyString = false;
         warn = false;
@@ -286,4 +286,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
         return _nullableEnumConverter;
     }
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/EnumIntWriterConverter.cs

@@ -1,10 +1,9 @@
-using System;
+using System;
-using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 /// <summary>
 /// Converter for serializing enum values as int
 /// </summary>
@@ -20,4 +19,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
     public override void Write(Utf8JsonWriter writer, T value, JsonSerializerOptions options)
         => writer.WriteNumberValue((int)(object)value);
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/INullableConverterFactory.cs

@@ -1,9 +1,8 @@
-using System.Text.Json.Serialization;
+using System.Text.Json.Serialization;
+
+namespace CryptoExchange.Net.Converters.SystemTextJson;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
-{
 internal interface INullableConverterFactory
 {
     JsonConverter CreateNullableConverter();
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/IntConverter.cs

@@ -1,10 +1,10 @@
-using System;
+using System;
 using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 /// <summary>
 /// Int converter
 /// </summary>
@@ -37,4 +37,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
             writer.WriteNumberValue(value.Value);
     }
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/LongConverter.cs

@@ -1,10 +1,10 @@
-using System;
+using System;
 using System.Globalization;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 /// <summary>
 /// Int converter
 /// </summary>
@@ -37,4 +37,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
             writer.WriteNumberValue(value.Value);
     }
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/NullableEnumConverterFactory.cs

@@ -1,12 +1,10 @@
-using System;
+using System;
-using System.Collections.Generic;
-using System.Text;
 using System.Text.Json.Serialization.Metadata;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 internal class NullableEnumConverterFactory : JsonConverterFactory
 {
     private readonly IJsonTypeInfoResolver _jsonTypeInfoResolver;
@@ -40,4 +38,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
         return nullConverterFactory.CreateNullableConverter();
     }
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/NumberStringConverter.cs

@@ -1,9 +1,9 @@
-using System;
+using System;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 /// <summary>
 /// Read string or number as string
 /// </summary>
@@ -39,4 +39,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
         writer.WriteStringValue(value);
     }
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/ObjectStringConverter.cs

@@ -1,10 +1,12 @@
-using System;
+using System;
 using System.Text.Json.Serialization;
 using System.Text.Json;
+#if NET5_0_OR_GREATER
 using System.Diagnostics.CodeAnalysis;
+#endif
+
+namespace CryptoExchange.Net.Converters.SystemTextJson;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
-{
 /// <summary>
 /// Converter for values which contain a nested json value
 /// </summary>
@@ -24,7 +26,7 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
         if (string.IsNullOrEmpty(value))
             return default;
 
-            return (T?)JsonDocument.Parse(value!).Deserialize(typeof(T), options);
+        return JsonDocument.Parse(value!).Deserialize<T>(options);
     }
 
     /// <inheritdoc />
@@ -40,4 +42,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
         writer.WriteStringValue(JsonSerializer.Serialize(value, options));
     }
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/ReplaceConverter.cs

@@ -1,10 +1,10 @@
-using System;
+using System;
 using System.Linq;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 /// <summary>
 /// Replace a value on a string property
 /// </summary>
@@ -19,7 +19,7 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
     {
         _replacementSets = replaceSets.Select(x =>
         {
-                var split = x.Split(new string[] { "->" }, StringSplitOptions.None);
+            var split = x.Split(["->"], StringSplitOptions.None);
             if (split.Length != 2)
                 throw new ArgumentException("Invalid replacement config");
             return (split[0], split[1]);
@@ -38,4 +38,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
     /// <inheritdoc />
     public override void Write(Utf8JsonWriter writer, string value, JsonSerializerOptions options) => writer.WriteStringValue(value);
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/SerializationModel.cs

@@ -1,9 +1,7 @@
-using System;
+using System;
-using System.Collections.Generic;
+
-using System.Text;
+namespace CryptoExchange.Net.Converters.SystemTextJson;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
-{
 /// <summary>
 /// Attribute to mark a model as json serializable. Used for AOT compilation.
 /// </summary>
@@ -20,4 +18,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
     /// <param name="type"></param>
     public SerializationModelAttribute(Type type) { }
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/SerializerOptions.cs

@@ -1,9 +1,9 @@
-using System.Collections.Concurrent;
+using System.Collections.Concurrent;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 /// <summary>
 /// Serializer options
 /// </summary>
@@ -44,4 +44,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
         return options;
     }
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/SharedQuantityConverter.cs

@@ -1,12 +1,10 @@
-using CryptoExchange.Net.SharedApis;
+using CryptoExchange.Net.SharedApis;
 using System;
-using System.Collections.Generic;
-using System.Text;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 internal class SharedQuantityConverter : SharedQuantityReferenceConverter<SharedQuantity> { }
 internal class SharedOrderQuantityConverter : SharedQuantityReferenceConverter<SharedOrderQuantity> { }
 
@@ -57,4 +55,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
         writer.WriteEndArray();
     }
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/SharedSymbolConverter.cs

@@ -1,12 +1,10 @@
-using CryptoExchange.Net.SharedApis;
+using CryptoExchange.Net.SharedApis;
 using System;
-using System.Collections.Generic;
-using System.Text;
 using System.Text.Json;
 using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 internal class SharedSymbolConverter : JsonConverter<SharedSymbol>
 {
     public override SharedSymbol? Read(ref Utf8JsonReader reader, Type typeToConvert, JsonSerializerOptions options)
@@ -43,4 +41,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
         writer.WriteEndArray();
     }
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/SystemTextJsonMessageAccessor.cs

@@ -1,16 +1,17 @@
-using CryptoExchange.Net.Converters.MessageParsing;
+using CryptoExchange.Net.Converters.MessageParsing;
 using CryptoExchange.Net.Interfaces;
 using CryptoExchange.Net.Objects;
 using System;
-using System.Collections.Generic;
+#if NET5_0_OR_GREATER
 using System.Diagnostics.CodeAnalysis;
+#endif
 using System.IO;
 using System.Text;
 using System.Text.Json;
 using System.Threading.Tasks;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 /// <summary>
 /// System.Text.Json message accessor
 /// </summary>
@@ -240,7 +241,9 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
 /// <summary>
 /// System.Text.Json stream message accessor
 /// </summary>
+#pragma warning disable CA1001 // Types that own disposable fields should be disposable
 public class SystemTextJsonStreamMessageAccessor : SystemTextJsonMessageAccessor, IStreamMessageAccessor
+#pragma warning restore CA1001 // Types that own disposable fields should be disposable
 {
     private Stream? _stream;
 
@@ -371,4 +374,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
         _document = null;
     }
 }
-}

CryptoExchange.Net/Converters/SystemTextJson/SystemTextJsonMessageSerializer.cs

@@ -1,11 +1,11 @@
-using CryptoExchange.Net.Interfaces;
+using CryptoExchange.Net.Interfaces;
+#if NET5_0_OR_GREATER
 using System.Diagnostics.CodeAnalysis;
+#endif
 using System.Text.Json;
-using System.Text.Json.Serialization;
-using System.Text.Json.Serialization.Metadata;
 
-namespace CryptoExchange.Net.Converters.SystemTextJson
+namespace CryptoExchange.Net.Converters.SystemTextJson;
-{
+
 /// <inheritdoc />
 public class SystemTextJsonMessageSerializer : IStringMessageSerializer
 {
@@ -26,4 +26,3 @@ namespace CryptoExchange.Net.Converters.SystemTextJson
 #endif
     public string Serialize<T>(T message) => JsonSerializer.Serialize(message, _options);
 }
-}

CryptoExchange.Net/CryptoExchange.Net.csproj

@@ -24,6 +24,7 @@
     <PackageLicenseExpression>MIT</PackageLicenseExpression>
   </PropertyGroup>
   <ItemGroup>
+    <None Include="C:\Projects\CryptoExchange.Net\CryptoExchange.Net\.editorconfig" />
     <None Include="Icon\icon.png" Pack="true" PackagePath="\" />
     <None Include="..\README.md" Pack="true" PackagePath="\" />
   </ItemGroup>
@@ -40,6 +41,12 @@
   <PropertyGroup>
     <DocumentationFile>CryptoExchange.Net.xml</DocumentationFile>
   </PropertyGroup>
+  <PropertyGroup>
+    <EnableNETAnalyzers>true</EnableNETAnalyzers>
+    <AnalysisMode>Recommended</AnalysisMode>
+    <AnalysisModeGlobalization>None</AnalysisModeGlobalization>
+    <EnforceCodeStyleInBuild>true</EnforceCodeStyleInBuild>
+  </PropertyGroup>
   <ItemGroup>
     <PackageReference Include="ConfigureAwaitChecker.Analyzer" Version="5.0.0.1">
       <PrivateAssets>all</PrivateAssets>
@@ -58,4 +65,7 @@
     <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="9.0.6" />
     <PackageReference Include="Microsoft.Extensions.Http" Version="9.0.6" />
   </ItemGroup>
+  <ItemGroup>
+    <EditorConfigFiles Remove="C:\Projects\CryptoExchange.Net\CryptoExchange.Net\.editorconfig" />
+  </ItemGroup>
 </Project>

CryptoExchange.Net/ExchangeHelpers.cs

@@ -1,15 +1,17 @@
-using CryptoExchange.Net.Objects;
+using CryptoExchange.Net.Objects;
 using CryptoExchange.Net.SharedApis;
 using System;
 using System.Collections.Generic;
 using System.Globalization;
 using System.Runtime.CompilerServices;
+#if NETSTANDARD2_1_OR_GREATER || NET9_0_OR_GREATER
 using System.Security.Cryptography;
+#endif
 using System.Threading;
 using System.Threading.Tasks;
 
-namespace CryptoExchange.Net
+namespace CryptoExchange.Net;
-{
+
 /// <summary>
 /// General helpers functions
 /// </summary>
@@ -287,16 +289,16 @@ namespace CryptoExchange.Net
     /// <summary>
     /// Execute multiple requests to retrieve multiple pages of the result set
     /// </summary>
-        /// <typeparam name="T">Type of the client</typeparam>
+    /// <typeparam name="TResult">Type of the client</typeparam>
-        /// <typeparam name="U">Type of the request</typeparam>
+    /// <typeparam name="TRequest">Type of the request</typeparam>
     /// <param name="paginatedFunc">The func to execute with each request</param>
     /// <param name="request">The request parameters</param>
     /// <param name="ct">Cancellation token</param>
     /// <returns></returns>
-        public static async IAsyncEnumerable<ExchangeWebResult<T[]>> ExecutePages<T, U>(Func<U, INextPageToken?, CancellationToken, Task<ExchangeWebResult<T[]>>> paginatedFunc, U request, [EnumeratorCancellation]CancellationToken ct = default)
+    public static async IAsyncEnumerable<ExchangeWebResult<TResult[]>> ExecutePages<TResult, TRequest>(Func<TRequest, INextPageToken?, CancellationToken, Task<ExchangeWebResult<TResult[]>>> paginatedFunc, TRequest request, [EnumeratorCancellation]CancellationToken ct = default)
     {
-            var result = new List<T>();
+        var result = new List<TResult>();
-            ExchangeWebResult<T[]> batch;
+        ExchangeWebResult<TResult[]> batch;
         INextPageToken? nextPageToken = null;
         while (true)
         {
@@ -386,4 +388,3 @@ namespace CryptoExchange.Net
         return null;
     }
 }
-}

CryptoExchange.Net/ExchangeSymbolCache.cs

@@ -1,12 +1,11 @@
-using CryptoExchange.Net.SharedApis;
+using CryptoExchange.Net.SharedApis;
 using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;
 using System.Linq;
-using System.Text;
 
-namespace CryptoExchange.Net
+namespace CryptoExchange.Net;
-{
+
 /// <summary>
 /// Cache for symbol parsing
 /// </summary>
@@ -67,4 +66,3 @@ namespace CryptoExchange.Net
         }
     }
 }
-}

CryptoExchange.Net/ExtensionMethods.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.IO.Compression;
 using System.IO;
@@ -10,12 +10,9 @@ using CryptoExchange.Net.Objects;
 using System.Globalization;
 using Microsoft.Extensions.DependencyInjection;
 using CryptoExchange.Net.SharedApis;
-using System.Text.Json.Serialization.Metadata;
-using System.Text.Json;
-using System.Text.Json.Serialization;
 
-namespace CryptoExchange.Net
+namespace CryptoExchange.Net;
-{
+
 /// <summary>
 /// Helper methods
 /// </summary>
@@ -520,5 +517,4 @@ namespace CryptoExchange.Net
         return services;
     }
 }
-}
 

CryptoExchange.Net/Interfaces/IAuthTimeProvider.cs

@@ -1,7 +1,7 @@
-using System;
+using System;
+
+namespace CryptoExchange.Net.Interfaces;
 
-namespace CryptoExchange.Net.Interfaces
-{
 /// <summary>
 /// Time provider
 /// </summary>
@@ -13,4 +13,3 @@ namespace CryptoExchange.Net.Interfaces
     /// <returns></returns>
     DateTime GetTime();
 }
-}

CryptoExchange.Net/Interfaces/IBaseApiClient.cs

@@ -1,11 +1,10 @@
-using CryptoExchange.Net.Authentication;
+using CryptoExchange.Net.Authentication;
-using CryptoExchange.Net.Objects;
 using CryptoExchange.Net.Objects.Options;
 using CryptoExchange.Net.SharedApis;
 using System;
 
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// Base api client
 /// </summary>
@@ -45,4 +44,3 @@ namespace CryptoExchange.Net.Interfaces
     /// <param name="options">Options to set</param>
     void SetOptions<T>(UpdateOptions<T> options) where T : ApiCredentials;
 }
-}

CryptoExchange.Net/Interfaces/ICryptoRestClient.cs

@@ -1,7 +1,7 @@
-using System;
+using System;
+
+namespace CryptoExchange.Net.Interfaces;
 
-namespace CryptoExchange.Net.Interfaces
-{
 /// <summary>
 /// Client for accessing REST API's for different exchanges
 /// </summary>
@@ -14,4 +14,3 @@ namespace CryptoExchange.Net.Interfaces
     /// <returns></returns>
     T TryGet<T>(Func<T> createFunc);
 }
-}

CryptoExchange.Net/Interfaces/ICryptoSocketClient.cs

@@ -1,7 +1,7 @@
-using System;
+using System;
+
+namespace CryptoExchange.Net.Interfaces;
 
-namespace CryptoExchange.Net.Interfaces
-{
 /// <summary>
 /// Client for accessing Websocket API's for different exchanges
 /// </summary>
@@ -14,4 +14,3 @@ namespace CryptoExchange.Net.Interfaces
     /// <returns></returns>
     T TryGet<T>(Func<T> createFunc);
 }
-}

CryptoExchange.Net/Interfaces/IMessageAccessor.cs

@@ -1,13 +1,14 @@
-using CryptoExchange.Net.Converters.MessageParsing;
+using CryptoExchange.Net.Converters.MessageParsing;
 using CryptoExchange.Net.Objects;
 using System;
-using System.Collections.Generic;
+#if NET5_0_OR_GREATER
 using System.Diagnostics.CodeAnalysis;
+#endif
 using System.IO;
 using System.Threading.Tasks;
 
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// Message accessor
 /// </summary>
@@ -107,4 +108,3 @@ namespace CryptoExchange.Net.Interfaces
     /// <param name="data"></param>
     CallResult Read(ReadOnlyMemory<byte> data);
 }
-}

CryptoExchange.Net/Interfaces/IMessageProcessor.cs

@@ -1,12 +1,11 @@
-using CryptoExchange.Net.Objects;
+using CryptoExchange.Net.Objects;
 using CryptoExchange.Net.Objects.Sockets;
 using CryptoExchange.Net.Sockets;
 using System;
-using System.Collections.Generic;
 using System.Threading.Tasks;
 
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// Message processor
 /// </summary>
@@ -32,4 +31,3 @@ namespace CryptoExchange.Net.Interfaces
     /// <returns></returns>
     CallResult<object> Deserialize(IMessageAccessor accessor, Type type);
 }
-}

CryptoExchange.Net/Interfaces/IMessageSerializer.cs

@@ -1,7 +1,5 @@
-using System.Diagnostics.CodeAnalysis;
+namespace CryptoExchange.Net.Interfaces;
 
-namespace CryptoExchange.Net.Interfaces
-{
 /// <summary>
 /// Serializer interface
 /// </summary>
@@ -34,4 +32,3 @@ namespace CryptoExchange.Net.Interfaces
     /// <returns></returns>
     string Serialize<T>(T message);
 }
-}

CryptoExchange.Net/Interfaces/INonceProvider.cs

@@ -1,5 +1,5 @@
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// A provider for a nonce value used when signing requests
 /// </summary>
@@ -11,4 +11,3 @@
     /// <returns>Nonce value</returns>
     long GetNonce();
 }
-}

CryptoExchange.Net/Interfaces/IOrderBookFactory.cs

@@ -1,9 +1,9 @@
-using CryptoExchange.Net.Objects.Options;
+using CryptoExchange.Net.Objects.Options;
 using CryptoExchange.Net.SharedApis;
 using System;
 
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// Factory for ISymbolOrderBook instances
 /// </summary>
@@ -32,4 +32,3 @@ namespace CryptoExchange.Net.Interfaces
     /// <returns></returns>
     public ISymbolOrderBook Create(SharedSymbol symbol, Action<TOptions>? options = null);
 }
-}

CryptoExchange.Net/Interfaces/IRateLimiter.cs

@@ -4,8 +4,8 @@ using System.Net.Http;
 using System.Threading;
 using System.Threading.Tasks;
 
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// Rate limiter interface
 /// </summary>
@@ -25,4 +25,3 @@ namespace CryptoExchange.Net.Interfaces
     /// <returns>The time in milliseconds spend waiting</returns>
     Task<CallResult<int>> LimitRequestAsync(ILogger log, string endpoint, HttpMethod method, bool signed, string? apiKey, RateLimitingBehaviour limitBehaviour, int requestWeight, CancellationToken ct);
 }
-}

CryptoExchange.Net/Interfaces/IRequest.cs

@@ -1,11 +1,11 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Net.Http;
 using System.Threading;
 using System.Threading.Tasks;
 
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// Request interface
 /// </summary>
@@ -63,4 +63,3 @@ namespace CryptoExchange.Net.Interfaces
     /// <returns></returns>
     Task<IResponse> GetResponseAsync(CancellationToken cancellationToken);
 }
-}

CryptoExchange.Net/Interfaces/IRequestFactory.cs

@@ -1,9 +1,9 @@
-using CryptoExchange.Net.Objects;
+using CryptoExchange.Net.Objects;
 using System;
 using System.Net.Http;
 
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// Request factory interface
 /// </summary>
@@ -33,4 +33,3 @@ namespace CryptoExchange.Net.Interfaces
     /// <param name="requestTimeout">Request timeout to use</param>
     void UpdateSettings(ApiProxy? proxy, TimeSpan requestTimeout);
 }
-}

CryptoExchange.Net/Interfaces/IResponse.cs

@@ -1,10 +1,10 @@
-using System.Collections.Generic;
+using System.Collections.Generic;
 using System.IO;
 using System.Net;
 using System.Threading.Tasks;
 
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// Response object interface
 /// </summary>
@@ -41,4 +41,3 @@ namespace CryptoExchange.Net.Interfaces
     /// </summary>
     void Close();
 }
-}

CryptoExchange.Net/Interfaces/IRestApiClient.cs

@@ -1,5 +1,5 @@
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// Base rest API client
 /// </summary>
@@ -15,4 +15,3 @@
     /// </summary>
     int TotalRequestsMade { get; set; }
 }
-}

CryptoExchange.Net/Interfaces/IRestClient.cs

@@ -1,8 +1,8 @@
-using System;
+using System;
 using CryptoExchange.Net.Objects.Options;
 
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// Base class for rest API implementations
 /// </summary>
@@ -23,4 +23,3 @@ namespace CryptoExchange.Net.Interfaces
     /// </summary>
     string Exchange { get; }
 }
-}

CryptoExchange.Net/Interfaces/ISocketApiClient.cs

@@ -1,10 +1,10 @@
-using CryptoExchange.Net.Objects;
+using CryptoExchange.Net.Objects;
 using CryptoExchange.Net.Objects.Options;
 using CryptoExchange.Net.Objects.Sockets;
 using System.Threading.Tasks;
 
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// Socket API client
 /// </summary>
@@ -67,4 +67,3 @@ namespace CryptoExchange.Net.Interfaces
     /// <returns></returns>
     Task<CallResult> PrepareConnectionsAsync();
 }
-}

CryptoExchange.Net/Interfaces/ISocketClient.cs

@@ -1,10 +1,10 @@
-using System;
+using System;
 using System.Threading.Tasks;
 using CryptoExchange.Net.Objects.Options;
 using CryptoExchange.Net.Objects.Sockets;
 
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// Base class for socket API implementations
 /// </summary>
@@ -55,4 +55,3 @@ namespace CryptoExchange.Net.Interfaces
     /// <returns></returns>
     Task UnsubscribeAllAsync();
 }
-}

CryptoExchange.Net/Interfaces/ISymbolOrderBook.cs

@@ -1,11 +1,10 @@
-using System;
+using System;
-using System.Collections.Generic;
 using System.Threading;
 using System.Threading.Tasks;
 using CryptoExchange.Net.Objects;
 
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// Interface for order book
 /// </summary>
@@ -128,4 +127,3 @@ namespace CryptoExchange.Net.Interfaces
     /// <returns></returns>
     string ToString(int rows);
 }
-}

CryptoExchange.Net/Interfaces/ISymbolOrderBookEntry.cs

@@ -1,5 +1,5 @@
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// Interface for order book entries
 /// </summary>
@@ -25,4 +25,3 @@
     /// </summary>
     long Sequence { get; set; }
 }
-}

CryptoExchange.Net/Interfaces/IWebsocket.cs

@@ -1,11 +1,11 @@
-using CryptoExchange.Net.Objects;
+using CryptoExchange.Net.Objects;
 using System;
 using System.Net.WebSockets;
 using System.Threading;
 using System.Threading.Tasks;
 
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// Websocket connection interface
 /// </summary>
@@ -107,4 +107,3 @@ namespace CryptoExchange.Net.Interfaces
     /// </summary>
     void UpdateProxy(ApiProxy? proxy);
 }
-}

CryptoExchange.Net/Interfaces/IWebsocketFactory.cs

@@ -1,8 +1,8 @@
-using CryptoExchange.Net.Objects.Sockets;
+using CryptoExchange.Net.Objects.Sockets;
 using Microsoft.Extensions.Logging;
 
-namespace CryptoExchange.Net.Interfaces
+namespace CryptoExchange.Net.Interfaces;
-{
+
 /// <summary>
 /// Websocket factory interface
 /// </summary>
@@ -16,4 +16,3 @@ namespace CryptoExchange.Net.Interfaces
     /// <returns></returns>
     IWebsocket CreateWebsocket(ILogger logger, WebSocketParameters parameters);
 }
-}

CryptoExchange.Net/LibraryHelpers.cs

@@ -1,9 +1,5 @@
-using System;
+namespace CryptoExchange.Net;
-using System.Collections.Generic;
-using System.Text;
 
-namespace CryptoExchange.Net
-{
 /// <summary>
 /// Helpers for client libraries
 /// </summary>
@@ -44,4 +40,3 @@ namespace CryptoExchange.Net
         return clientOrderId;
     }
 }
-}

CryptoExchange.Net/Logging/Extensions/CryptoExchangeWebSocketClientLoggingExtension.cs

@@ -1,8 +1,8 @@
-using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Logging;
 using System;
 
-namespace CryptoExchange.Net.Logging.Extensions
+namespace CryptoExchange.Net.Logging.Extensions;
-{
+
 #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
 public static class CryptoExchangeWebSocketClientLoggingExtension
 {
@@ -384,4 +384,3 @@ namespace CryptoExchange.Net.Logging.Extensions
         _connectingCanceled(logger, socketId, null);
     }
 }
-}

CryptoExchange.Net/Logging/Extensions/RateLimitGateLoggingExtensions.cs

@@ -1,8 +1,8 @@
-using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Logging;
 using System;
 
-namespace CryptoExchange.Net.Logging.Extensions
+namespace CryptoExchange.Net.Logging.Extensions;
-{
+
 #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
 public static class RateLimitGateLoggingExtensions
 {
@@ -76,4 +76,3 @@ namespace CryptoExchange.Net.Logging.Extensions
         _rateLimitAppliedRequest(logger, requestIdId, path, guard, limit, current, null);
     }
 }
-}

CryptoExchange.Net/Logging/Extensions/RestApiClientLoggingExtensions.cs

@@ -1,11 +1,11 @@
-using CryptoExchange.Net.Objects;
+using CryptoExchange.Net.Objects;
 using Microsoft.Extensions.Logging;
 using System;
 using System.Net;
 using System.Net.Http;
 
-namespace CryptoExchange.Net.Logging.Extensions
+namespace CryptoExchange.Net.Logging.Extensions;
-{
+
 #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
 public static class RestApiClientLoggingExtensions
 {
@@ -156,4 +156,3 @@ namespace CryptoExchange.Net.Logging.Extensions
         _restApiCancellationRequested(logger, requestId, null);
     }
 }
-}

CryptoExchange.Net/Logging/Extensions/SocketApiClientLoggingExtension.cs

@@ -1,8 +1,8 @@
-using Microsoft.Extensions.Logging;
+using Microsoft.Extensions.Logging;
 using System;
 
-namespace CryptoExchange.Net.Logging.Extensions
+namespace CryptoExchange.Net.Logging.Extensions;
-{
+
 #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
 public static class SocketApiClientLoggingExtension
 {
@@ -197,4 +197,3 @@ namespace CryptoExchange.Net.Logging.Extensions
         _addingRetryAfterGuard(logger, retryAfter, null);
     }
 }
-}

CryptoExchange.Net/Logging/Extensions/SocketConnectionLoggingExtension.cs

@@ -1,9 +1,9 @@
-using System;
+using System;
 using System.Net.WebSockets;
 using Microsoft.Extensions.Logging;
 
-namespace CryptoExchange.Net.Logging.Extensions
+namespace CryptoExchange.Net.Logging.Extensions;
-{
+
 #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
 public static class SocketConnectionLoggingExtension
 {
@@ -346,4 +346,3 @@ namespace CryptoExchange.Net.Logging.Extensions
         _sendingByteData(logger, socketId, requestId, length, null);
     }
 }
-}

CryptoExchange.Net/Logging/Extensions/SymbolOrderBookLoggingExtensions.cs

@@ -1,9 +1,9 @@
-using System;
+using System;
 using CryptoExchange.Net.Objects;
 using Microsoft.Extensions.Logging;
 
-namespace CryptoExchange.Net.Logging.Extensions
+namespace CryptoExchange.Net.Logging.Extensions;
-{
+
 #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
 
 public static class SymbolOrderBookLoggingExtensions
@@ -234,4 +234,3 @@ namespace CryptoExchange.Net.Logging.Extensions
         _orderBookOutOfSyncChecksum(logger, api, symbol, null);
     }
 }
-}

CryptoExchange.Net/Logging/Extensions/TrackerLoggingExtensions.cs

@@ -1,9 +1,9 @@
-using System;
+using System;
 using CryptoExchange.Net.Objects;
 using Microsoft.Extensions.Logging;
 
-namespace CryptoExchange.Net.Logging.Extensions
+namespace CryptoExchange.Net.Logging.Extensions;
-{
+
 #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
 
 public static class TrackerLoggingExtensions
@@ -288,4 +288,3 @@ namespace CryptoExchange.Net.Logging.Extensions
         _tradeTrackerConnectionRestored(logger, symbol, null);
     }
 }
-}

CryptoExchange.Net/Objects/ApiProxy.cs

@@ -1,5 +1,5 @@
-namespace CryptoExchange.Net.Objects
+namespace CryptoExchange.Net.Objects;
-{
+
 /// <summary>
 /// Proxy info
 /// </summary>
@@ -39,4 +39,3 @@
         Password = password;
     }
 }
-}

CryptoExchange.Net/Objects/AssetAlias.cs

@@ -1,9 +1,5 @@
-using System;
+namespace CryptoExchange.Net.Objects;
-using System.Collections.Generic;
-using System.Text;
 
-namespace CryptoExchange.Net.Objects
-{
 /// <summary>
 /// An alias used by the exchange for an asset commonly known by another name
 /// </summary>
@@ -27,4 +23,3 @@ namespace CryptoExchange.Net.Objects
         CommonAssetName = commonName;
     }
 }
-}

CryptoExchange.Net/Objects/AssetAliasConfiguration.cs

@@ -1,10 +1,7 @@
-using System;
-using System.Collections.Generic;
 using System.Linq;
-using System.Text;
 
-namespace CryptoExchange.Net.Objects
+namespace CryptoExchange.Net.Objects;
-{
+
 /// <summary>
 /// Exchange configuration for asset aliases
 /// </summary>
@@ -31,4 +28,3 @@ namespace CryptoExchange.Net.Objects
     public string ExchangeToCommonName(string exchangeName) => !AutoConvertEnabled ? exchangeName : Aliases.SingleOrDefault(x => x.ExchangeAssetName == exchangeName)?.CommonAssetName ?? exchangeName;
 
 }
-}

CryptoExchange.Net/Objects/AsyncAutoResetEvent.cs

@@ -1,11 +1,11 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Threading;
 using System.Threading.Tasks;
 
-namespace CryptoExchange.Net.Objects
+namespace CryptoExchange.Net.Objects;
-{
+
 /// <summary>
 /// Async auto reset based on Stephen Toub`s implementation
 /// https://devblogs.microsoft.com/pfxteam/building-async-coordination-primitives-part-2-asyncautoresetevent/
@@ -106,10 +106,12 @@ namespace CryptoExchange.Net.Objects
                     toRelease.TrySetResult(true);
                 }
                 else if (!_signaled)
+                {
                     _signaled = true;
                 }
             }
         }
+    }
 
     /// <summary>
     /// Dispose
@@ -119,4 +121,3 @@ namespace CryptoExchange.Net.Objects
         _waits.Clear();
     }
 }
-}

CryptoExchange.Net/Objects/AuthTimeProvider.cs

@@ -1,10 +1,9 @@
-using CryptoExchange.Net.Interfaces;
+using CryptoExchange.Net.Interfaces;
 using System;
 
-namespace CryptoExchange.Net.Objects
+namespace CryptoExchange.Net.Objects;
-{
+
 internal class AuthTimeProvider : IAuthTimeProvider
 {
     public DateTime GetTime() => DateTime.UtcNow;
 }
-}

CryptoExchange.Net/Objects/ByteOrderComparer.cs

@@ -1,8 +1,8 @@
-using System;
+using System;
 using System.Collections.Generic;
 
-namespace CryptoExchange.Net.Objects
+namespace CryptoExchange.Net.Objects;
-{
+
 /// <summary>
 /// Comparer for byte order
 /// </summary>
@@ -55,4 +55,3 @@ namespace CryptoExchange.Net.Objects
         return x.Length < y.Length ? -1 : 1;
     }
 }
-}

CryptoExchange.Net/Objects/CallResult.cs

@@ -1,4 +1,4 @@
-using CryptoExchange.Net.SharedApis;
+using CryptoExchange.Net.SharedApis;
 using System;
 using System.Collections.Generic;
 using System.Diagnostics.CodeAnalysis;
@@ -6,8 +6,8 @@ using System.Net;
 using System.Net.Http;
 using System.Text;
 
-namespace CryptoExchange.Net.Objects
+namespace CryptoExchange.Net.Objects;
-{
+
 /// <summary>
 /// The result of an operation
 /// </summary>
@@ -140,12 +140,12 @@ namespace CryptoExchange.Net.Objects
     /// <summary>
     /// Copy the WebCallResult to a new data type
     /// </summary>
-        /// <typeparam name="K">The new type</typeparam>
+    /// <typeparam name="TNew">The new type</typeparam>
     /// <param name="data">The data of the new type</param>
     /// <returns></returns>
-        public CallResult<K> As<K>([AllowNull] K data)
+    public CallResult<TNew> As<TNew>([AllowNull] TNew data)
     {
-            return new CallResult<K>(data, OriginalData, Error);
+        return new CallResult<TNew>(data, OriginalData, Error);
     }
 
     /// <summary>
@@ -169,24 +169,24 @@ namespace CryptoExchange.Net.Objects
     /// <summary>
     /// Copy the CallResult to a new data type
     /// </summary>
-        /// <typeparam name="K">The new type</typeparam>
+    /// <typeparam name="TNew">The new type</typeparam>
     /// <param name="data">The data</param>
     /// <param name="error">The error returned</param>
     /// <returns></returns>
-        public CallResult<K> AsErrorWithData<K>(Error error, K data)
+    public CallResult<TNew> AsErrorWithData<TNew>(Error error, TNew data)
     {
-            return new CallResult<K>(data, OriginalData, error);
+        return new CallResult<TNew>(data, OriginalData, error);
     }
 
     /// <summary>
     /// Copy the WebCallResult to a new data type
     /// </summary>
-        /// <typeparam name="K">The new type</typeparam>
+    /// <typeparam name="TNew">The new type</typeparam>
     /// <param name="error">The error to return</param>
     /// <returns></returns>
-        public CallResult<K> AsError<K>(Error error)
+    public CallResult<TNew> AsError<TNew>(Error error)
     {
-            return new CallResult<K>(default, OriginalData, error);
+        return new CallResult<TNew>(default, OriginalData, error);
     }
 
     /// <inheritdoc />
@@ -292,49 +292,49 @@ namespace CryptoExchange.Net.Objects
     /// <summary>
     /// Copy the WebCallResult to a new data type
     /// </summary>
-        /// <typeparam name="K">The new type</typeparam>
+    /// <typeparam name="TNew">The new type</typeparam>
     /// <param name="data">The data of the new type</param>
     /// <returns></returns>
-        public WebCallResult<K> As<K>([AllowNull] K data)
+    public WebCallResult<TNew> As<TNew>([AllowNull] TNew data)
     {
-            return new WebCallResult<K>(ResponseStatusCode, ResponseHeaders, ResponseTime, 0, null, RequestId, RequestUrl, RequestBody, RequestMethod, RequestHeaders, ResultDataSource.Server, data, Error);
+        return new WebCallResult<TNew>(ResponseStatusCode, ResponseHeaders, ResponseTime, 0, null, RequestId, RequestUrl, RequestBody, RequestMethod, RequestHeaders, ResultDataSource.Server, data, Error);
     }
 
     /// <summary>
     /// Copy the WebCallResult to an ExchangeWebResult of a new data type
     /// </summary>
-        /// <typeparam name="K">The new type</typeparam>
+    /// <typeparam name="TNew">The new type</typeparam>
     /// <param name="exchange">The exchange</param>
     /// <param name="tradeMode">Trade mode the result applies to</param>
     /// <param name="data">The data</param>
     /// <returns></returns>
-        public ExchangeWebResult<K> AsExchangeResult<K>(string exchange, TradingMode tradeMode, [AllowNull] K data)
+    public ExchangeWebResult<TNew> AsExchangeResult<TNew>(string exchange, TradingMode tradeMode, [AllowNull] TNew data)
     {
-            return new ExchangeWebResult<K>(exchange, tradeMode, this.As<K>(data));
+        return new ExchangeWebResult<TNew>(exchange, tradeMode, this.As<TNew>(data));
     }
 
     /// <summary>
     /// Copy the WebCallResult to an ExchangeWebResult of a new data type
     /// </summary>
-        /// <typeparam name="K">The new type</typeparam>
+    /// <typeparam name="TNew">The new type</typeparam>
     /// <param name="exchange">The exchange</param>
     /// <param name="tradeModes">Trade modes the result applies to</param>
     /// <param name="data">The data</param>
     /// <returns></returns>
-        public ExchangeWebResult<K> AsExchangeResult<K>(string exchange, TradingMode[]? tradeModes, [AllowNull] K data)
+    public ExchangeWebResult<TNew> AsExchangeResult<TNew>(string exchange, TradingMode[]? tradeModes, [AllowNull] TNew data)
     {
-            return new ExchangeWebResult<K>(exchange, tradeModes, this.As<K>(data));
+        return new ExchangeWebResult<TNew>(exchange, tradeModes, this.As<TNew>(data));
     }
 
     /// <summary>
     /// Copy the WebCallResult to a new data type
     /// </summary>
-        /// <typeparam name="K">The new type</typeparam>
+    /// <typeparam name="TNew">The new type</typeparam>
     /// <param name="error">The error returned</param>
     /// <returns></returns>
-        public WebCallResult<K> AsError<K>(Error error)
+    public WebCallResult<TNew> AsError<TNew>(Error error)
     {
-            return new WebCallResult<K>(ResponseStatusCode, ResponseHeaders, ResponseTime, 0, null, RequestId, RequestUrl, RequestBody, RequestMethod, RequestHeaders, ResultDataSource.Server, default, error);
+        return new WebCallResult<TNew>(ResponseStatusCode, ResponseHeaders, ResponseTime, 0, null, RequestId, RequestUrl, RequestBody, RequestMethod, RequestHeaders, ResultDataSource.Server, default, error);
     }
 
     /// <inheritdoc />
@@ -470,35 +470,35 @@ namespace CryptoExchange.Net.Objects
     /// <summary>
     /// Copy the WebCallResult to a new data type
     /// </summary>
-        /// <typeparam name="K">The new type</typeparam>
+    /// <typeparam name="TNew">The new type</typeparam>
     /// <param name="data">The data of the new type</param>
     /// <returns></returns>
-        public new WebCallResult<K> As<K>([AllowNull] K data)
+    public new WebCallResult<TNew> As<TNew>([AllowNull] TNew data)
     {
-            return new WebCallResult<K>(ResponseStatusCode, ResponseHeaders, ResponseTime, ResponseLength, OriginalData, RequestId, RequestUrl, RequestBody, RequestMethod, RequestHeaders, DataSource, data, Error);
+        return new WebCallResult<TNew>(ResponseStatusCode, ResponseHeaders, ResponseTime, ResponseLength, OriginalData, RequestId, RequestUrl, RequestBody, RequestMethod, RequestHeaders, DataSource, data, Error);
     }
 
     /// <summary>
     /// Copy the WebCallResult to a new data type
     /// </summary>
-        /// <typeparam name="K">The new type</typeparam>
+    /// <typeparam name="TNew">The new type</typeparam>
     /// <param name="error">The error returned</param>
     /// <returns></returns>
-        public new WebCallResult<K> AsError<K>(Error error)
+    public new WebCallResult<TNew> AsError<TNew>(Error error)
     {
-            return new WebCallResult<K>(ResponseStatusCode, ResponseHeaders, ResponseTime, ResponseLength, OriginalData, RequestId, RequestUrl, RequestBody, RequestMethod, RequestHeaders, DataSource, default, error);
+        return new WebCallResult<TNew>(ResponseStatusCode, ResponseHeaders, ResponseTime, ResponseLength, OriginalData, RequestId, RequestUrl, RequestBody, RequestMethod, RequestHeaders, DataSource, default, error);
     }
 
     /// <summary>
     /// Copy the WebCallResult to a new data type
     /// </summary>
-        /// <typeparam name="K">The new type</typeparam>
+    /// <typeparam name="TNew">The new type</typeparam>
     /// <param name="data">The data</param>
     /// <param name="error">The error returned</param>
     /// <returns></returns>
-        public new WebCallResult<K> AsErrorWithData<K>(Error error, K data)
+    public new WebCallResult<TNew> AsErrorWithData<TNew>(Error error, TNew data)
     {
-            return new WebCallResult<K>(ResponseStatusCode, ResponseHeaders, ResponseTime, ResponseLength, OriginalData, RequestId, RequestUrl, RequestBody, RequestMethod, RequestHeaders, DataSource, data, error);
+        return new WebCallResult<TNew>(ResponseStatusCode, ResponseHeaders, ResponseTime, ResponseLength, OriginalData, RequestId, RequestUrl, RequestBody, RequestMethod, RequestHeaders, DataSource, data, error);
     }
 
     /// <summary>
@@ -526,41 +526,41 @@ namespace CryptoExchange.Net.Objects
     /// <summary>
     /// Copy the WebCallResult to an ExchangeWebResult of a new data type
     /// </summary>
-        /// <typeparam name="K">The new type</typeparam>
+    /// <typeparam name="TNew">The new type</typeparam>
     /// <param name="exchange">The exchange</param>
     /// <param name="tradeMode">Trade mode the result applies to</param>
     /// <param name="data">Data</param>
     /// <param name="nextPageToken">Next page token</param>
     /// <returns></returns>
-        public ExchangeWebResult<K> AsExchangeResult<K>(string exchange, TradingMode tradeMode, [AllowNull] K data, INextPageToken? nextPageToken = null)
+    public ExchangeWebResult<TNew> AsExchangeResult<TNew>(string exchange, TradingMode tradeMode, [AllowNull] TNew data, INextPageToken? nextPageToken = null)
     {
-            return new ExchangeWebResult<K>(exchange, tradeMode, As<K>(data), nextPageToken);
+        return new ExchangeWebResult<TNew>(exchange, tradeMode, As<TNew>(data), nextPageToken);
     }
 
     /// <summary>
     /// Copy the WebCallResult to an ExchangeWebResult of a new data type
     /// </summary>
-        /// <typeparam name="K">The new type</typeparam>
+    /// <typeparam name="TNew">The new type</typeparam>
     /// <param name="exchange">The exchange</param>
     /// <param name="tradeModes">Trade modes the result applies to</param>
     /// <param name="data">Data</param>
     /// <param name="nextPageToken">Next page token</param>
     /// <returns></returns>
-        public ExchangeWebResult<K> AsExchangeResult<K>(string exchange, TradingMode[]? tradeModes, [AllowNull] K data, INextPageToken? nextPageToken = null)
+    public ExchangeWebResult<TNew> AsExchangeResult<TNew>(string exchange, TradingMode[]? tradeModes, [AllowNull] TNew data, INextPageToken? nextPageToken = null)
     {
-            return new ExchangeWebResult<K>(exchange, tradeModes, As<K>(data), nextPageToken);
+        return new ExchangeWebResult<TNew>(exchange, tradeModes, As<TNew>(data), nextPageToken);
     }
 
     /// <summary>
     /// Copy the WebCallResult to an ExchangeWebResult with a specific error
     /// </summary>
-        /// <typeparam name="K">The new type</typeparam>
+    /// <typeparam name="TNew">The new type</typeparam>
     /// <param name="exchange">The exchange</param>
     /// <param name="error">The error returned</param>
     /// <returns></returns>
-        public ExchangeWebResult<K> AsExchangeError<K>(string exchange, Error error)
+    public ExchangeWebResult<TNew> AsExchangeError<TNew>(string exchange, Error error)
     {
-            return new ExchangeWebResult<K>(exchange, null, AsError<K>(error));
+        return new ExchangeWebResult<TNew>(exchange, null, AsError<TNew>(error));
     }
 
     /// <summary>
@@ -585,4 +585,3 @@ namespace CryptoExchange.Net.Objects
         return sb.ToString();
     }
 }
-}

CryptoExchange.Net/Objects/Constants.cs

@@ -1,5 +1,5 @@
-namespace CryptoExchange.Net.Objects
+namespace CryptoExchange.Net.Objects;
-{
+
 /// <summary>
 /// Constants
 /// </summary>
@@ -18,4 +18,3 @@
     /// </summary>
     public const string BodyPlaceHolderKey = "_BODY_";
 }
-}

CryptoExchange.Net/Objects/Enums.cs

@@ -1,7 +1,5 @@
-using CryptoExchange.Net.Attributes;
+namespace CryptoExchange.Net.Objects;
 
-namespace CryptoExchange.Net.Objects
-{
 /// <summary>
 /// What to do when a request would exceed the rate limit
 /// </summary>
@@ -266,5 +264,3 @@ namespace CryptoExchange.Net.Objects
     /// </summary>
     Succeed
 }
-
-}

CryptoExchange.Net/Objects/Error.cs

@@ -1,14 +1,13 @@
-using CryptoExchange.Net.Objects.Errors;
+using CryptoExchange.Net.Objects.Errors;
 using System;
 
-namespace CryptoExchange.Net.Objects
+namespace CryptoExchange.Net.Objects;
-{
+
 /// <summary>
 /// Base class for errors
 /// </summary>
 public abstract class Error
 {
-
     private int? _code;
     /// <summary>
     /// The int error code the server returned; or the http status code int value if there was no error code.<br />
@@ -91,17 +90,17 @@ namespace CryptoExchange.Net.Objects
     /// <summary>
     /// Default error info
     /// </summary>
-        protected static readonly ErrorInfo _errorInfo = new ErrorInfo(ErrorType.UnableToConnect, false, "Can't connect to the server");
+    protected static readonly ErrorInfo errorInfo = new ErrorInfo(ErrorType.UnableToConnect, false, "Can't connect to the server");
 
     /// <summary>
     /// ctor
     /// </summary>
-        public CantConnectError() : base(null, _errorInfo, null) { }
+    public CantConnectError() : base(null, errorInfo, null) { }
 
     /// <summary>
     /// ctor
     /// </summary>
-        public CantConnectError(Exception? exception) : base(null, _errorInfo, exception) { }
+    public CantConnectError(Exception? exception) : base(null, errorInfo, exception) { }
 
     /// <summary>
     /// ctor
@@ -117,12 +116,12 @@ namespace CryptoExchange.Net.Objects
     /// <summary>
     /// Default error info
     /// </summary>
-        protected static readonly ErrorInfo _errorInfo = new ErrorInfo(ErrorType.MissingCredentials, false, "No credentials provided for private endpoint");
+    protected static readonly ErrorInfo errorInfo = new ErrorInfo(ErrorType.MissingCredentials, false, "No credentials provided for private endpoint");
 
     /// <summary>
     /// ctor
     /// </summary>
-        public NoApiCredentialsError() : base(null, _errorInfo, null) { }
+    public NoApiCredentialsError() : base(null, errorInfo, null) { }
 
     /// <summary>
     /// ctor
@@ -161,12 +160,12 @@ namespace CryptoExchange.Net.Objects
     /// <summary>
     /// Default error info
     /// </summary>
-        protected static readonly ErrorInfo _errorInfo = new ErrorInfo(ErrorType.NetworkError, true, "Failed to complete the request to the server due to a network error");
+    protected static readonly ErrorInfo errorInfo = new ErrorInfo(ErrorType.NetworkError, true, "Failed to complete the request to the server due to a network error");
 
     /// <summary>
     /// ctor
     /// </summary>
-        public WebError(string? message = null, Exception? exception = null) : base(null, _errorInfo with { Message = (message?.Length > 0 ? _errorInfo.Message + ": " + message : _errorInfo.Message) }, exception) { }
+    public WebError(string? message = null, Exception? exception = null) : base(null, errorInfo with { Message = (message?.Length > 0 ? errorInfo.Message + ": " + message : errorInfo.Message) }, exception) { }
 }
 
 /// <summary>
@@ -177,12 +176,12 @@ namespace CryptoExchange.Net.Objects
     /// <summary>
     /// Default error info
     /// </summary>
-        protected static readonly ErrorInfo _errorInfo = new ErrorInfo(ErrorType.Timeout, false, "Failed to receive a response from the server in time");
+    protected static readonly ErrorInfo errorInfo = new ErrorInfo(ErrorType.Timeout, false, "Failed to receive a response from the server in time");
 
     /// <summary>
     /// ctor
     /// </summary>
-        public TimeoutError(string? message = null, Exception? exception = null) : base(null, _errorInfo with { Message = (message?.Length > 0 ? _errorInfo.Message + ": " + message : _errorInfo.Message) }, exception) { }
+    public TimeoutError(string? message = null, Exception? exception = null) : base(null, errorInfo with { Message = (message?.Length > 0 ? errorInfo.Message + ": " + message : errorInfo.Message) }, exception) { }
 }
 
 /// <summary>
@@ -193,12 +192,12 @@ namespace CryptoExchange.Net.Objects
     /// <summary>
     /// Default error info
     /// </summary>
-        protected static readonly ErrorInfo _errorInfo = new ErrorInfo(ErrorType.DeserializationFailed, false, "Failed to deserialize data");
+    protected static readonly ErrorInfo errorInfo = new ErrorInfo(ErrorType.DeserializationFailed, false, "Failed to deserialize data");
 
     /// <summary>
     /// ctor
     /// </summary>
-        public DeserializeError(string? message = null, Exception? exception = null) : base(null, _errorInfo with { Message = (message?.Length > 0 ? _errorInfo.Message + ": " + message : _errorInfo.Message) }, exception) { }
+    public DeserializeError(string? message = null, Exception? exception = null) : base(null, errorInfo with { Message = (message?.Length > 0 ? errorInfo.Message + ": " + message : errorInfo.Message) }, exception) { }
 }
 
 /// <summary>
@@ -209,21 +208,21 @@ namespace CryptoExchange.Net.Objects
     /// <summary>
     /// Default error info for missing parameter
     /// </summary>
-        protected static readonly ErrorInfo _missingInfo = new ErrorInfo(ErrorType.MissingParameter, false, "Missing parameter");
+    protected static readonly ErrorInfo missingInfo = new ErrorInfo(ErrorType.MissingParameter, false, "Missing parameter");
     /// <summary>
     /// Default error info for invalid parameter
     /// </summary>
-        protected static readonly ErrorInfo _invalidInfo = new ErrorInfo(ErrorType.InvalidParameter, false, "Invalid parameter");
+    protected static readonly ErrorInfo invalidInfo = new ErrorInfo(ErrorType.InvalidParameter, false, "Invalid parameter");
 
     /// <summary>
     /// ctor
     /// </summary>
-        public static ArgumentError Missing(string parameterName, string? message = null) => new ArgumentError(_missingInfo with { Message = message == null ? $"{_missingInfo.Message} '{parameterName}'" : $"{_missingInfo.Message} '{parameterName}': {message}" }, null);
+    public static ArgumentError Missing(string parameterName, string? message = null) => new ArgumentError(missingInfo with { Message = message == null ? $"{missingInfo.Message} '{parameterName}'" : $"{missingInfo.Message} '{parameterName}': {message}" }, null);
 
     /// <summary>
     /// ctor
     /// </summary>
-        public static ArgumentError Invalid(string parameterName, string message) => new ArgumentError(_invalidInfo with { Message = $"{_invalidInfo.Message} '{parameterName}': {message}" }, null);
+    public static ArgumentError Invalid(string parameterName, string message) => new ArgumentError(invalidInfo with { Message = $"{invalidInfo.Message} '{parameterName}': {message}" }, null);
 
     /// <summary>
     /// ctor
@@ -255,12 +254,12 @@ namespace CryptoExchange.Net.Objects
     /// <summary>
     /// Default error info
     /// </summary>
-        protected static readonly ErrorInfo _errorInfo = new ErrorInfo(ErrorType.RateLimitRequest, false, "Client rate limit exceeded");
+    protected static readonly ErrorInfo errorInfo = new ErrorInfo(ErrorType.RateLimitRequest, false, "Client rate limit exceeded");
 
     /// <summary>
     /// ctor
     /// </summary>
-        public ClientRateLimitError(string? message = null, Exception? exception = null) : base(_errorInfo with { Message = (message?.Length > 0 ? _errorInfo.Message + ": " + message : _errorInfo.Message) }, exception) { }
+    public ClientRateLimitError(string? message = null, Exception? exception = null) : base(errorInfo with { Message = (message?.Length > 0 ? errorInfo.Message + ": " + message : errorInfo.Message) }, exception) { }
 
     /// <summary>
     /// ctor
@@ -276,12 +275,12 @@ namespace CryptoExchange.Net.Objects
     /// <summary>
     /// Default error info
     /// </summary>
-        protected static readonly ErrorInfo _errorInfo = new ErrorInfo(ErrorType.RateLimitRequest, false, "Server rate limit exceeded");
+    protected static readonly ErrorInfo errorInfo = new ErrorInfo(ErrorType.RateLimitRequest, false, "Server rate limit exceeded");
 
     /// <summary>
     /// ctor
     /// </summary>
-        public ServerRateLimitError(string? message = null, Exception? exception = null) : base(_errorInfo with { Message = (message?.Length > 0 ? _errorInfo.Message + ": " + message : _errorInfo.Message) }, exception) { }
+    public ServerRateLimitError(string? message = null, Exception? exception = null) : base(errorInfo with { Message = (message?.Length > 0 ? errorInfo.Message + ": " + message : errorInfo.Message) }, exception) { }
 
     /// <summary>
     /// ctor
@@ -297,12 +296,12 @@ namespace CryptoExchange.Net.Objects
     /// <summary>
     /// Default error info
     /// </summary>
-        protected static readonly ErrorInfo _errorInfo = new ErrorInfo(ErrorType.CancellationRequested, false, "Cancellation requested");
+    protected static readonly ErrorInfo errorInfo = new ErrorInfo(ErrorType.CancellationRequested, false, "Cancellation requested");
 
     /// <summary>
     /// ctor
     /// </summary>
-        public CancellationRequestedError(Exception? exception = null) : base(null, _errorInfo, null) { }
+    public CancellationRequestedError(Exception? exception = null) : base(null, errorInfo, null) { }
 
     /// <summary>
     /// ctor
@@ -318,16 +317,15 @@ namespace CryptoExchange.Net.Objects
     /// <summary>
     /// Default error info
     /// </summary>
-        protected static readonly ErrorInfo _errorInfo = new ErrorInfo(ErrorType.InvalidOperation, false, "Operation invalid");
+    protected static readonly ErrorInfo errorInfo = new ErrorInfo(ErrorType.InvalidOperation, false, "Operation invalid");
 
     /// <summary>
     /// ctor
     /// </summary>
-        public InvalidOperationError(string message) : base(null, _errorInfo with { Message = message }, null) { }
+    public InvalidOperationError(string message) : base(null, errorInfo with { Message = message }, null) { }
 
     /// <summary>
     /// ctor
     /// </summary>
     protected InvalidOperationError(ErrorInfo info, Exception? exception) : base(null, info, exception) { }
 }
-}

CryptoExchange.Net/Objects/Errors/ErrorEvaluator.cs

@@ -1,9 +1,7 @@
-using System;
+using System;
-using System.Collections.Generic;
+
-using System.Text;
+namespace CryptoExchange.Net.Objects.Errors;
 
-namespace CryptoExchange.Net.Objects.Errors
-{
 /// <summary>
 /// Error evaluator
 /// </summary>
@@ -37,4 +35,3 @@ namespace CryptoExchange.Net.Objects.Errors
         ErrorTypeEvaluator = errorTypeEvaluator;
     }
 }
-}

CryptoExchange.Net/Objects/Errors/ErrorInfo.cs

@@ -1,7 +1,5 @@
-using System;
+namespace CryptoExchange.Net.Objects.Errors;
 
-namespace CryptoExchange.Net.Objects.Errors
-{
 /// <summary>
 /// Error info
 /// </summary>
@@ -55,4 +53,3 @@ namespace CryptoExchange.Net.Objects.Errors
         ErrorDescription = description;
     }
 }
-}

CryptoExchange.Net/Objects/Errors/ErrorMapping.cs

@@ -1,10 +1,8 @@
-using System;
+using System;
 using System.Collections.Generic;
-using System.Linq;
-using System.Text;
 
-namespace CryptoExchange.Net.Objects.Errors
+namespace CryptoExchange.Net.Objects.Errors;
-{
+
 /// <summary>
 /// Error mapping collection
 /// </summary>
@@ -20,7 +18,7 @@ namespace CryptoExchange.Net.Objects.Errors
     {
         foreach (var item in errorMappings)
         {
-                if (!item.ErrorCodes.Any())
+            if (item.ErrorCodes.Length == 0)
                 throw new Exception("Error codes can't be null in error mapping");
 
             foreach(var code in item.ErrorCodes!)
@@ -51,4 +49,3 @@ namespace CryptoExchange.Net.Objects.Errors
         return ErrorInfo.Unknown with { Message = message };
     }
 }
-}

CryptoExchange.Net/Objects/Errors/ErrorType.cs

@@ -1,9 +1,5 @@
-using System;
+namespace CryptoExchange.Net.Objects.Errors;
-using System.Collections.Generic;
-using System.Text;
 
-namespace CryptoExchange.Net.Objects.Errors
-{
 /// <summary>
 /// Type of error
 /// </summary>
@@ -159,4 +155,3 @@ namespace CryptoExchange.Net.Objects.Errors
 
     #endregion
 }
-}

CryptoExchange.Net/Objects/Options/ApiOptions.cs

@@ -1,7 +1,7 @@
-using CryptoExchange.Net.Authentication;
+using CryptoExchange.Net.Authentication;
+
+namespace CryptoExchange.Net.Objects.Options;
 
-namespace CryptoExchange.Net.Objects.Options
-{
 /// <summary>
 /// Options for API usage
 /// </summary>
@@ -17,4 +17,3 @@ namespace CryptoExchange.Net.Objects.Options
     /// </summary>        
     public ApiCredentials? ApiCredentials { get; set; }
 }
-}

CryptoExchange.Net/Objects/Options/ExchangeOptions.cs

@@ -1,8 +1,8 @@
-using CryptoExchange.Net.Authentication;
+using CryptoExchange.Net.Authentication;
 using System;
 
-namespace CryptoExchange.Net.Objects.Options
+namespace CryptoExchange.Net.Objects.Options;
-{
+
 /// <summary>
 /// Exchange options
 /// </summary>
@@ -16,7 +16,7 @@ namespace CryptoExchange.Net.Objects.Options
     /// <summary>
     /// If true, the CallResult and DataEvent objects will also include the originally received json data in the OriginalData property
     /// </summary>
-        public bool OutputOriginalData { get; set; } = false;
+    public bool OutputOriginalData { get; set; }
 
     /// <summary>
     /// The max time a request is allowed to take
@@ -43,4 +43,3 @@ namespace CryptoExchange.Net.Objects.Options
         return $"RequestTimeout: {RequestTimeout}, Proxy: {(Proxy == null ? "-" : "set")}, ApiCredentials: {(ApiCredentials == null ? "-" : "set")}";
     }
 }
-}

CryptoExchange.Net/Objects/Options/LibraryOptions.cs

@@ -1,8 +1,8 @@
-using CryptoExchange.Net.Authentication;
+using CryptoExchange.Net.Authentication;
 using Microsoft.Extensions.DependencyInjection;
 
-namespace CryptoExchange.Net.Objects.Options
+namespace CryptoExchange.Net.Objects.Options;
-{
+
 /// <summary>
 /// Library options
 /// </summary>
@@ -55,4 +55,3 @@ namespace CryptoExchange.Net.Objects.Options
         return targetOptions;
     }
 }
-}

CryptoExchange.Net/Objects/Options/OrderBookOptions.cs

@@ -1,5 +1,5 @@
-namespace CryptoExchange.Net.Objects.Options
+namespace CryptoExchange.Net.Objects.Options;
-{
+
 /// <summary>
 /// Base for order book options
 /// </summary>
@@ -23,4 +23,3 @@
         };
     }
 }
-}

CryptoExchange.Net/Objects/Options/RestApiOptions.cs

@@ -1,8 +1,8 @@
-using CryptoExchange.Net.Authentication;
+using CryptoExchange.Net.Authentication;
 using System;
 
-namespace CryptoExchange.Net.Objects.Options
+namespace CryptoExchange.Net.Objects.Options;
-{
+
 /// <summary>
 /// Http api options
 /// </summary>
@@ -46,4 +46,3 @@ namespace CryptoExchange.Net.Objects.Options
         set => base.ApiCredentials = value;
     }
 }
-}

CryptoExchange.Net/Objects/Options/RestExchangeOptions.cs

@@ -1,8 +1,8 @@
-using CryptoExchange.Net.Authentication;
+using CryptoExchange.Net.Authentication;
 using System;
 
-namespace CryptoExchange.Net.Objects.Options
+namespace CryptoExchange.Net.Objects.Options;
-{
+
 /// <summary>
 /// Options for a rest exchange client
 /// </summary>
@@ -21,7 +21,7 @@ namespace CryptoExchange.Net.Objects.Options
     /// <summary>
     /// Whether caching is enabled. Caching will only be applied to GET http requests. The lifetime of cached results can be determined by the `CachingMaxAge` option
     /// </summary>
-        public bool CachingEnabled { get; set; } = false;
+    public bool CachingEnabled { get; set; }
 
     /// <summary>
     /// The max age of a cached entry, only used when the `CachingEnabled` options is set to true. When a cached entry is older than the max age it will be discarded and a new server request will be done
@@ -88,4 +88,3 @@ namespace CryptoExchange.Net.Objects.Options
         set => base.ApiCredentials = value;
     }
 }
-}