From 9d3295acc7d892c248072619dd1745072dac25db Mon Sep 17 00:00:00 2001 From: Jkorf Date: Fri, 31 Oct 2025 15:08:14 +0100 Subject: [PATCH] Removed some unhelpful verbose logs --- CryptoExchange.Net/Clients/BaseClient.cs | 2 -- .../Extensions/SocketConnectionLoggingExtension.cs | 11 ----------- CryptoExchange.Net/Sockets/SocketConnection.cs | 5 +---- 3 files changed, 1 insertion(+), 17 deletions(-) diff --git a/CryptoExchange.Net/Clients/BaseClient.cs b/CryptoExchange.Net/Clients/BaseClient.cs index 7523423..5d3fc5f 100644 --- a/CryptoExchange.Net/Clients/BaseClient.cs +++ b/CryptoExchange.Net/Clients/BaseClient.cs @@ -102,7 +102,6 @@ namespace CryptoExchange.Net.Clients if (ClientOptions == null) throw new InvalidOperationException("Client should have called Initialize before adding API clients"); - _logger.Log(LogLevel.Trace, $" {apiClient.GetType().Name}, base address: {apiClient.BaseAddress}"); ApiClients.Add(apiClient); return apiClient; } @@ -122,7 +121,6 @@ namespace CryptoExchange.Net.Clients /// public virtual void Dispose() { - _logger.Log(LogLevel.Debug, "Disposing client"); foreach (var client in ApiClients) client.Dispose(); } diff --git a/CryptoExchange.Net/Logging/Extensions/SocketConnectionLoggingExtension.cs b/CryptoExchange.Net/Logging/Extensions/SocketConnectionLoggingExtension.cs index af6a61b..67b72eb 100644 --- a/CryptoExchange.Net/Logging/Extensions/SocketConnectionLoggingExtension.cs +++ b/CryptoExchange.Net/Logging/Extensions/SocketConnectionLoggingExtension.cs @@ -13,7 +13,6 @@ namespace CryptoExchange.Net.Logging.Extensions private static readonly Action _unknownExceptionWhileProcessingReconnection; private static readonly Action _webSocketErrorCodeAndDetails; private static readonly Action _webSocketError; - private static readonly Action _messageSentNotPending; private static readonly Action _receivedData; private static readonly Action _failedToParse; private static readonly Action _failedToEvaluateMessage; @@ -72,11 +71,6 @@ namespace CryptoExchange.Net.Logging.Extensions new EventId(2005, "WebSocketError"), "[Sckt {SocketId}] error: {ErrorMessage}"); - _messageSentNotPending = LoggerMessage.Define( - LogLevel.Debug, - new EventId(2006, "MessageSentNotPending"), - "[Sckt {SocketId}] [Req {RequestId}] message sent, but not pending"); - _receivedData = LoggerMessage.Define( LogLevel.Trace, new EventId(2007, "ReceivedData"), @@ -234,11 +228,6 @@ namespace CryptoExchange.Net.Logging.Extensions _webSocketError(logger, socketId, errorMessage, e); } - public static void MessageSentNotPending(this ILogger logger, int socketId, int requestId) - { - _messageSentNotPending(logger, socketId, requestId, null); - } - public static void ReceivedData(this ILogger logger, int socketId, string originalData) { _receivedData(logger, socketId, originalData, null); diff --git a/CryptoExchange.Net/Sockets/SocketConnection.cs b/CryptoExchange.Net/Sockets/SocketConnection.cs index cc26940..6d1ee98 100644 --- a/CryptoExchange.Net/Sockets/SocketConnection.cs +++ b/CryptoExchange.Net/Sockets/SocketConnection.cs @@ -449,10 +449,7 @@ namespace CryptoExchange.Net.Sockets } if (query == null) - { - _logger.MessageSentNotPending(SocketId, requestId); - return Task.CompletedTask; - } + return Task.CompletedTask; query.IsSend(query.RequestTimeout ?? ApiClient.ClientOptions.RequestTimeout); return Task.CompletedTask;